<div dir="ltr"><div><span style="font-family:arial,sans-serif;font-size:13px">Ping for maintainer...</span><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><br></span></div>

<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><div>
<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><br></span></div>diff --git a/merge-helpers/check_submission b/merge-helpers/check_submission</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">index a934646..5444b1b 100755</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">--- a/merge-helpers/check_submission</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">+++ b/merge-helpers/check_submission</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">@@ -198,10 +198,8 @@ function check_methods(){</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">            echo $bsp : ${i%(*}"()" present in file $(grep -rlE "[a-z|A-Z|0-9|_]+[ ]*$i[ ]*\(" *)</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">           fi</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">        else</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">-          if [[ $warnings -eq "1" || $important -eq "1" || $verbose -eq "1" ]]; then</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">            echo "$bsp : $(basename $filename) : ${i%(*}() function does not exist in $filename "</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">            flag="1"</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">-          fi</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">            faults="1"</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">        fi</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">      fi</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">@@ -687,4 +685,6 @@ start "$@"</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"># End of Checks</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">if [[ $faults -eq "0" ]] ; then</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">  echo -e "\nNo faults found in BSP organization"</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">+else</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px"><span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">+  echo -e "\nFound faults in BSP organization. Please, check"</span><br style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">


<span style="color:rgb(0,0,0);font-family:'Courier New',Courier,monospace;font-size:14px">fi</span><br><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Regards.<br clear="all">

<div><div dir="ltr"><div><br><img src="http://www.tallertechnologies.com/templates/tallertechnologies/images/signature.png" height="77" width="200"><br>
</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><font size="4">Martin Boretto</font><br></span><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline">Software Engineer</span><br>


</div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><br></span></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><div style="color:rgb(34,34,34);font-family:arial,sans-serif">


<span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline">Taller Technologies - Argentina<br>


</span></span></div><span style="font-size:11px;background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"><font size="1"><font face="arial, helvetica, sans-serif" size="1"><span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">San Lorenzo 47, 3rd Floor, Office 5</span><br>


<span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Córdoba, Argentina</span></font></font></span></span></span></div><div><span style="background-color:transparent;vertical-align:baseline"><font color="#000000" face="arial, helvetica, sans-serif" size="1"><span style="white-space:pre-wrap"><br>


</span></font><div style="color:rgb(34,34,34);font-family:arial,sans-serif"><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"></span><b>Mobile:</b></span><b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"></span></b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"> [+54 358 4206995 (ARG)]<br>


</span><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="background-color:transparent;vertical-align:baseline"><b>Skype:</b> tinacho_b</span></span></div>


</span></div></div></div>
<br><br><div class="gmail_quote">2014-06-04 18:21 GMT-03:00 Martin Boretto <span dir="ltr"><<a href="mailto:martin.boretto@tallertechnologies.com" target="_blank">martin.boretto@tallertechnologies.com</a>></span>:<br>


<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Hi everyone,<div><br></div><div>This patch fixes a possible issue. </div>

<div><br></div><div>When a needed function is not found it didn't show the warning but it still put the faults variable to 1. </div>
<div><br>
</div><div>With this patch I propose to always see the warning and set the faults to 1. Also set an ending message saying when not everything went fine. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div dir="ltr"><div><br></div><div><div><div dir="ltr"><div><br><img src="http://www.tallertechnologies.com/templates/tallertechnologies/images/signature.png" height="77" width="200"><br>

</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><font size="4">Martin Boretto</font><br></span><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline">Software Engineer</span><br>



</div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><br></span></div><div><span style="color:rgb(0,0,0);font-family:Verdana;background-color:transparent;vertical-align:baseline"><div style="color:rgb(34,34,34);font-family:arial,sans-serif">



<span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline">Taller Technologies - Argentina<br>



</span></span></div><span style="font-size:11px;background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"><font size="1"><font face="arial, helvetica, sans-serif" size="1"><span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">San Lorenzo 47, 3rd Floor, Office 5</span><br>



<span style="vertical-align:baseline;white-space:pre-wrap;background-color:transparent">Córdoba, Argentina</span></font></font></span></span></span></div><div><span style="background-color:transparent;vertical-align:baseline"><font color="#000000" face="arial, helvetica, sans-serif" size="1"><span style="white-space:pre-wrap"><br>



</span></font><div style="color:rgb(34,34,34);font-family:arial,sans-serif"><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="font-size:13px;background-color:transparent;vertical-align:baseline"></span><b>Mobile:</b></span><b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"></span></b><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"> [+54 358 4206995 (ARG)]<br>



</span><span style="font-size:11px;font-family:Verdana;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline"><span style="background-color:transparent;vertical-align:baseline"><b>Skype:</b> tinacho_b</span></span></div>



</span></div></div></div>
</div></div>
</blockquote></div><br></div></div>