<div dir="ltr">I'm not sure any of the ARM BSPs use the abort.c or simple_abort.c, even if they have the code included. <div>I don't have access to the code right now, but I will take a look at the ARM BSPs and remove it from the ones that use the shared start.S. </div><div><br></div><div>If the ARM BSPs that do not use the shared start.S include the code, but never call it, I can remove it, if that is what is best. We could even remove abort.c and simple_abort.c completely. Just let me know.</div><div><br></div><div>Alan</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 3, 2014 at 3:08 PM, Joel Sherrill <span dir="ltr"><<a href="mailto:joel.sherrill@oarcorp.com" target="_blank">joel.sherrill@oarcorp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<br>
<div>On 11/3/2014 5:22 AM, Alan Cudmore
wrote:<br>
</div>
<blockquote type="cite">
<p dir="ltr">OK, that makes sense. I'll fix it and resubmit the
patch. Any other ARM BSPs?<br>
</p>
</blockquote>
<br></span>
The warning only shows up in these:<br>
<br>
$ grep abort.c warnings-20141030a.txt <br>
2
c/src/lib/libbsp/arm/rtl22xx/../shared/abort/simple_abort.c:56:6:
warning: no previous prototype for '_print_full_context'
[-Wmissing-prototypes]<br>
2
c/src/lib/libbsp/arm/rtl22xx/../shared/abort/simple_abort.c:108:6:
warning: no previous prototype for 'do_data_abort'
[-Wmissing-prototypes]<br>
1
c/src/lib/libbsp/arm/raspberrypi/../shared/abort/simple_abort.c:56:6:
warning: no previous prototype for '_print_full_context'
[-Wmissing-prototypes]<br>
1
c/src/lib/libbsp/arm/raspberrypi/../shared/abort/simple_abort.c:108:6:
warning: no previous prototype for 'do_data_abort'
[-Wmissing-prototypes]<br>
<br>
which matches a grep:<br>
<br>
$ grep simple_abort.c */M*am<br>
raspberrypi/Makefile.am:libbsp_a_SOURCES +=
../shared/abort/simple_abort.c<br>
rtl22xx/Makefile.am:libbsp_a_SOURCES +=
../shared/abort/simple_abort.c<br>
<br>
When I "grep start.S */M*.am" from libbsp/arm, most BSPs use
shared/start/start.S<br>
but a few have their own start.S. Not sure what the impact of that
is.<br>
<br>
--joel<div><div class="h5"><br>
<br>
<blockquote type="cite">
<p dir="ltr">
Alan</p>
<div class="gmail_quote">On Nov 3, 2014 2:03 AM, "Sebastian Huber"
<<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 03/11/14
02:59, Alan Cudmore wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-libbsp_a_SOURCES += ../shared/abort/simple_abort.c<br>
+libbsp_a_SOURCES += ../shared/abort/abort.c<br>
</blockquote>
<br>
Since this BSP uses the shared start.S file, I would prefer to
remove simple_abort.c and abort.c from the Makefile.am. These
files should go away in the long run.<br>
<br>
The default abort handler is now in:<br>
<br>
<a href="http://git.rtems.org/rtems/tree/cpukit/score/cpu/arm/armv4-exception-default.S" target="_blank">http://git.rtems.org/rtems/tree/cpukit/score/cpu/arm/armv4-exception-default.S</a><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne
des EHUG.<br>
</blockquote>
</div>
</blockquote>
<br>
</div></div><span class="HOEnZb"><font color="#888888"><pre cols="72">--
Joel Sherrill, Ph.D. Director of Research & Development
<a href="mailto:joel.sherrill@OARcorp.com" target="_blank">joel.sherrill@OARcorp.com</a> On-Line Applications Research
Ask me about RTEMS: a free RTOS Huntsville AL 35805
Support Available <a href="tel:%28256%29%20722-9985" value="+12567229985" target="_blank">(256) 722-9985</a></pre>
</font></span></div>
</blockquote></div><br></div>