<html><head></head><body>Ok, Thanks!<br>
<br>
DanielH<br><br><div class="gmail_quote">On 24 November 2014 17:15:03 CET, Jiri Gaisler <jiri@gaisler.se> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 11/24/2014 05:02 PM, Daniel Hellstrom wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Ok, what about ERC32 which has the same macros?<br /></blockquote><br />ERC32 is correctly defined. The leon2/3 were wrong because the<br />defines were copied from ERC32, but the mask bits have opposite<br />meaning ...<br /><br />Jiri.<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> <br /> On 11/24/2014 04:41 PM, Gedare Bloom wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Daniel commit these if you agree with the assessment.<br /><br /> On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler <jiri@gaisler.se> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left:
1ex;"> Condition needs to be inverted, as a 1 in the mask register means<br /> that the interrupt is enabled. Solves ticket #1959 in trac.<br /> ---<br /> c/src/lib/libbsp/sparc/leon2/include/leon.h | 2 +-<br /> 1 file changed, 1 insertion(+), 1 deletion(-)<br /><br /> diff --git a/c/src/lib/libbsp/sparc/leon2/include/leon.h<br /> b/c/src/lib/libbsp/sparc/leon2/include/leon.h<br /> index 8d2f0c5c..7ec6b1d 100644<br /> --- a/c/src/lib/libbsp/sparc/leon2/include/leon.h<br /> +++ b/c/src/lib/libbsp/sparc/leon2/include/leon.h<br /> @@ -307,7 +307,7 @@ static __inline__ int bsp_irq_fixup(int irq)<br /> (LEON_REG.Interrupt_Pending & (1 << (_source)))<br /><br /> #define LEON_Is_interrupt_masked( _source ) \<br /> - (LEON_REG.Interrupt_Masked & (1 << (_source)))<br /> + (!(LEON_REG.Interrupt_Mask & (1 << (_source))))<br /><br /> #define LEON_Mask_interrupt( _source ) \<br /> do { \<br /> -- <br /> 1.9.1<br /><br /><hr /><br /> devel
mailing list<br /> devel@rtems.org<br /> <a href="http://lists.rtems.org/mailman/listinfo/devel">http://lists.rtems.org/mailman/listinfo/devel</a><br /></blockquote></blockquote> <br /></blockquote><br /></pre></blockquote></div></body></html>