<div dir="ltr">This is the test committed with the original ticket #2124 ticket see <a href="https://devel.rtems.org/ticket/2124">https://devel.rtems.org/ticket/2124</a> and <a href="http://comments.gmane.org/gmane.os.rtems.devel/78">http://comments.gmane.org/gmane.os.rtems.devel/78</a>. The test is a bit confusing because the output in .scn matches when configured without RTEMS_ENABLE_STRICT_ORDER_MUTEX=1 but doesn't match when configured with that option. It definitely should be an explicit failure (rather than an output mismatch) to handle both configuration cases. Also updating the .doc to include a note about testing strict order mutexes would probably be best.</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 5, 2015 at 9:57 PM, Joel Sherrill <span dir="ltr"><<a href="mailto:joel.sherrill@oarcorp.com" target="_blank">joel.sherrill@oarcorp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Is this error with the default gglg priority inherit algorithm or with the onf which restores at each unlock step? If the default algorithm, the test is broken. If the alternative algorithm, the test needs to be reworked a bit to check the correct behavior for each algorithm.<br>
<br>
Fwiw the test should fail if there is an error detected. Printing a message and continuing isn't right. So this much is broken either way.<br>
<br>
Sorry to be imprecise but I don't know how you configured.<br>
<br>
If the .doc or .scn file isn't up to date, submit patches.<br>
<div class="HOEnZb"><div class="h5"><br>
On June 5, 2015 7:09:53 PM CDT, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>> wrote:<br>
>Hi,<br>
><br>
>I tried to run spsem02 test case and found that the results were not as<br>
>per mentioned in the respective document. And even document had some<br>
>typos which I have corrected in my branch.<br>
><br>
>*** BEGIN OF TEST SPSEM 2 ***<br>
>init: S0 created<br>
>init: S1 created<br>
>init: TA01 created with priority 36<br>
>init: TA02 created with priority 34<br>
>init: TA03 created with priority 32<br>
>TA01: started with priority 36<br>
>TA01: priority 36, holding S0<br>
>TA01: priority 36, holding S0, S1<br>
>TA02: started with priority 34<br>
>TA03: started with priority 32<br>
>TA01: priority 32, holding S0, S1<br>
>TA02: priority 34, holding S1<br>
>TA02: suspending<br>
>TA01: priority 36, holding S0 ---> priority not properly stepped<br>
>down!!!<br>
>TA03: priority 32, holding S0<br>
>TA03: priority 32<br>
>TA03: exiting<br>
>TA01: priority 36<br>
>TA01: exiting<br>
>*** END OF TEST SPSEM 2 ***<br>
><br>
>You can find link for my wiki and github:<br>
><br>
>github link: <a href="https://github.com/saurabhgadia4/rtems" target="_blank">https://github.com/saurabhgadia4/rtems</a><br>
><br>
>wiki link: <a href="https://devel.rtems.org/wiki/GSoC/2015/NestedMutex" target="_blank">https://devel.rtems.org/wiki/GSoC/2015/NestedMutex</a><br>
><br>
><br>
>I feel like I should implement my solution very soon along with<br>
>progressing on JPF and check if expected output is achieved or not.<br>
><br>
><br>
><br>
><br>
>Thanks,<br>
><br>
><br>
>Saurabh Gadia<br>
><br>
><br>
>On Fri, Jun 5, 2015 at 1:42 PM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>> wrote:<br>
><br>
>Hi,<br>
><br>
>installing pax work. But you have to again do the bootstrap step,<br>
>configuration and compiling.<br>
><br>
>Thanks.<br>
><br>
><br>
>Thanks,<br>
><br>
><br>
>Saurabh Gadia<br>
><br>
><br>
>On Fri, Jun 5, 2015 at 12:44 PM, Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br>
><br>
>I'm not really sure, but I think you probably have to re-run configure.<br>
><br>
><br>
>On Fri, Jun 5, 2015 at 3:40 PM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>> wrote:<br>
>> Hi Gedare,<br>
>> I installed pax but same problem persists. So should I again<br>
>bootstrap the<br>
>> complete thing or do we have to refer pax in any make or config<br>
>files?<br>
>><br>
>> Thanks,<br>
>><br>
>> Saurabh Gadia<br>
>><br>
>> On Fri, Jun 5, 2015 at 10:56 AM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>> wrote:<br>
>>><br>
>>> Ok. Thanks a lot. Will continue with compiling and JPF setup this<br>
>week as<br>
>>> discussed with Cyrille. And if time permits will look into how to<br>
>emulate<br>
>>> the things in JPF. And also provide ppt in deoxygen for revised<br>
>rtems code.<br>
>>><br>
>>><br>
>>> On Friday, June 5, 2015, Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br>
>>>><br>
>>>> Hi Saurabh,<br>
>>>><br>
>>>> This is a current problem in RTEMS. You need to have 'pax'<br>
>installed<br>
>>>> on your development host to build the dl tests. So, it looks good<br>
>to<br>
>>>> me!<br>
>>>><br>
>>>> Gedare<br>
>>>><br>
>>>> On Thu, Jun 4, 2015 at 9:16 PM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>wrote:<br>
>>>> > I am sorry for not attaching the patch and configuration command:<br>
>>>> ><br>
>>>> > ../rtems/configure --target=sparc-rtems4.11 --enable-rtemsbsp=sis<br>
>>>> > --enable-tests --disable-posix ENABLE_STRICT_ORDER_MUTEX=1<br>
>>>> ><br>
>>>> ><br>
>>>> ><br>
>>>> > Thanks,<br>
>>>> ><br>
>>>> > Saurabh Gadia<br>
>>>> ><br>
>>>> > On Thu, Jun 4, 2015 at 6:08 PM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>wrote:<br>
>>>> >><br>
>>>> >> Hi,<br>
>>>> >> I worked out that bug related to strict_mutex and gone past that<br>
>bug.<br>
>>>> >> But<br>
>>>> >> now I have issue while compiling the libtests. Below is the<br>
>error log:<br>
>>>> >><br>
>>>> >> '''<br>
>>>> >> sparc-rtems4.11-size syscall01.exe<br>
>>>> >> text data bss dec hex filename<br>
>>>> >> 266128 6064 11456 283648 45400<br>
>syscall01.exe<br>
>>>> >> cp syscall01.exe syscall01.ralf<br>
>>>> >> make[6]: Leaving directory<br>
>>>> >><br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/syscall01'<br>
>>>> >> Making all in dl01<br>
>>>> >> make[6]: Entering directory<br>
>>>> >><br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/dl01'<br>
>>>> >> sparc-rtems4.11-gcc -B../../../../../sis/lib/ -specs bsp_specs<br>
>-qrtems<br>
>>>> >> -DHAVE_CONFIG_H -I.<br>
>>>> >><br>
>-I../../../../../../../rtems/c/src/../../testsuites/libtests/dl01 -I..<br>
>>>> >><br>
>>>> >><br>
>-I../../../../../../../rtems/c/src/../../testsuites/libtests/../support/include<br>
>>>> >> -mcpu=cypress -O2 -g -ffunction-sections -fdata-sections -Wall<br>
>>>> >> -Wmissing-prototypes -Wimplicit-function-declaration<br>
>>>> >> -Wstrict-prototypes<br>
>>>> >> -Wnested-externs -MT dl-o1.o -MD -MP -MF .deps/dl-o1.Tpo -c -o<br>
>dl-o1.o<br>
>>>> >><br>
>>>> >><br>
>../../../../../../../rtems/c/src/../../testsuites/libtests/dl01/dl-o1.c<br>
>>>> >> mv -f .deps/dl-o1.Tpo .deps/dl-o1.Po<br>
>>>> >> w -f dl.tar dl-o1.o<br>
>>>> >> 17:44:17 up 2:31, 2 users, load average: 2.27, 0.99, 0.53<br>
>>>> >> USER TTY LOGIN@ IDLE JCPU PCPU WHAT<br>
>>>> >> ../../../../../../tools/build/rtems-bin2c -C dl.tar dl-tar.c<br>
>>>> >> cannot open dl.tar for reading<br>
>>>> >> make[6]: *** [dl-tar.c] Error 1<br>
>>>> >> make[6]: Leaving directory<br>
>>>> >><br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests/dl01'<br>
>>>> >> make[5]: *** [all-local] Error 1<br>
>>>> >> make[5]: Leaving directory<br>
>>>> >><br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests'<br>
>>>> >> make[4]: *** [all] Error 2<br>
>>>> >> make[4]: Leaving directory<br>
>>>> >><br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites/libtests'<br>
>>>> >> make[3]: *** [all-recursive] Error 1<br>
>>>> >> make[3]: Leaving directory<br>
>>>> >><br>
>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/testsuites'<br>
>>>> >> make[2]: *** [all-recursive] Error 1<br>
>>>> >> make[2]: Leaving directory<br>
>>>> >> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis'<br>
>>>> >> make[1]: *** [all-recursive] Error 1<br>
>>>> >> make[1]: Leaving directory<br>
>>>> >> `/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c'<br>
>>>> >> make: *** [all-recursive] Error 1<br>
>>>> >> saurabh@saurabh-Inspiron-N5010:~/dev1/kernel/b-sis$ ls<br>
>>>> >> '''<br>
>>>> >><br>
>>>> >> I am not able to find dl-tar.c but we have dl-tar.Po. Can anyone<br>
>guide<br>
>>>> >> me<br>
>>>> >> on this. How should I proceed with this.<br>
>>>> >><br>
>>>> >> Thanks,<br>
>>>> >><br>
>>>> >> Saurabh Gadia<br>
>>>> >><br>
>>>> >> On Mon, Jun 1, 2015 at 7:48 AM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>wrote:<br>
>>>> >>><br>
>>>> >>> I am on it.<br>
>>>> >>><br>
>>>> >>><br>
>>>> >>> On Monday, June 1, 2015, Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br>
>>>> >>>><br>
>>>> >>>> Hi Saurabh,<br>
>>>> >>>><br>
>>>> >>>> Please try to figure out how to fix the compile-error. You can<br>
>see<br>
>>>> >>>> that the problem occurs in the #ifdef'd<br>
>STRICT_ORDER_MUTEX_CODE, so<br>
>>>> >>>> that makes sense why others have not observed the same issue.<br>
>It<br>
>>>> >>>> appears you will have to reconcile the new<br>
>_Thread_Change_priority<br>
>>>> >>>> arguments with what is being used in that block of code. If<br>
>you need<br>
>>>> >>>> more guidance please ask.<br>
>>>> >>>><br>
>>>> >>>> Gedare<br>
>>>> >>>><br>
>>>> >>>> On Mon, Jun 1, 2015 at 12:35 AM, Saurabh Gadia <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>>>> >>>> wrote:<br>
>>>> >>>> > I wanted to test the ENABLE_STRICT_ORDER_MUTEX=1 related<br>
>sptests<br>
>>>> >>>> > for<br>
>>>> >>>> > "nested<br>
>>>> >>>> > mutex" GSOC project. So please let me know what can be done.<br>
>>>> >>>> ><br>
>>>> >>>> > Thanks,<br>
>>>> >>>> ><br>
>>>> >>>> > Saurabh Gadia<br>
>>>> >>>> ><br>
>>>> >>>> > On Sun, May 31, 2015 at 9:33 PM, Saurabh Gadia<br>
><<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>>>> >>>> > wrote:<br>
>>>> >>>> >><br>
>>>> >>>> >> Hi,<br>
>>>> >>>> >> so I am working for sparc-sis setting and master branch.<br>
>And if<br>
>>>> >>>> >> you<br>
>>>> >>>> >> see<br>
>>>> >>>> >> the code in threadimpl.h and threadchangepriority.c and<br>
>>>> >>>> >> coremutexsurrender.c<br>
>>>> >>>> >> the definition of _Thread_Change_priority() is having<br>
>mismatch<br>
>>>> >>>> >> calling. Git<br>
>>>> >>>> >> records says that there was change to above function<br>
>structure<br>
>>>> >>>> >> done<br>
>>>> >>>> >> by<br>
>>>> >>>> >> sebastian huber. But I guess he forgot to change the<br>
>definition<br>
>>>> >>>> >> of<br>
>>>> >>>> >> _Thread_Change_priority() in threadimpl.h and call in<br>
>>>> >>>> >> coremutexsurrender.c<br>
>>>> >>>> >><br>
>>>> >>>> >> Configuration command:<br>
>>>> >>>> >> ./configure --target=sparc-rtems4.11 --enable-rtemsbsp=sis<br>
>>>> >>>> >> --enable-tests<br>
>>>> >>>> >> --disable-posix ENABLE_STRICT_ORDER_MUTEX=1<br>
>>>> >>>> >><br>
>>>> >>>> >> Error Log:<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >> ^<br>
>>>> >>>> >> In file included from<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../cpukit/../../../sis/lib/include/rtems/score/coremuteximpl.h:24:0,<br>
>>>> >>>> >> from<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:23:<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../cpukit/../../../sis/lib/include/rtems/score/threadimpl.h:394:6:<br>
>>>> >>>> >> note: expected 'void *' but argument is of type 'int'<br>
>>>> >>>> >> void _Thread_Change_priority(<br>
>>>> >>>> >> ^<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:60:7:<br>
>>>> >>>> >> error: too few arguments to function<br>
>'_Thread_Change_priority'<br>
>>>> >>>> >> _Thread_Change_priority( holder,<br>
>>>> >>>> >> mutex->queue.priority_before,<br>
>>>> >>>> >> true<br>
>>>> >>>> >> );<br>
>>>> >>>> >> ^<br>
>>>> >>>> >> In file included from<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../cpukit/../../../sis/lib/include/rtems/score/coremuteximpl.h:24:0,<br>
>>>> >>>> >> from<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../../../../../rtems/c/src/../../cpukit/score/src/coremutexsurrender.c:23:<br>
>>>> >>>> >><br>
>>>> >>>> >><br>
>../../cpukit/../../../sis/lib/include/rtems/score/threadimpl.h:394:6:<br>
>>>> >>>> >> note: declared here<br>
>>>> >>>> >> void _Thread_Change_priority(<br>
>>>> >>>> >> ^<br>
>>>> >>>> >> make[6]: *** [src/libscore_a-coremutexsurrender.o] Error 1<br>
>>>> >>>> >><br>
>>>> >>>> >> Thanks,<br>
>>>> >>>> >><br>
>>>> >>>> >> Saurabh Gadia<br>
>>>> >>>> >><br>
>>>> >>>> >> On Sun, May 31, 2015 at 8:25 PM, Nick Withers<br>
>>>> >>>> >> <<a href="mailto:nick.withers@anu.edu.au">nick.withers@anu.edu.au</a>><br>
>>>> >>>> >> wrote:<br>
>>>> >>>> >>><br>
>>>> >>>> >>> Does re-running bootstrap in the source dir and<br>
>re-configuring<br>
>>>> >>>> >>> sort<br>
>>>> >>>> >>> it?<br>
>>>> >>>> >>> --<br>
>>>> >>>> >>> Nick Withers<br>
>>>> >>>> >>><br>
>>>> >>>> >>> Embedded Systems Programmer<br>
>>>> >>>> >>> Department of Nuclear Physics, Research School of Physics<br>
>and<br>
>>>> >>>> >>> Engineering<br>
>>>> >>>> >>> The Australian National University (CRICOS: 00120C)<br>
>>>> >>>> >>><br>
>>>> >>>> >>> On Sun, 2015-05-31 at 20:31 -0400, Joel Sherrill wrote:<br>
>>>> >>>> >>> > More information is needed. Target architecture, bsp,<br>
>>>> >>>> >>> > configure<br>
>>>> >>>> >>> > command.<br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > I have been building all bsps regularly and unless it<br>
>got<br>
>>>> >>>> >>> > broken<br>
>>>> >>>> >>> > this<br>
>>>> >>>> >>> > weekend, something else is up<br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > On May 31, 2015 7:57:04 PM EDT, Saurabh Gadia<br>
><<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>>>> >>>> >>> > wrote:<br>
>>>> >>>> >>> > >The problem is on master branch<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >Thanks,<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >Saurabh Gadia<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >On Sun, May 31, 2015 at 4:44 PM, Saurabh Gadia<br>
>>>> >>>> >>> > > <<a href="mailto:gadia@usc.edu">gadia@usc.edu</a>><br>
>>>> >>>> >>> > > wrote:<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >Logs:<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >make[6]: Entering directory<br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > > ><br>
>>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/cpukit/score'<br>
>>>> >>>> >>> > >make[6]: *** No rule to make target<br>
>`src/apimutexislocked.c',<br>
>>>> >>>> >>> > > needed<br>
>>>> >>>> >>> > > by<br>
>>>> >>>> >>> > >`src/libscore_a-apimutexislocked.o'. Stop.<br>
>>>> >>>> >>> > >make[6]: Leaving directory<br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > > ><br>
>>`/home/saurabh/dev1/kernel/b-sis/sparc-rtems4.11/c/sis/cpukit/score'<br>
>>>> >>>> >>> > >make[5]: *** [all-recursive] Error 1<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > > ><br>
>>>> >>>> >>> > > > ><br>
>>...............................................................................................................<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >There is no makefile but I am also not able to find<br>
>>>> >>>> >>> > > apimutexislocked.c<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >How do I proceed about this.<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >Thanks,<br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > ><br>
>>>> >>>> >>> > >Saurabh Gadia<br>
>>>> >>>> >>> ><br>
>>>> >>>> >>> > --joel<br>
>>>> >>>> >>> > _______________________________________________<br>
>>>> >>>> >>> > devel mailing list<br>
>>>> >>>> >>> > <a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
>>>> >>>> >>> > <a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
>>>> >>>> >>><br>
>>>> >>>> >>><br>
>>>> >>>> >><br>
>>>> >>>> ><br>
>>>> >>>> ><br>
>>>> >>>> > _______________________________________________<br>
>>>> >>>> > devel mailing list<br>
>>>> >>>> > <a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
>>>> >>>> > <a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
>>>> >>><br>
>>>> >>><br>
>>>> >>><br>
>>>> >>> --<br>
>>>> >>> Thanks,<br>
>>>> >>><br>
>>>> >>> Saurabh Gadia<br>
>>>> >>><br>
>>>> >><br>
>>>> ><br>
>>><br>
>>><br>
>>><br>
>>> --<br>
>>> Thanks,<br>
>>><br>
>>> Saurabh Gadia<br>
>>><br>
>><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--joel<br>
</font></span></blockquote></div><br></div>