<html><body><div style="font-family: arial,helvetica,sans-serif; font-size: 12pt; color: #000000"><div>Hello Joel,<br></div><div><br data-mce-bogus="1"></div><div>before you start with wild guessing, please look at the patch:<br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><div>https://git.rtems.org/rtems/commit/?id=b618d8cfc54f84d4ed03dc7b7fa510c872e6128a</div><div><br></div><div><span id="zwchr" data-marker="__DIVIDER__">----- Am 8. Dez 2015 um 16:45 schrieb Joel Sherrill <joel@rtems.org>:<br></span></div><div data-marker="__QUOTED_TEXT__"><blockquote style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 8, 2015 at 9:09 AM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank" data-mce-href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;"><span class=""><span class="">On 08/12/15 16:03, Joel Sherrill wrote:<br></span></span><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;">What BSPs/architectures have you tested?<br></blockquote> I temporarily moved the splinkersets01 test to the samples/ticker and tested that all BSPs build and link this test.<br><br> I executed the splinkersets01 test on sis, psim and arm_realview_pbx_a9_qemu.<span class=""><span class=""><br> <br></span></span><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;"><br> Is this something that breaks on a per BSP basis? or per architecture basis?<br> I am assuming that since it is linker based, each BSP could have broken linkcmds.<br> Is that right?<br></blockquote> It breaks on a per linker command file basis. Since all the maintained BSPs use a linkercmds.base, which shouldn't be a big issue.<br><br></blockquote><br><div>That means a LOT of the BSPs are broken. </div></div></div></div></blockquote><div><br></div><div>Why do you think BSPs are broken? If you look at my commit, then you will see that I edited every linker command file by hand! Please note that there are no changes for the ARM (except the GBA BSP, which is a removal candidate if you ask me), SPARC and i386. They already use the linker sets for the libbsd.<br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><blockquote style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>You have defined maintained in your own way.</div></div></div></div></blockquote><div><br></div><div>You can use other definitions and end up likely with the same set of BSPs.<br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><blockquote style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>There are only a handful of architectures with linkcmds.base in them:</div><br><div><div>./or1k/shared/startup/linkcmds.base</div><div>./arm/shared/startup/linkcmds.base</div><div>./m68k/shared/startup/linkcmds.base</div><div>./powerpc/tqm8xx/startup/linkcmds.base</div><div>./powerpc/gen5200/startup/linkcmds.base</div><div>./powerpc/shared/startup/linkcmds.base</div><div>./sparc/shared/startup/linkcmds.base</div></div><br><div>I am not sure how many BSPs within arm, m68k, or powerpc actually use the linkcmds.base.</div><br><div>By my count, 13 of 94 BSP families have linkcmds.base. </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;" data-mce-style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: #cccccc; border-left-style: solid; padding-left: 1ex;">For requirements on the linker command file, see new chapter in user manual. However BSPs should not deal with this in copy and paste linker command files and instead use a linkercmds.base file.<div class=""><div class="h5"><br></div></div></blockquote><br><div>So 85% of the BSP families don't use linkcmds.base and by the above statement,</div><div>they must immediately be migrated to linkcmds.base. </div></div></div></div></blockquote><div><br></div><div>No, nothing must be migrated. In fact such a migration would be very risky. You just need two section descriptions in the linker command file (see user manual chapter).<br data-mce-bogus="1"></div><div><br data-mce-bogus="1"></div><blockquote style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;" data-mce-style="border-left: 2px solid #1010FF; margin-left: 5px; padding-left: 5px; color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><br><div>Unless you have a plan to address this problem, I am on the side of rejecting the</div><div>part of this patch that changes the initialization. And the issue must be addressed</div><div>before this can be merged.</div></div></div></div></blockquote><div><br></div><div>I am not aware of any issues, except the dependency on the GNU linker.<br></div><div><br data-mce-bogus="1"></div></div></div></body></html>