<p dir="ltr">This seems OK. </p>
<p dir="ltr">I think it is in sync with the simulator clock tick idle thread. But double check.</p>
<div class="gmail_quote">On Feb 17, 2016 5:54 AM, "Sebastian Huber" <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Move thread dispatch disable check to legacy rtems_clock_tick(). Assert<br>
that thread dispatching is disabled in _Watchdog_Tick(). This is<br>
usually the case, since this function is called in interrupt context by<br>
the clock tick service routine.<br>
---<br>
cpukit/rtems/src/clocktick.c | 5 +++++<br>
cpukit/score/src/watchdogtick.c | 8 ++++----<br>
2 files changed, 9 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/cpukit/rtems/src/clocktick.c b/cpukit/rtems/src/clocktick.c<br>
index a6bf26d..df8012e 100644<br>
--- a/cpukit/rtems/src/clocktick.c<br>
+++ b/cpukit/rtems/src/clocktick.c<br>
@@ -20,6 +20,7 @@<br>
<br>
#include <rtems/rtems/clock.h><br>
#include <rtems/score/timecounter.h><br>
+#include <rtems/score/threadimpl.h><br>
<br>
rtems_status_code rtems_clock_tick( void )<br>
{<br>
@@ -32,5 +33,9 @@ rtems_status_code rtems_clock_tick( void )<br>
&lock_context<br>
);<br>
<br>
+ if ( _Thread_Dispatch_is_enabled() ) {<br>
+ _Thread_Dispatch();<br>
+ }<br>
+<br>
return RTEMS_SUCCESSFUL;<br>
}<br>
diff --git a/cpukit/score/src/watchdogtick.c b/cpukit/score/src/watchdogtick.c<br>
index b9bc3f7..cb68ea2 100644<br>
--- a/cpukit/score/src/watchdogtick.c<br>
+++ b/cpukit/score/src/watchdogtick.c<br>
@@ -12,8 +12,9 @@<br>
* <a href="http://www.rtems.org/license/LICENSE" rel="noreferrer" target="_blank">http://www.rtems.org/license/LICENSE</a>.<br>
*/<br>
<br>
+#include <rtems/score/assert.h><br>
#include <rtems/score/schedulerimpl.h><br>
-#include <rtems/score/threadimpl.h><br>
+#include <rtems/score/threaddispatch.h><br>
#include <rtems/score/todimpl.h><br>
#include <rtems/score/watchdogimpl.h><br>
<br>
@@ -23,12 +24,11 @@<br>
<br>
void _Watchdog_Tick( void )<br>
{<br>
+ _Assert( !_Thread_Dispatch_is_enabled() );<br>
+<br>
_TOD_Tickle_ticks();<br>
<br>
_Watchdog_Tickle_ticks();<br>
<br>
_Scheduler_Tick();<br>
-<br>
- if ( _Thread_Dispatch_is_enabled() )<br>
- _Thread_Dispatch();<br>
}<br>
--<br>
1.8.4.5<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>