<div dir="ltr">I don't know how these extra pieces got in that patch. :(<div><br></div><div>I will remove the pieces other than cpuusagetop.c.</div><div><br></div><div>For threadglobalconstruction.c, I am switching to just RTEMS_UNREACHABLE()</div><div>in place of this:</div><div><br></div><div><div>#ifdef __GNUC__</div><div> __builtin_unreachable();</div><div>#endif</div><div> _Assert_Not_reached();</div></div><div><br></div><div>I will send a new series of patches once the test builds complete.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 22, 2016 at 9:46 AM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The commit message doesn't cover all changes.<div><div class="h5"><br>
<br>
On 22/03/16 15:40, Joel Sherrill wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
cpukit/libmisc/cpuuse/cpuusagetop.c | 1 -<br>
cpukit/score/src/threadglobalconstruction.c | 3 +++<br>
testsuites/sptests/Makefile.am | 2 +-<br>
testsuites/sptests/sp13/task1.c | 9 +++++----<br>
4 files changed, 9 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/cpukit/libmisc/cpuuse/cpuusagetop.c b/cpukit/libmisc/cpuuse/cpuusagetop.c<br>
index 9b92858..cf896e3 100644<br>
--- a/cpukit/libmisc/cpuuse/cpuusagetop.c<br>
+++ b/cpukit/libmisc/cpuuse/cpuusagetop.c<br>
@@ -465,7 +465,6 @@ rtems_cpuusage_top_thread (rtems_task_argument arg)<br>
for (i = 0; i < data->task_count; i++)<br>
{<br>
Thread_Control* thread = data->tasks[i];<br>
- Timestamp_Control last;<br>
Timestamp_Control usage;<br>
Timestamp_Control current_usage;<br>
diff --git a/cpukit/score/src/threadglobalconstruction.c b/cpukit/score/src/threadglobalconstruction.c<br>
index 1e84124..bc96317 100644<br>
--- a/cpukit/score/src/threadglobalconstruction.c<br>
+++ b/cpukit/score/src/threadglobalconstruction.c<br>
@@ -62,5 +62,8 @@ void _Thread_Global_construction(<br>
_Thread_Restart( executing, executing, entry );<br>
_Thread_Enable_dispatch();<br>
+#ifdef __GNUC__<br>
+ __builtin_unreachable();<br>
+#endif<br>
_Assert_Not_reached();<br>
}<br>
</blockquote>
<br></div></div>
Maybe use new RTEMS_UNREACHABLE(). Maybe the RTEMS_UNREACHABLE() should generate a fatal error in case RTEMS_DEBUG is defined to avoid the undefined behaviour.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/testsuites/sptests/Makefile.am b/testsuites/sptests/Makefile.am<br>
index 43f3d82..53adfc1 100644<br>
--- a/testsuites/sptests/Makefile.am<br>
+++ b/testsuites/sptests/Makefile.am<br>
@@ -65,7 +65,7 @@ _SUBDIRS += sptls03<br>
_SUBDIRS += spcpucounter01<br>
if HAS_CPLUSPLUS<br>
_SUBDIRS += spglobalcon01<br>
-_SUBDIRS += sptls02<br>
+## _SUBDIRS += sptls02<br>
endif<br>
_SUBDIRS += sptls01<br>
_SUBDIRS += spintrcritical20<br>
</blockquote>
<br></span>
Conflict with later patch?<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
diff --git a/testsuites/sptests/sp13/task1.c b/testsuites/sptests/sp13/task1.c<br>
index e104e8d..58859c0 100644<br>
--- a/testsuites/sptests/sp13/task1.c<br>
+++ b/testsuites/sptests/sp13/task1.c<br>
@@ -352,10 +352,11 @@ rtems_test_pause();<br>
for (cp = (big_receive_buffer + size);<br>
cp < (big_receive_buffer + sizeof(big_receive_buffer));<br>
- cp++)<br>
- if (*cp != 'Z') {<br>
- puts("TA1 - exact size overrun match failed");<br>
- rtems_test_exit(1);<br>
+ cp++) {<br>
+ if (*cp != 'Z') {<br>
+ puts("TA1 - exact size overrun match failed");<br>
+ rtems_test_exit(1);<br>
+ }<br>
}<br>
/* all done with this one; delete it */<br>
</blockquote>
<br></span>
Conflict with later patch?<span class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
</font></span></blockquote></div><br></div>