<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 19, 2016 at 2:51 PM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">I updated the rules to modify FreeBSD code. Please follow them. In particular we have:<br>
<br>
"Add nothing (even blank lines) before or after the |__rtems__| guards. Always include a |__rtems__| in the guards"<br></blockquote><div><br></div><div>Actually in some places while adding the |__rtems__| guards, some blank lines were getting deleted. So the first rule was beig violated. "Only add lines. If your patch contains lines starting with a '-', then this is wrong." </div><div><br></div><div>I will correct the other mistakes. i.e. adding the guards at the begining of the line and including /* __rtems__ */ in the guards. </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
Please don't merge changes for a particular BSP and generic changes into one commit.</blockquote><div><br></div><div>I will correct that. </div><div><br></div><div>Any other thing which I should keep in mind before submitting the final patches ? </div><div><br></div><div>Also, do I have to send all the patches again ? or just the ones which I will add now. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5"><br>
<br>
On 19/08/16 10:46, Deval Shah wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
---<br>
freebsd/sys/dev/usb/net/if_sms<wbr>c.c | 44 ++++++++++++++++++++++<br>
freebsd/sys/dev/usb/net/if_sms<wbr>creg.h | 1 +<br>
freebsd/sys/dev/usb/net/usb_et<wbr>hernet.c | 17 +++++++++<br>
freebsd/sys/sys/sysctl.h | 1 +<br>
rtemsbsd/include/bsp/nexus-dev<wbr>ices.h | 2 +<br>
rtemsbsd/include/machine/rtems<wbr>-bsd-nexus-bus.h | 18 +++++++++<br>
.../include/rtems/bsd/test/<a href="http://network-config.h.in" rel="noreferrer" target="_blank">net<wbr>work-config.h.in</a> | 2 +<br>
7 files changed, 85 insertions(+)<br>
</blockquote>
<br></div></div><span class=""><font color="#888888">
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brain<wbr>s.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Deval Shah</div><div>Graduate Student,</div><div><div style="font-size:12.8px">B.E. (Hons.) Electrical and Electronics Engineering<br></div><div style="font-size:12.8px"><a href="http://www.bits-pilani.ac.in/hyderabad/" style="color:rgb(17,85,204);font-size:12.8px" target="_blank">BITS Pilani Hyderabad Campus</a></div></div><img src="https://encrypted-tbn2.gstatic.com/images?q=tbn:ANd9GcQrfqfQ2BeDwbmyqDm6xXZtDzweCXlsUaVTjJkCOsZ3eyztVIs8dg"><br></div><div><a href="https://github.com/deval-maker" target="_blank">Github Profile</a></div></div></div></div>
</div></div><div hspace="streak-pt-mark" style="max-height:1px"><img style="width:0px;max-height:0px;overflow:hidden" src="https://mailfoogae.appspot.com/t?sender=aZGV2YWwubWFrZXJAZ21haWwuY29t&type=zerocontent&guid=56099863-a399-495e-b728-af596d8186d2"><font color="#ffffff" size="1">ᐧ</font></div>