<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 23, 2016 at 7:08 PM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">I updated the MMC support to use the FreeBSD trunk, 2016-08-23, 9fe7c416e6abb28b1398fd3e568709<wbr>9846800cfd. It would be great if you can use this version as well as a baseline for your work.<br>
<br></blockquote><div><br></div><div>Is it okay if I provide a new patch (not resend in the previous ones) updating the code ? </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
On 22/08/16 10:37, Deval Shah wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<br>
<br>
On Mon, Aug 22, 2016 at 11:25 AM, Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brai<wbr>ns.de</a> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a>>> wrote:<br>
[...]<span class=""><br>
<br>
If you think the guidelines could be more clear, need an<br>
explanation or examples, then we should address this first.<br>
<br>
<br>
I could use some examples on the last rule " Do not disable option header includes via guards. Instead, add an empty option header, e.g. `rtemsbsd/include/rtems/bsd/lo<wbr>cal/opt_xyz.h`. In general, provide empty header files and do not guard includes. "<br>
</span></blockquote>
<br>
Ok, I updated the libbsd.txt.<div class=""><div class="h5"><br></div></div></blockquote><div>I have a small doubt here. <a href="https://git.rtems.org/rtems-libbsd/tree/libbsd.txt#n654">https://git.rtems.org/rtems-libbsd/tree/libbsd.txt#n654</a> </div><div><br></div><div>Do I have to provide all the headers which I want to ignore, with an empty file as mentioned or only the ones which are transformed by the import script ?</div><div><br></div><div>For example includes like these. "#include <dev/ofw/ofw_bus_subr.h>"</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brain<wbr>s.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Deval Shah</div><div>Graduate Student,</div><div><div style="font-size:12.8px">B.E. (Hons.) Electrical and Electronics Engineering<br></div><div style="font-size:12.8px"><a href="http://www.bits-pilani.ac.in/hyderabad/" style="color:rgb(17,85,204);font-size:12.8px" target="_blank">BITS Pilani Hyderabad Campus</a></div></div><img src="https://encrypted-tbn2.gstatic.com/images?q=tbn:ANd9GcQrfqfQ2BeDwbmyqDm6xXZtDzweCXlsUaVTjJkCOsZ3eyztVIs8dg"><br></div><div><a href="https://github.com/deval-maker" target="_blank">Github Profile</a></div></div></div></div>
</div></div><div hspace="streak-pt-mark" style="max-height:1px"><img style="width:0px;max-height:0px;overflow:hidden" src="https://mailfoogae.appspot.com/t?sender=aZGV2YWwubWFrZXJAZ21haWwuY29t&type=zerocontent&guid=9e58d23d-9e0e-40c4-baed-ff29cc1d0c76"><font color="#ffffff" size="1">ᐧ</font></div>