<div dir="ltr">Okay. Understood. I will update and prepare a patch. </div><div hspace="streak-pt-mark" style="max-height:1px"><img style="width:0px;max-height:0px;overflow:hidden" src="https://mailfoogae.appspot.com/t?sender=aZGV2YWwubWFrZXJAZ21haWwuY29t&type=zerocontent&guid=3cbdb66c-e622-44ad-8fd3-74b0a43d631c"><font color="#ffffff" size="1">ᐧ</font></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 29, 2016 at 12:26 PM, Christian Mauderer <span dir="ltr"><<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Am 27.08.2016 um 13:16 schrieb Deval Shah:<br>
><br>
><br>
> On Tue, Aug 23, 2016 at 7:08 PM, Sebastian Huber<br>
> <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-<wbr>brains.de</a><br>
</span><span class="">> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@<wbr>embedded-brains.de</a>>> wrote:<br>
><br>
> I updated the MMC support to use the FreeBSD trunk, 2016-08-23,<br>
> 9fe7c416e6abb28b1398fd3e568709<wbr>9846800cfd. It would be great if you<br>
> can use this version as well as a baseline for your work.<br>
><br>
><br>
> Is it okay if I provide a new patch (not resend in the previous ones)<br>
> updating the code ?<br>
><br>
><br>
> On 22/08/16 10:37, Deval Shah wrote:<br>
><br>
><br>
><br>
> On Mon, Aug 22, 2016 at 11:25 AM, Sebastian Huber<br>
> <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-<wbr>brains.de</a><br>
> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@<wbr>embedded-brains.de</a>><br>
</span>> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@<wbr>embedded-brains.de</a><br>
<span class="">> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@<wbr>embedded-brains.de</a>>>> wrote:<br>
> [...]<br>
><br>
> If you think the guidelines could be more clear, need an<br>
> explanation or examples, then we should address this first.<br>
><br>
><br>
> I could use some examples on the last rule " Do not disable<br>
> option header includes via guards. Instead, add an empty option<br>
> header, e.g. `rtemsbsd/include/rtems/bsd/<wbr>local/opt_xyz.h`. In<br>
> general, provide empty header files and do not guard includes. "<br>
><br>
><br>
> Ok, I updated the libbsd.txt.<br>
><br>
> I have a small doubt<br>
> here. <a href="https://git.rtems.org/rtems-libbsd/tree/libbsd.txt#n654" rel="noreferrer" target="_blank">https://git.rtems.org/rtems-<wbr>libbsd/tree/libbsd.txt#n654</a><br>
><br>
> Do I have to provide all the headers which I want to ignore, with an<br>
> empty file as mentioned or only the ones which are transformed by the<br>
> import script ?<br>
><br>
> For example includes like these. "#include <dev/ofw/ofw_bus_subr.h>"<br>
><br>
<br>
</span>Hello Deval,<br>
<br>
Sebastian is currently on vacation so he might need some time to answer.<br>
I'll try to give some hints but I'm far from being as familiar with<br>
libbsd as Sebastian is, so he (or some others) might have another opinion.<br>
<br>
Regarding the header: Currently mainly the option headers are empty. If<br>
you do a<br>
<br>
find -size 0 -name "*.h"<br>
<br>
(or some other search for empty files) in the libbsd directory, the<br>
empty headers are option headers and some machine dependent files.<br>
<br>
So if you ask me, it should be OK to disable the mentioned<br>
ofw_bus_subr.h especially because you disabled ofw in the whole file.<br>
<br>
On the other hand an option header that you should add as an empty file<br>
would be opt_platform.h in your patch 5/6.<br>
<br>
Kind regards<br>
<span class="HOEnZb"><font color="#888888"><br>
Christian<br>
--<br>
------------------------------<wbr>--------------<br>
embedded brains GmbH<br>
Christian Mauderer<br>
Dornierstr. 4<br>
D-82178 Puchheim<br>
Germany<br>
email: <a href="mailto:christian.mauderer@embedded-brains.de">christian.mauderer@embedded-<wbr>brains.de</a><br>
Phone: +49-89-18 94 741 - 18<br>
Fax: +49-89-18 94 741 - 08<br>
</font></span><div class="HOEnZb"><div class="h5">PGP: Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Deval Shah</div><div>Graduate Student,</div><div><div style="font-size:12.8px">B.E. (Hons.) Electrical and Electronics Engineering<br></div><div style="font-size:12.8px"><a href="http://www.bits-pilani.ac.in/hyderabad/" style="color:rgb(17,85,204);font-size:12.8px" target="_blank">BITS Pilani Hyderabad Campus</a></div></div><img src="https://encrypted-tbn2.gstatic.com/images?q=tbn:ANd9GcQrfqfQ2BeDwbmyqDm6xXZtDzweCXlsUaVTjJkCOsZ3eyztVIs8dg"><br></div><div><a href="https://github.com/deval-maker" target="_blank">Github Profile</a></div></div></div></div>
</div>