<div dir="ltr"><div><div><div>Hi all,<br><br></div>Like sp71 and sp77. I will prepare sp78 for this overflow testing.<br><br></div>Best,<br></div>Kuan-Hsun<br></div><div class="gmail_extra"><br><div class="gmail_quote">2017-01-25 16:10 GMT+01:00 Kuan Hsun Chen <span dir="ltr"><<a href="mailto:kuan-hsun.chen@tu-dortmund.de" target="_blank">kuan-hsun.chen@tu-dortmund.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi Sebastian,<br><br></div>Should I test the overflow condition together with sp69 or prepare a new test for this matter?<br><br></div>Best,<br></div>Kuan-Hsun<br></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">2017-01-25 15:53 GMT+01:00 Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-<wbr>brains.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><br>
<br>
On 25/01/17 15:48, Kuan-Hsun Chen wrote:<br>
</span><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
cpukit/rtems/src/ratemontimeou<wbr>t.c | 7 +++++--<br>
1 file changed, 5 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/cpukit/rtems/src/ratemontime<wbr>out.c b/cpukit/rtems/src/ratemontime<wbr>out.c<br>
index bcc4ccf..079ad41 100644<br>
--- a/cpukit/rtems/src/ratemontime<wbr>out.c<br>
+++ b/cpukit/rtems/src/ratemontime<wbr>out.c<br>
@@ -9,7 +9,7 @@<br>
* COPYRIGHT (c) 1989-2009.<br>
* On-Line Applications Research Corporation (OAR).<br>
*<br>
- * COPYRIGHT (c) 2016 Kuan-Hsun Chen.<br>
+ * COPYRIGHT (c) 2017 Kuan-Hsun Chen.<br>
</blockquote>
<br></span><span>
This should be 2016, 2017 or 2016-2017.<br>
<br>
</span><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
*<br>
* The license and distribution terms for this file may be<br>
* found in the file LICENSE in this distribution or at<br>
@@ -30,7 +30,10 @@ static void _Rate_monotonic_Renew_deadline<wbr>(<br>
{<br>
uint64_t deadline;<br>
<br>
- ++the_period->postponed_jobs;<br>
+ /** stay at 0xffffffff if postponed_jobs is going to overflow */<br>
</blockquote>
<br></span><span>
/** is a Doxygen comment.<br>
<br>
</span><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ if ( the_period->postponed_jobs != UINT_MAX ) {<br>
+ ++the_period->postponed_jobs;<br>
+ }<br>
</blockquote>
<br></span><span>
Type is uint32_t, not unsigned int. So, use UINT32_MAX. Maybe<br>
<br>
Empty lines between blocks.<br>
<br>
</span><span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
the_period->state = RATE_MONOTONIC_EXPIRED;<br>
<br>
deadline = _Watchdog_Per_CPU_insert_relat<wbr>ive(<br>
</blockquote>
<br></span><span>
We need a test case for this overflow condition. You probably have to modify the_period->postponed_jobs by hand in the test case to avoid extremely long test run times.<br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brain<wbr>s.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br></span>
______________________________<wbr>_________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman<wbr>/listinfo/devel</a><br>
</blockquote></div><br><br clear="all"><br></div></div>-- <br><div class="m_5217236535743440667gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">M.Sc. Kuan-Hsun Chen<br>
<br>
TU Dortmund<br>
Department of Computer Science 12<br>
Design Automation of Embedded Systems<br>
Otto-Hahn-Strasse 16, Room 102<br>
<br>
44227 Dortmund<br>
Germany<br>
<br>
Phone: <u><span style="color:rgb(0,0,255)"><a href="tel:+49%20231%207556124" value="+492317556124" target="_blank">+49 231 755 6124</a></span></u><br>
Mail: <a href="mailto:kuan-hsun.chen@tu-dortmund.de" target="_blank">kuan-hsun.chen@tu-dortmund.de</a><a href="mailto:kuan-hsun.chen@tu-dortmund.de" target="_blank"></a></div></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">M.Sc. Kuan-Hsun Chen<br>
<br>
TU Dortmund<br>
Department of Computer Science 12<br>
Design Automation of Embedded Systems<br>
Otto-Hahn-Strasse 16, Room 102<br>
<br>
44227 Dortmund<br>
Germany<br>
<br>
Phone: <u><span style="color:rgb(0,0,255)">+49 231 755 6124</span></u><br>
Mail: <a href="mailto:kuan-hsun.chen@tu-dortmund.de" target="_blank">kuan-hsun.chen@tu-dortmund.de</a><a href="mailto:kuan-hsun.chen@tu-dortmund.de" target="_blank"></a></div></div>
</div>