<div dir="ltr"><div class="gmail_extra">Thanks.</div><div class="gmail_extra"><br></div><div class="gmail_extra">I am rebuilding all my tools so am not in a position to start a test of this</div><div class="gmail_extra">until in the morning. </div><div class="gmail_extra"><br></div><div class="gmail_extra">I am not saying your patch is wrong. But speaking from experience, the </div><div class="gmail_extra">answer to portable warning free printf() formats is often inttypes.h. Especially</div><div class="gmail_extra">if some have system types or are like uintXX_t.</div><div class="gmail_extra"><br></div><div class="gmail_extra"><a href="http://pubs.opengroup.org/onlinepubs/009695399/basedefs/inttypes.h.html">http://pubs.opengroup.org/onlinepubs/009695399/basedefs/inttypes.h.html</a><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">This is a fairly unknown feature of C99. A pretty good discussion is here:</div><div class="gmail_extra"><br></div><div class="gmail_extra"><a href="http://stackoverflow.com/questions/6299323/good-introduction-to-inttypes-h">http://stackoverflow.com/questions/6299323/good-introduction-to-inttypes-h</a><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">If you use the right PRI constant and it doesn't clear up warnings on</div><div class="gmail_extra">all architectures, it is a bug in the toolset.</div><div class="gmail_extra"><br></div><div class="gmail_extra">--joel</div><div class="gmail_extra"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 6, 2017 at 4:10 PM, Cillian O'Donnell <span dir="ltr"><<a href="mailto:cpodonnell8@gmail.com" target="_blank">cpodonnell8@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">2 of the warnings cropped up on further testing of other BSPs. Sorry, should of been more careful.<br>
Also git send-email format.<br>
---<br>
cpukit/libdl/rtl-obj-cache.c | 18 +++++++++---------<br>
1 file changed, 9 insertions(+), 9 deletions(-)<br>
<br>
diff --git a/cpukit/libdl/rtl-obj-cache.c b/cpukit/libdl/rtl-obj-cache.c<br>
index a4676cf..d3cd953 100644<br>
--- a/cpukit/libdl/rtl-obj-cache.c<br>
+++ b/cpukit/libdl/rtl-obj-cache.c<br>
@@ -78,11 +78,11 @@ rtems_rtl_obj_cache_read (rtems_rtl_obj_cache_t* cache,<br>
struct stat sb;<br>
<br>
if (rtems_rtl_trace (RTEMS_RTL_TRACE_CACHE))<br>
- printf ("rtl: cache: %2d: fd=%d offset=%d length=%d area=[%d,%d] cache=[%d,%d] size=%d\n",<br>
- fd, cache->fd, (int) offset, (int) *length,<br>
- (int) offset, (int) offset + *length,<br>
- (int) cache->offset, (int) cache->offset + cache->level,<br>
- (int) cache->file_size);<br>
+ printf ("rtl: cache: %2d: fd=%d offset=%llu length=%d area=[%d,%llu] cache=[%llu,%llu] size=%lu\n",<br>
+ fd, cache->fd, offset, (int) *length,<br>
+ (int) offset, offset + *length,<br>
+ cache->offset, cache->offset + cache->level,<br>
+ (unsigned long) cache->file_size);<br>
<br>
if (*length > cache->size)<br>
{<br>
@@ -172,10 +172,10 @@ rtems_rtl_obj_cache_read (rtems_rtl_obj_cache_t* cache,<br>
}<br>
<br>
if (rtems_rtl_trace (RTEMS_RTL_TRACE_CACHE))<br>
- printf ("rtl: cache: %2d: seek: offset=%d buffer_offset=%d read=%d cache=[%d,%d] dist=%d\n",<br>
- fd, (int) offset + buffer_offset, (int) buffer_offset, (int) buffer_read,<br>
- (int) offset, (int) offset + buffer_read,<br>
- (int) (cache->file_size - offset));<br>
+ printf ("rtl: cache: %2d: seek: offset=%llu buffer_offset=%lu read=%d cache=[%d,%llu] dist=%llu\n",<br>
+ fd, offset + buffer_offset, (unsigned long) buffer_offset, (int) buffer_read,<br>
+ (int) offset, offset + buffer_read,<br>
+ (cache->file_size - offset));<br>
<br>
if (lseek (fd, offset + buffer_offset, SEEK_SET) < 0)<br>
{<br>
<span class="gmail-HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/<wbr>mailman/listinfo/devel</a><br>
</font></span></blockquote></div><br></div></div>