<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 7:21 PM, Gedare Bloom <span dir="ltr"><<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, Apr 24, 2017 at 6:21 PM, Joel Sherrill <<a href="mailto:joel@rtems.org">joel@rtems.org</a>> wrote:<br>
> Module:    rtems<br>
> Branch:    master<br>
> Commit:    fd48b43007b001a6f31949952504c9<wbr>b55d895c4f<br>
> Changeset: <a href="http://git.rtems.org/rtems/commit/?id=fd48b43007b001a6f31949952504c9b55d895c4f" rel="noreferrer" target="_blank">http://git.rtems.org/rtems/<wbr>commit/?id=<wbr>fd48b43007b001a6f31949952504c9<wbr>b55d895c4f</a><br>
><br>
> Author:    Joel Sherrill <<a href="mailto:joel@rtems.org">joel@rtems.org</a>><br>
> Date:      Mon Apr 24 11:15:53 2017 -0500<br>
><br>
> virtex5/startup/dummy_console.<wbr>c: Fix no prototype warning<br>
><br>
> ---<br>
><br>
>  c/src/lib/libbsp/powerpc/<wbr>virtex5/startup/dummy_console.<wbr>c | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/c/src/lib/libbsp/powerpc/<wbr>virtex5/startup/dummy_console.<wbr>c b/c/src/lib/libbsp/powerpc/<wbr>virtex5/startup/dummy_console.<wbr>c<br>
> index 048133d..e62a9f0 100644<br>
> --- a/c/src/lib/libbsp/powerpc/<wbr>virtex5/startup/dummy_console.<wbr>c<br>
> +++ b/c/src/lib/libbsp/powerpc/<wbr>virtex5/startup/dummy_console.<wbr>c<br>
> @@ -26,6 +26,7 @@ rtems_device_driver console_control(rtems_device_<wbr>major_number major,<br>
>                                      rtems_device_minor_number minor,<br>
>                                      void*                     arg);<br>
><br>
> +void BSP_output_char(char ch);<br>
><br>
Can we avoid declaring non-static functions in .c files? I would<br>
either see this in a header file, or see it declared as a static<br>
function.<br></blockquote><div><br></div><div>It can't be static because it is in another file and used by both.</div><div><br></div><div>I suppose a bspimpl.h could be added if folks desire. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
>  ssize_t __bsp_memory_write(int minor, const char* buf, size_t len)<br>
>  {<br>
><br>
> ______________________________<wbr>_________________<br>
> vc mailing list<br>
> <a href="mailto:vc@rtems.org">vc@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/vc" rel="noreferrer" target="_blank">http://lists.rtems.org/<wbr>mailman/listinfo/vc</a><br>
______________________________<wbr>_________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/<wbr>mailman/listinfo/devel</a><br>
</blockquote></div><br></div></div>