<div dir="ltr">A close personal friend of mine pushed the patch. :)<div><br></div><div>--joel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 15, 2017 at 2:57 PM, Gedare Bloom <span dir="ltr"><<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Someone can push this.<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Jun 15, 2017 at 7:35 AM, Sichen Zhao <<a href="mailto:1473996754@qq.com">1473996754@qq.com</a>> wrote:<br>
> ---<br>
> c/src/lib/libbsp/arm/beagle/<wbr>i2c/bbb-i2c.c | 42 +++++++++++++++++-------------<wbr>-<br>
> 1 file changed, 23 insertions(+), 19 deletions(-)<br>
><br>
> diff --git a/c/src/lib/libbsp/arm/beagle/<wbr>i2c/bbb-i2c.c b/c/src/lib/libbsp/arm/beagle/<wbr>i2c/bbb-i2c.c<br>
> index 3d7d820..26bae52 100644<br>
> --- a/c/src/lib/libbsp/arm/beagle/<wbr>i2c/bbb-i2c.c<br>
> +++ b/c/src/lib/libbsp/arm/beagle/<wbr>i2c/bbb-i2c.c<br>
> @@ -7,6 +7,7 @@<br>
> */<br>
><br>
> /*<br>
> + * Copyright (c) 2016 Punit Vara <<a href="mailto:punitvara@gmail.com">punitvara@gmail.com</a>><br>
> * Copyright (c) 2017 Sichen Zhao <<a href="mailto:zsc19940506@gmail.com">zsc19940506@gmail.com</a>><br>
> *<br>
> * The license and distribution terms for this file may be<br>
> @@ -48,27 +49,26 @@ static void I2C0ModuleClkConfig( void )<br>
> AM335X_CM_WKUP_I2C0_CLKCTRL_<wbr>MODULEMODE ) ) ;<br>
><br>
> /*<br>
> - ** Waiting for IDLEST field in AM335X_CM_WKUP_CONTROL_CLKCTRL<br>
> - ** register to attain<br>
> - ** desired value.<br>
> - */<br>
> + * Waiting for IDLEST field in AM335X_CM_WKUP_CONTROL_CLKCTRL<br>
> + * register to attain desired value.<br>
> + */<br>
> while ( ( AM335X_CM_WKUP_CONTROL_<wbr>CLKCTRL_IDLEST_FUNC <<<br>
> AM335X_CM_WKUP_CONTROL_<wbr>CLKCTRL_IDLEST_SHIFT ) !=<br>
> ( REG( AM335X_SOC_CM_WKUP_REGS + AM335X_CM_WKUP_CONTROL_CLKCTRL ) &<br>
> AM335X_CM_WKUP_CONTROL_<wbr>CLKCTRL_IDLEST ) ) ;<br>
><br>
> /*<br>
> - ** Waiting for CLKACTIVITY_I2C0_GFCLK field in AM335X_CM_WKUP_CLKSTCTRL<br>
> - ** register to attain desired value.<br>
> - */<br>
> + * Waiting for CLKACTIVITY_I2C0_GFCLK field in AM335X_CM_WKUP_CLKSTCTRL<br>
> + * register to attain desired value.<br>
> + */<br>
> while ( AM335X_CM_WKUP_CLKSTCTRL_<wbr>CLKACTIVITY_I2C0_GFCLK !=<br>
> ( REG( AM335X_SOC_CM_WKUP_REGS + AM335X_CM_WKUP_CLKSTCTRL ) &<br>
> AM335X_CM_WKUP_CLKSTCTRL_<wbr>CLKACTIVITY_I2C0_GFCLK ) ) ;<br>
><br>
> /*<br>
> - ** Waiting for IDLEST field in AM335X_CM_WKUP_I2C0_CLKCTRL register to attain<br>
> - ** desired value.<br>
> - */<br>
> + * Waiting for IDLEST field in AM335X_CM_WKUP_I2C0_CLKCTRL register to attain<br>
> + * desired value.<br>
> + */<br>
> while ( ( AM335X_CM_WKUP_I2C0_CLKCTRL_<wbr>IDLEST_FUNC <<<br>
> AM335X_CM_WKUP_I2C0_CLKCTRL_<wbr>IDLEST_SHIFT ) !=<br>
> ( REG( AM335X_SOC_CM_WKUP_REGS + AM335X_CM_WKUP_I2C0_CLKCTRL ) &<br>
> @@ -100,7 +100,7 @@ static void am335x_i2c_reset( bbb_i2c_bus *bus )<br>
> }<br>
> }<br>
> /*<br>
> - Possible values for msg->flag<br>
> + * Possible values for msg->flag<br>
> * - @ref I2C_M_TEN,<br>
> * - @ref I2C_M_RD,<br>
> * - @ref I2C_M_STOP,<br>
> @@ -116,13 +116,15 @@ static void am335x_i2c_set_address_size(<br>
> volatile bbb_i2c_regs *regs<br>
> )<br>
> {<br>
> - /*can be configured multiple modes here.<br>
> - **Need to think about own address modes*/<br>
> + /*<br>
> + * Can be configured multiple modes here.<br>
> + * Need to think about own address modes<br>
> + */<br>
> if ( ( msgs->flags & I2C_M_TEN ) == 0 ) {<br>
> - /* 7-bit mode slave address mode*/<br>
> + /* 7-bit mode slave address mode */<br>
> REG( ®s->BBB_I2C_CON ) = AM335X_I2C_CFG_7BIT_SLAVE_<wbr>ADDR;<br>
> } else {<br>
> - /* 10-bit slave address mode*/<br>
> + /* 10-bit slave address mode */<br>
> REG( ®s->BBB_I2C_CON ) = AM335X_I2C_CFG_10BIT_SLAVE_<wbr>ADDR;<br>
> }<br>
> }<br>
> @@ -282,12 +284,14 @@ static void am335x_i2c_interrupt( void *arg )<br>
> {<br>
> bbb_i2c_bus *bus = arg;<br>
> volatile bbb_i2c_regs *regs = bus->regs;<br>
> - /* get status of enabled interrupts */<br>
> + /* Get status of enabled interrupts */<br>
> uint32_t irqstatus = REG( ®s->BBB_I2C_IRQSTATUS );<br>
> bool done = false;<br>
><br>
> - /* Clear all enabled interrupt except receive ready<br>
> - and transmit ready interrupt in status register */<br>
> + /*<br>
> + * Clear all enabled interrupt except receive ready<br>
> + * and transmit ready interrupt in status register<br>
> + */<br>
> REG( ®s->BBB_I2C_IRQSTATUS ) =<br>
> ( irqstatus & ~( AM335X_I2C_IRQSTATUS_RRDY |<br>
> AM335X_I2C_IRQSTATUS_XRDY ) );<br>
> @@ -417,7 +421,7 @@ int am335x_i2c_bus_register(<br>
> rtems_status_code sc;<br>
> int err;<br>
><br>
> - /*check bus number is >0 & <MAX*/<br>
> + /* Check bus number is >0 & <MAX */<br>
> bus = (bbb_i2c_bus *) i2c_bus_alloc_and_init( sizeof( *bus ) );<br>
><br>
> if ( bus == NULL ) {<br>
> --<br>
> 2.7.4<br>
><br>
><br>
><br>
______________________________<wbr>_________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/<wbr>mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div>