<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 8, 2018 at 9:10 AM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 08/02/18 16:08, Joel Sherrill wrote:<span class="gmail-"><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
On Thu, Feb 8, 2018 at 3:05 AM, Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brai<wbr>ns.de</a> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a>>> wrote:<br>
<br>
On 08/02/18 09:11, Sebastian Huber wrote:<br>
<br>
On 08/02/18 01:00, Joel Sherrill wrote:<br>
<br>
Hi<br>
<br>
The patch was quite large and rightly blocked from being<br>
sent to<br>
everyone (~900k). Compressed, it is only 63K<br>
<br>
This eliminates the custom directory and moves everything up<br>
one level. No failures in the build as shown here.<br>
<br>
<a href="https://lists.rtems.org/pipermail/build/2018-February/000398.html" rel="noreferrer" target="_blank">https://lists.rtems.org/piperm<wbr>ail/build/2018-February/000398<wbr>.html</a><br>
<<a href="https://lists.rtems.org/pipermail/build/2018-February/000398.html" rel="noreferrer" target="_blank">https://lists.rtems.org/piper<wbr>mail/build/2018-February/00039<wbr>8.html</a>><br>
<br>
<br>
If we move this stuff, then why not to<br>
<br>
bsps/@RTEMS_CPU/@RTEMS_BSP_FAM<wbr>ILY@/make<br>
<br>
<br>
OK. I can pick at that but what does from testsuites this change to?<br>
<br>
include $(RTEMS_ROOT)/make/custom/@RTE<wbr>MS_BSP@.cfg<br>
<br>
Will RTEMS_ROOT need to change to something like $(top_srcdir)/...?<br>
<br>
Is there a Makefile.am variable that really points to the top of the source tree?<br>
<br>
The other common pattern is<br>
<br>
include $(RTEMS_ROOT)/make/custom/defa<wbr>ult.cfg<br>
<br>
in all the BSP .cfg files? What will that need to be to work before and<br>
after install?<br>
<br>
RTEMS_ROOT is the build tree and later the install point. I don't<br>
know how to make that one work.<br>
<br>
Any thoughts?<br>
</blockquote>
<br></span>
No user should be forced to touch its Makefiles only because we move some files in the RTEMS source tree from A to B. So, I think the install location should remain as is.</blockquote><div><br></div><div>I agree but I think you missed my point. The use in testsuites can be fixed to point</div><div>to the source tree. But if I change the includes in the "custom" files, I have concerns</div><div>that it may not be possible to make it work in both when building and installed. </div><div><br></div><div><div>./c/src/lib/libbsp/arm/altera-cyclone-v/make/custom/altcycv_devkit.cfg:include $(RTEMS_ROOT)/make/custom/altcycv.inc</div><div>./c/src/lib/libbsp/arm/altera-cyclone-v/make/custom/altcycv_devkit_smp.cfg:include $(RTEMS_ROOT)/make/custom/altcycv.inc</div><div>./c/src/lib/libbsp/arm/altera-cyclone-v/make/custom/altcycv.inc:include $(RTEMS_ROOT)/make/custom/default.cfg</div></div><div><br></div><div>I just grep'ed for RTEMS_ROOT and it appears that I need to change the definition</div><div>of where it points. It is mostly used to point to the custom files but this looks </div><div>problematic:</div><div><br></div><div><div><div>/c/src/Makefile.am: 'RTEMS_BSP=@RTEMS_BSP@' 'RTEMS_ROOT=.' \</div><div>./c/src/configure.ac:RTEMS_ROOT=. make/${RTEMS_BSP}.cache</div></div></div><div><br></div><div>All the references in testsuites can be to top_srcdir. Easy to eliminate RTEMS_ROOT</div><div>completely I think in there. But what should RTEMS_ROOT be set to in</div><div>c/src/<a href="http://configure.ac">configure.ac</a> to make it work? What variable has the top of the source tree?</div><div><br></div><div>I guess $(top_srcdir)/../..?</div><div><br></div><div>Thoughts?</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : <a href="tel:%2B49%2089%20189%2047%2041-16" value="+4989189474116" target="_blank">+49 89 189 47 41-16</a><br>
Fax : <a href="tel:%2B49%2089%20189%2047%2041-09" value="+4989189474109" target="_blank">+49 89 189 47 41-09</a><br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brain<wbr>s.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
</div></div></blockquote></div><br></div></div>