<div dir="ltr">Cheers! Thanks for taking the time to test them!</div><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Mar 16, 2018 at 10:06 PM Joel Sherrill <<a href="mailto:joel@rtems.org">joel@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks.<div><br></div><div>I just pushed these. </div><div><br></div><div>I compiled all PC386 BSP family members with and without multiprocessing.</div><div><br></div><div>--joel</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 13, 2018 at 11:14 AM, Amaan Cheval <span dir="ltr"><<a href="mailto:amaan.cheval@gmail.com" target="_blank">amaan.cheval@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">When it's a macro, a function declaration causes a compiler error due to the<br>
macro being expanded.<br>
<br>
Partial log showing error:<br>
<a href="https://gist.github.com/AmaanC/ab3521141479aa6f61ea25f5d74ebb4d" rel="noreferrer" target="_blank">https://gist.github.com/AmaanC/ab3521141479aa6f61ea25f5d74ebb4d</a><br>
<br>
Closes #3331<br>
---<br>
 c/src/lib/libbsp/i386/shared/smp/smp-imps.c     | 5 +++++<br>
 cpukit/score/cpu/i386/include/rtems/score/cpu.h | 3 +--<br>
 2 files changed, 6 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/c/src/lib/libbsp/i386/shared/smp/smp-imps.c b/c/src/lib/libbsp/i386/shared/smp/smp-imps.c<br>
index 1ed504ccf9..2ba36804cb 100644<br>
--- a/c/src/lib/libbsp/i386/shared/smp/smp-imps.c<br>
+++ b/c/src/lib/libbsp/i386/shared/smp/smp-imps.c<br>
@@ -804,6 +804,11 @@ uint32_t _CPU_SMP_Initialize( void )<br>
   return (uint32_t) imps_probe();<br>
 }<br>
<br>
+void _CPU_SMP_Prepare_start_multitasking( void )<br>
+{<br>
+  /* Do nothing */<br>
+}<br>
+<br>
 bool _CPU_SMP_Start_processor( uint32_t cpu_index )<br>
 {<br>
   (void) cpu_index;<br>
diff --git a/cpukit/score/cpu/i386/include/rtems/score/cpu.h b/cpukit/score/cpu/i386/include/rtems/score/cpu.h<br>
index 364bba765a..d8f89f6397 100644<br>
--- a/cpukit/score/cpu/i386/include/rtems/score/cpu.h<br>
+++ b/cpukit/score/cpu/i386/include/rtems/score/cpu.h<br>
@@ -470,8 +470,7 @@ void _CPU_Context_Initialize(<br>
<br>
   void _CPU_SMP_Finalize_initialization( uint32_t cpu_count );<br>
<br>
-  /* Nothing to do */<br>
-  #define _CPU_SMP_Prepare_start_multitasking() do { } while ( 0 )<br>
+  void _CPU_SMP_Prepare_start_multitasking( void );<br>
<br>
   uint32_t _CPU_SMP_Get_current_processor( void );<br>
<span class="m_-4692350711036026545HOEnZb"><font color="#888888"><br>
--<br>
2.13.0<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</font></span></blockquote></div><br></div>
</blockquote></div>