<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, 7 May 2018, 23:26 Joel Sherrill, <<a href="mailto:joel@rtems.org" target="_blank" rel="noreferrer">joel@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi<div><br></div><div>I have attached a workaround. It seems that libgen.h has this:</div><div><br></div><div>
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">========================================================</span>
<br></div><div><div>/* Return final component of PATH.</div><div><br></div><div> This is the weird XPG version of this function. It sometimes will</div><div> modify its argument. Therefore we normally use the GNU version (in</div><div> <string.h>) and only if this header is included make the XPG</div><div> version available under the real name. */</div><div>extern char *__xpg_basename (char *__path) __THROW;</div><div>#define basename __xpg_basename</div></div><div>========================================================</div><div><br></div><div>Chris has used basename as a method name and even though that should</div><div>be perfectly acceptable, the macro above gets expanded, the name </div><div>gets changed (in some places) to rld::path::__xpg_basename()</div><div><br></div><div><div> r.lowSourceLine = rld::path::basename (location);</div></div><div><br></div><div>IMO the fix is to add dirname to rld-files, use rld basename and dirname</div><div>exclusively, and avoid libgen.h at all costs.</div><div><br></div><div>I didn't do that much work. I got lucky in a couple of files by removing the</div><div>include of libgen.h since it wasn't needed but I had to leave it in one place.</div><div><br></div><div><div>$ grep dirname *.cc</div><div>GcovData.cc: dirname( path );</div></div><div><br></div><div>Hopefully this lets you all proceed with Chris' patches and my slight hack</div><div>in place.</div><div><br></div><div>Ultimate solution is probably simple. We just need to hear from Chris.</div><div><br></div><div>--joel</div></div></blockquote></div></div><div dir="auto">This will hopefully fix it, unfortunately I can't test it now, as I'm on mobile. Hopefully Cillian can try building with the diff applied.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 7, 2018 at 12:42 PM, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" rel="noreferrer noreferrer" target="_blank">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, May 7, 2018 at 12:36 PM, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><span><div><br><div class="gmail_quote"><div dir="ltr">On Mon, 7 May 2018, 22:57 Cillian O'Donnell, <<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yeah I'm seeing the same as Joel, at least were further then we were :).<br><br>I've been mostly working on the rtems-tester support, so just to give an update. I spent all day Saturday and today on it. It's taking longer than expected, re-orienting myself and deciding what is needed and not needed now with the changes in covoar. The problems are not difficult, it's just taking some time re-organizing everything. My time is limited during the week, so it'll probably be next weekend before I can finish it off. Vijay if you have time during the week I could push what I have and you could take a stab at some of them and then I could it finish off next weekend if you haven't already.<br></div></blockquote></div></div></span><div dir="auto">please send them, I can look into them for sure.</div></div></blockquote><div><br></div></span><div>Keep plugging away.</div><div><br></div><div>I think there is something wrong in rld related to basename. My first thought was that the undefined symbol was because we didn't include the library. Now I think it is because something got misconfigured on Centos/Fedora/etc. Looking into this.</div><div><div class="m_2321582609429445419m_1707397245890879746h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto"><div><div class="m_2321582609429445419m_1707397245890879746m_323651706870341625h5"><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"></div><div class="gmail_extra"><br><div class="gmail_quote">On 7 May 2018 at 15:40, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Mon, May 7, 2018 at 6:01 AM, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I have added the path to libdwarf here </div></blockquote><div><br></div></span><div>That worked for me to build but not to link.</div><div><br></div><div>I'm not sure why this rld symbol turned up missing on Centos 7.</div><div><br></div><div>====================================================</div><div><br></div><div><div>$ ./waf -v</div><div>Waf: Entering directory `/home/joel/rtems-work/rtems-tools/build'</div><div>[228/229] Linking build/tester/covoar/trace-converter</div><div>09:38:25 runner ['/usr/bin/g++', 'tester/covoar/TraceConverter.cc.2.o', 'tester/covoar/TraceList.cc.2.o', 'tester/covoar/TraceReaderBase.cc.2.o', 'tester/covoar/TraceReaderLogQEMU.cc.2.o', 'tester/covoar/TraceWriterBase.cc.2.o', 'tester/covoar/TraceWriterQEMU.cc.2.o', '-o/home/joel/rtems-work/rtems-tools/build/tester/covoar/trace-converter', '-Wl,-Bstatic', '-Ltester/covoar', '-Lrtemstoolkit', '-lccovoar', '-lrld', '-ldwarf', '-lelf', '-liberty', '-Wl,-Bdynamic']</div><div>[229/229] Linking build/tester/covoar/covoar</div><div>09:38:25 runner ['/usr/bin/g++', 'tester/covoar/covoar.cc.3.o', '-o/home/joel/rtems-work/rtems-tools/build/tester/covoar/covoar', '-Wl,-Bstatic', '-Ltester/covoar', '-Lrtemstoolkit', '-lccovoar', '-lrld', '-ldwarf', '-lelf', '-liberty', '-Wl,-Bdynamic']</div><span><div>tester/covoar/libccovoar.a(DesiredSymbols.cc.1.o): In function `Coverage::DesiredSymbols::determineSourceLines(Coverage::CoverageRanges*, Coverage::ExecutableInfo*)':</div></span><div>/home/joel/rtems-work/rtems-tools/build/../tester/covoar/DesiredSymbols.cc:413: undefined reference to `rld::path::__xpg_basename(std::string const&)'</div><div>/home/joel/rtems-work/rtems-tools/build/../tester/covoar/DesiredSymbols.cc:415: undefined reference to `rld::path::__xpg_basename(std::string const&)'</div><span><div>collect2: error: ld returned 1 exit status</div><div><br></div></span><span><div>tester/covoar/libccovoar.a(DesiredSymbols.cc.1.o): In function `Coverage::DesiredSymbols::determineSourceLines(Coverage::CoverageRanges*, Coverage::ExecutableInfo*)':</div></span><div>/home/joel/rtems-work/rtems-tools/build/../tester/covoar/DesiredSymbols.cc:413: undefined reference to `rld::path::__xpg_basename(std::string const&)'</div><div>/home/joel/rtems-work/rtems-tools/build/../tester/covoar/DesiredSymbols.cc:415: undefined reference to `rld::path::__xpg_basename(std::string const&)'</div><span><div>collect2: error: ld returned 1 exit status</div><div><br></div></span><div>Waf: Leaving directory `/home/joel/rtems-work/rtems-tools/build'</div><span><div>Build failed</div><div> -> task in 'trace-converter' failed with exit status 1: </div></span><div> {task 34721616: cxxprogram TraceConverter.cc.2.o,TraceList.cc.2.o,TraceReaderBase.cc.2.o,TraceReaderLogQEMU.cc.2.o,TraceWriterBase.cc.2.o,TraceWriterQEMU.cc.2.o -> trace-converter}</div><div>['/usr/bin/g++', 'tester/covoar/TraceConverter.cc.2.o', 'tester/covoar/TraceList.cc.2.o', 'tester/covoar/TraceReaderBase.cc.2.o', 'tester/covoar/TraceReaderLogQEMU.cc.2.o', 'tester/covoar/TraceWriterBase.cc.2.o', 'tester/covoar/TraceWriterQEMU.cc.2.o', '-o/home/joel/rtems-work/rtems-tools/build/tester/covoar/trace-converter', '-Wl,-Bstatic', '-Ltester/covoar', '-Lrtemstoolkit', '-lccovoar', '-lrld', '-ldwarf', '-lelf', '-liberty', '-Wl,-Bdynamic']</div><span><div> -> task in 'covoar' failed with exit status 1: </div></span><div> {task 34820256: cxxprogram covoar.cc.3.o -> covoar}</div><div>['/usr/bin/g++', 'tester/covoar/covoar.cc.3.o', '-o/home/joel/rtems-work/rtems-tools/build/tester/covoar/covoar', '-Wl,-Bstatic', '-Ltester/covoar', '-Lrtemstoolkit', '-lccovoar', '-lrld', '-ldwarf', '-lelf', '-liberty', '-Wl,-Bdynamic']</div></div><div>====================================================</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732h5"><div dir="ltr"><div><br></div><div>---</div><div><pre style="color:rgb(0,0,0);font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial;word-wrap:break-word;white-space:pre-wrap">diff --git a/tester/covoar/wscript b/tester/covoar/wscript
index 55d5ec9..dd4ad83 100644
--- a/tester/covoar/wscript
+++ b/tester/covoar/wscript
@@ -63,6 +63,7 @@ def build(bld):
rtl_includes = [rtemstoolkit,
rtemstoolkit + '/elftoolchain/libelf',
rtemstoolkit + '/elftoolchain/common',
+ rtemstoolkit + '/elftoolchain/libdwarf',
rtemstoolkit + '/libiberty']
if bld.env.DEST_OS == 'win32':
rtl_includes += [rtemstoolkit + '/win32']</pre><span class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-HOEnZb"><font color="#888888"><br></font></span></div></div><div class="gmail_extra"><span class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-HOEnZb"><font color="#888888"><br clear="all"><div><div class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-m_9093139070613751218gmail_signature"><div dir="ltr"><div><div dir="ltr">-- vijay</div></div></div></div></div></font></span><div><div class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-h5">
<br><div class="gmail_quote">On 7 May 2018 at 13:30, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><span>On 6 May 2018 at 13:29, Chris Johns <span dir="ltr"><<a href="mailto:chrisj@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">chrisj@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/5/18 5:28 pm, Vijay Kumar Banerjee wrote:<span><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
On 6 May 2018 at 08:54, Chris Johns <<a href="mailto:chrisj@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">chrisj@rtems.org</a> <mailto:<a href="mailto:chrisj@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">chrisj@rtems.org</a>>> wrote:<br>
<br>
Would you please try `waf clean build` to see if rebuilding<br>
everything fixes this?<br>
<br>
still getting the same error .<br>
I'm using g++ 7.3.1 on fedora 27.<br>
</blockquote>
<br></span>
OK<span><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If you have changed something in the code, can you please send a patch for the same ?<br>
</blockquote>
<br></span>
I have not changed anything. I do not have a Linux box to try.<span class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-m_9093139070613751218m_3581814237704045480HOEnZb"><font color="#888888"><br>
<br></font></span></blockquote></span><div>I tried to do it afresh as well, it's still failing to build.</div><div>Can someone please try to build it in a linux system ? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_2321582609429445419m_1707397245890879746m_323651706870341625m_3354552205201062185m_-5109157323605541732m_-3988439629750368059gmail-m_9093139070613751218m_3581814237704045480HOEnZb"><font color="#888888">
Chris<br>
</font></span></blockquote></div><br></div></div>
</blockquote></div><br></div></div></div>
<br></div></div><span>_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br></span></blockquote></div><br></div></div>
<br>_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" rel="noreferrer noreferrer noreferrer" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br></blockquote></div><br></div>
</blockquote></div></div></div></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>
</blockquote></div></div></div>