<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, May 12, 2018 at 2:42 PM, thelunatic <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br></blockquote><div><br></div><div>Every patch needs an explanation/log message.  Look back through </div><div>"git log" for examples.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 tester/covoar/covoar.cc | 7 ++++---<br>
 1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/tester/covoar/covoar.cc b/tester/covoar/covoar.cc<br>
index 5bed98f..95dc990 100644<br>
--- a/tester/covoar/covoar.cc<br>
+++ b/tester/covoar/covoar.cc<br>
@@ -185,7 +185,7 @@ int main(<br>
   Executables                   executablesToAnalyze;<br>
   Coverage::ExecutableInfo*     executableInfo = NULL;<br>
   std::string                   executableExtension = "exe";<br>
-  std::string                   coverageExtension = "cov";<br>
+  std::string                   coverageExtension = ".cov";<br></blockquote><div><br></div><div>Why did this need a "." but the "exe" one didn't? </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   Coverage::CoverageFormats_t   coverageFormat = Coverage::COVERAGE_FORMAT_<wbr>QEMU;<br>
   Coverage::CoverageReaderBase* coverageReader = NULL;<br>
   char*                         executable = NULL;<br>
@@ -317,11 +317,12 @@ int main(<br>
         std::cerr << "warning: Unable to read executable: " << argv[i] << std::endl;<br>
       } else {<br>
         coverageFileName = argv[i];<br>
-        coverageFileName.replace(<br>
+       coverageFileName.append(<wbr>coverageExtension);<br>
+     /* coverageFileName.replace(<br>
           coverageFileName.length() - executableExtension.size(),<br>
           executableExtension.size(),<br>
           coverageExtension<br>
-        );<br>
+        ); */<br></blockquote><div><br></div><div> </div><div>If you are replacing this call, then just delete it -- don't comment it out.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
         if (!FileIsReadable( coverageFileName.c_str() )) {<br>
           std::cerr << "warning: Unable to read coverage file: " << coverageFileName<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div></div>