<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 18, 2018 at 8:44 AM, Sebastian Huber <span dir="ltr"><<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 18/05/18 15:42, Joel Sherrill wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
<br>
On Fri, May 18, 2018 at 8:25 AM, Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brai<wbr>ns.de</a> <mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a>>> wrote:<br>
<br>
On 18/05/18 15:21, Joel Sherrill wrote:<br>
<br>
<br>
<br>
On Fri, May 18, 2018 at 12:41 AM, Sebastian Huber<br>
<<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brai<wbr>ns.de</a><br>
<mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a>><br></span>
<mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a><div><div class="gmail-h5"><br>
<mailto:<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedd<wbr>ed-brains.de</a>>>> wrote:<br>
<br>
On 16/05/18 17:09, Joel Sherrill wrote:<br>
<br>
Updates #3425.<br>
---<br>
bsps/powerpc/beatnik/config/be<wbr>atnik.cfg | 2 +-<br>
c/src/lib/libbsp/powerpc/beatn<wbr>ik/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>> | 2 ++<br>
2 files changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/bsps/powerpc/beatnik/config/<wbr>beatnik.cfg<br>
b/bsps/powerpc/beatnik/config/<wbr>beatnik.cfg<br>
index 1190cad..05bea38 100644<br>
--- a/bsps/powerpc/beatnik/config/<wbr>beatnik.cfg<br>
+++ b/bsps/powerpc/beatnik/config/<wbr>beatnik.cfg<br>
@@ -14,7 +14,7 @@ RTEMS_BSP_FAMILY=beatnik<br>
# This contains the compiler options necessary to<br>
select<br>
the CPU model<br>
# and (hopefully) optimize for it.<br>
#<br>
-CPU_CFLAGS = -mcpu=7400 -D__ppc_generic<br>
+CPU_CFLAGS = -mcpu=7400<br>
#T. Straumann; disable sdata=eabi for now until CEXP<br>
supports it -meabi -msdata=eabi<br>
# optimize flag: typically -0, could use -O4 or -fast<br>
diff --git<br>
a/c/src/lib/libbsp/powerpc/bea<wbr>tnik/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
b/c/src/lib/libbsp/powerpc/bea<wbr>tnik/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
index a48007c..b332aaa 100644<br>
--- a/c/src/lib/libbsp/powerpc/bea<wbr>tnik/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
+++ b/c/src/lib/libbsp/powerpc/bea<wbr>tnik/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
<<a href="http://configure.ac" rel="noreferrer" target="_blank">http://configure.ac</a>><br>
@@ -34,6 +34,8 @@ Note that the policy can still be<br>
defined by<br>
the application<br>
CONFIGURE_MALLOC_BSP_SUPPORTS_<wbr>SBRK this feature is<br>
removed<br>
and a little memory is saved.])<br>
+AC_DEFINE(__ppc_generic, 1, [PowerPC model option])<br>
+<br>
# Explicitly list all Makefiles here<br>
AC_CONFIG_FILES([Makefile])<br>
<br>
<br>
I would rather eliminate the only user of __ppc_generic in<br>
bsps/powerpc/include/rtems/pow<wbr>erpc/powerpc.h.<br>
<br>
<br>
I have file another ticket #3431 to address this and assigned<br>
it to you.<br>
<br>
I am committing my changes because they eliminate use of -D on<br>
the GCC command line<br>
and allow packages using rtems_waf to compile.<br>
<br>
<br>
Did you check that every consumer of these defines includes<br>
<bspopts.h> somehow?<br>
<br>
<br>
powerpc.h fails to compile if it isn't provided.<br>
</div></div></blockquote>
<br>
Are these defines only used in powerpc.h?</blockquote><div><br></div><div>$ grep -lr __ppc_generic .</div><div>./c/src/lib/libbsp/powerpc/beatnik/<a href="http://configure.ac">configure.ac</a></div><div>./c/src/lib/libbsp/powerpc/motorola_powerpc/<a href="http://configure.ac">configure.ac</a></div><div>./c/src/lib/libbsp/powerpc/mpc55xxevb/<a href="http://configure.ac">configure.ac</a></div><div>./c/src/lib/libbsp/powerpc/mvme3100/<a href="http://configure.ac">configure.ac</a></div><div>./c/src/lib/libbsp/powerpc/qoriq/<a href="http://configure.ac">configure.ac</a></div><div>./c/src/lib/libbsp/powerpc/t32mppc/<a href="http://configure.ac">configure.ac</a></div><div>./bsps/powerpc/include/rtems/powerpc/powerpc.h</div><div><br></div><div>I didn't check the others. If it broke something because </div><div>someone wasn't writing defensive enough ifdef's, then</div><div>that code should be fixed to be more defensive.</div><div><br></div><div>powerpc.h had a default to #error</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5"><br>
<br>
-- <br>
Sebastian Huber, embedded brains GmbH<br>
<br>
Address : Dornierstr. 4, D-82178 Puchheim, Germany<br>
Phone : +49 89 189 47 41-16<br>
Fax : +49 89 189 47 41-09<br>
E-Mail : <a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brain<wbr>s.de</a><br>
PGP : Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
<br>
</div></div></blockquote></div><br></div></div>