<div dir="ltr"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, May 21, 2018, 12:01 PM Vijay Kumar Banerjee <<a href="mailto:vijaykumar9597@gmail.com" target="_blank">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 May 2018 at 21:42, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" rel="noreferrer" target="_blank">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_2470574478394775560m_2772094073915690197gmail-">On Mon, May 21, 2018 at 10:13 AM, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-">On 21 May 2018 at 20:37, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" rel="noreferrer" target="_blank">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-">On Mon, May 21, 2018 at 9:52 AM, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 May 2018 at 17:39, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" rel="noreferrer" target="_blank">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto">CPU-rtems5-objdump<div dir="auto"><br></div></div></blockquote><div>sparc-rtems5-objdump worked , thanks .</div><div>I can see some mismatches in the disassembly .</div></div></div></div></blockquote><div><br></div></span><div>I'm building sparc now. What mismatches do you see?</div><div><br></div><div>I started another thread for CSWTCH.*. That's not the type of mismatch Cillian </div><div>worked on last summer. It is a symbol that isn't even code and shouldn't be</div><div>in the symbol set.</div><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-h5"><div> </div></div></div></div></div></div></blockquote></span><div>I saw the other thread . In sparc I'm getting CSWTCH.* in local text segment "t" .</div></div></div></div></blockquote><div><br></div></span><div>Grr... this may require us to toss out some symbol patterns that are generated</div><div>by GCC. </div><span class="m_2470574478394775560m_2772094073915690197gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div><div>[lunatic@lunatic samples]$ sparc-rtems5-nm base_sp/base_sp.exe | grep -i csw</div><div>40010c18 t CSWTCH.1</div></div></div></div></div></blockquote><div><br></div></span><div>I see this also on the sparc. On the i386, it is rodata.</div><span class="m_2470574478394775560m_2772094073915690197gmail-"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>I followed the INFO messages for a mismatch in _Workspace_Allocate_or_fatal_<wbr>error </div><div><br></div><div>here's what I came up with </div><div><br></div><div>--------------- capture.exe</div><div><div>[lunatic@lunatic samples]$ sparc-rtems5-objdump -d capture/capture.exe | grep "_Workspace_Allocate_or_fatal_<wbr>error"</div><div>40010c5c:<span style="white-space:pre-wrap"> </span>40 00 15 8c <span style="white-space:pre-wrap"> </span>call 4001628c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>400117ac:<span style="white-space:pre-wrap"> </span>40 00 12 b8 <span style="white-space:pre-wrap"> </span>call 4001628c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>40011938:<span style="white-space:pre-wrap"> </span>40 00 12 55 <span style="white-space:pre-wrap"> </span>call 4001628c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>40015c94:<span style="white-space:pre-wrap"> </span>40 00 01 7e <span style="white-space:pre-wrap"> </span>call 4001628c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>4001628c <_Workspace_Allocate_or_fatal_<wbr>error>:</div><div>400162ac:<span style="white-space:pre-wrap"> </span>02 80 00 04 <span style="white-space:pre-wrap"> </span>be 400162bc <_Workspace_Allocate_or_fatal_<wbr>error+0x30></div><div>4002cb14:<span style="white-space:pre-wrap"> </span>7f ff a5 de <span style="white-space:pre-wrap"> </span>call 4001628c <_Workspace_Allocate_or_fatal_<wbr>error></div></div><div><br></div><div>-------------- base_sp.exe</div><div><div>[lunatic@lunatic samples]$ sparc-rtems5-objdump -d base_sp/base_sp.exe | grep "_Workspace_Allocate_or_fatal_<wbr>error"</div><div>40008068:<span style="white-space:pre-wrap"> </span>40 00 11 49 <span style="white-space:pre-wrap"> </span>call 4000c58c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>400089f4:<span style="white-space:pre-wrap"> </span>40 00 0e e6 <span style="white-space:pre-wrap"> </span>call 4000c58c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>40008b80:<span style="white-space:pre-wrap"> </span>40 00 0e 83 <span style="white-space:pre-wrap"> </span>call 4000c58c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>4000c0e0:<span style="white-space:pre-wrap"> </span>40 00 01 2b <span style="white-space:pre-wrap"> </span>call 4000c58c <_Workspace_Allocate_or_fatal_<wbr>error></div><div>4000c58c <_Workspace_Allocate_or_fatal_<wbr>error>:</div><div>4000c5ac:<span style="white-space:pre-wrap"> </span>02 80 00 04 <span style="white-space:pre-wrap"> </span>be 4000c5bc <_Workspace_Allocate_or_fatal_<wbr>error+0x30></div></div></div></div></div></blockquote><div><br></div></span><div>That shows the references to the symbol not the size. You need to look at the start of</div><div>the symbol and start of the following symbol.</div><div><br></div><div>I looked at the "nm -N" output for base_sp.</div><div><br></div><div><div>0200ba0c T _Workspace_Allocate_or_fatal_<wbr>error</div><div>0200ba48 T _SPARC_Counter_read_address</div></div><div><br></div></div></div></div></blockquote><div>I get this for base_sp </div><div>4000c58c T _Workspace_Allocate_or_fatal_<wbr>error</div><div>4000c5e0 T syscall</div><div><br></div><div>0xe0 - 0x8c = 0x54 ==> 84</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div>And for capture:</div><div><br></div><div><div>02015c3c T _Workspace_Allocate_or_fatal_<wbr>error</div><div>02015c78 T rtems_shell_wait_for_explicit_<wbr>input</div></div><div><br></div></div></div></div></blockquote><div> 4001628c T _Workspace_Allocate_or_fatal_<wbr>error</div><div>400162c8 T rtems_shell_wait_for_explicit_<wbr>input</div><div><br></div><div>0xc8 - 0x8c = 0x3C ==> 60</div></div></div></div></blockquote><div><br></div><div>OK. In base_sp.exe, what is at the end of the method
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">_Workspace_Allocate_or_fatal_</span><wbr style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">error before the beginning of syscall?</span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">When you compare the code for
<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">_Workspace_Allocate_or_fatal_</span><wbr style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">error in both .exe files, are they the same? They should be since the code is coming from a library and it always has matched in the past. But...</span></span></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div></div><div>base_sp: 0x48 - 0x0c = 0x3C ==> 60</div><div>capture: 0x78 - 0x3c = 0x3c ==> 60</div><div><br></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Based on that alone, they are the same size. Now let's look at the objdump and see what's</div><div>at the end that might look like padding:</div><div><br></div><div>base_sp.exe ========================</div><div><div> _Internal_error( INTERNAL_ERROR_WORKSPACE_<wbr>ALLOCATION );</div><div> 200ba3c: 7f ff ea d4 call 200658c <_Internal_error></div><div> 200ba40: 90 10 20 03 mov 3, %o0</div><div> 200ba44: 01 00 00 00 nop </div><div>==============================<wbr>======</div></div><div><br></div><div>The nop would be considered padding by covoar since it is at the end of the method.</div><div><br></div><div>capture.exe ===========================</div><div><br></div><div><div> _Internal_error( INTERNAL_ERROR_WORKSPACE_<wbr>ALLOCATION );</div><div> 2015c6c: 7f ff e6 53 call 200f5b8 <_Internal_error></div><div> 2015c70: 90 10 20 03 mov 3, %o0</div><div> 2015c74: 01 00 00 00 nop </div></div><div><br></div><div>
<div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><div>==============================<wbr>======</div></div><br class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-Apple-interchange-newline">
Comparing the body of the two methods based on objdump output, I don't</div><div>see any difference for sparc/erc32 at -O2. </div><div><br></div><div>I repeated looking at the objdump output at -Os and they were the same instructions</div><div>and length.</div><div><br></div><div>You will have to investigate to see why they are different on your side.</div><span class="m_2470574478394775560m_2772094073915690197gmail-HOEnZb"><font color="#888888"><div><br></div></font></span></div></div></div></blockquote><div>What am I doing different ? Is it because of the covoar patches ?</div><div>(have you applied the patches ?)</div></div></div></div></blockquote><div><br></div><div>I got my results comparing the .exe's by hand with no involvement of covoar.</div><div><br></div><div>What compiler flags are you using? -O2 or -Os? Gcov arguments? Any other</div><div>changes to them?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_2470574478394775560m_2772094073915690197gmail-HOEnZb"><font color="#888888"><div>--joel</div></font></span><div><div class="m_2470574478394775560m_2772094073915690197gmail-h5"><div><br></div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-h5"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"></div><div dir="auto">Probably i386. Aren't you running pc386?</div><div dir="auto"><br></div></div></blockquote></span><div>I'm running sparc</div><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"></div><div dir="auto">Not sparc/erc32 or Leon</div></div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276HOEnZb"><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276h5"><br><div class="gmail_quote"><div dir="ltr">On Mon, May 21, 2018, 6:35 AM Cillian O'Donnell <<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer" target="_blank">cpodonnell8@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, 21 May 2018, 12:18 Vijay Kumar Banerjee, <<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 May 2018 at 16:39, Cillian O'Donnell <span dir="ltr"><<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276m_5518126552413908762m_1612166697559914221m_-8106430252577823787h5"><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, 21 May 2018, 12:08 Cillian O'Donnell, <<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr">On Mon, 21 May 2018, 11:49 Vijay Kumar Banerjee, <<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 May 2018 at 11:56, Cillian O'Donnell <span dir="ltr"><<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><div class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276m_5518126552413908762m_1612166697559914221m_-8106430252577823787m_1047385809759691336m_7800928857064215187m_-8772422482505828281gmail-h5"><div><br><br><div class="gmail_quote"><div dir="ltr">On Sun, 20 May 2018, 22:33 Vijay Kumar Banerjee, <<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 21 May 2018 at 02:29, Cillian O'Donnell <span dir="ltr"><<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span><div><br><br><div class="gmail_quote"><div dir="ltr">On Sun, 20 May 2018, 15:35 Vijay Kumar Banerjee, <<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 20 May 2018 at 00:53, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="auto"><div><br><br><div class="gmail_quote"><span><div dir="ltr">On Sun, 20 May 2018, 00:45 Cillian O'Donnell, <<a href="mailto:cpodonnell8@gmail.com" rel="noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer noreferrer" target="_blank">cpodonnell8@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">It works.. Sorry I was using the right covoar but the wrong rtems-test. Ahh its nice to see the data back in the reports again. Did you manage to track down 2 exes with the mismatch in symbol size?<br></div></blockquote></span><div>Great! so next is the parsing of the symbol file.</div><div>I couldn't manage to track down the mismatch.<br></div></div></div><div dir="auto"><br></div></div></div></blockquote><div>I have pushed these to my master branch.</div><div><br></div><div>The latest update to cov-tester-support branch (please have a look)</div><div>parses the symbol-set ini file from the coverage script. The parsing </div><div>is working but currently it's not generating reports, as covoar</div><div>needs to be updated . </div></div></div></div></blockquote></div></div><div dir="auto"><br></div></span><div dir="auto">It's best if covoar reads it's own config file, otherwise it creates a dependency on the tester. Scanning over the recent changes to covoar there, it looks like it can already handle multiple sets, so the one ini with multiple sets in it is the way to go.</div></div></blockquote><div>Okay, Understood.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Here are the things that I have done and that needs to be</div><div>done in order to generate reports :</div><div><br></div><div>I have added a symbol-sets.ini file and parsed it from the coverage script <br>this is how it works :<br><div><br></div></div><div><ul><li>The ini file can be updated with all the symbols, separated by ' , ' (comma)<br></li></ul></div></div></div></div></blockquote></div></div><div dir="auto"><br></div></span><div dir="auto">This is the way covoar is actually handling it now. You should test a multi set ini and see if that's working.</div></div></blockquote><div>Yeah, I have seen it. will try with multiple sets.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><ul><li></li><li>The coverages splits them and makes a list of all the sets</li><li> The respective libraries are parsed from the libraries section.</li><li>It returns a dict with all the symbols and thir resp. library addresses.</li><li>The library addresses are absolute so it can be run from anywhere<br>top of build tree is not necessary.</li></ul></div></div></div></div></blockquote></div></div></span><div dir="auto">This was a good idea but it's just that dependency issue we want to stay away from. Covoar has something to find the build directory too, it just hasn't been connected up yet, so running it from the top of the build directory is ok for the moment.</div></div></blockquote><div> </div><div>yes it can find the build directory. I was giving it a shot to do it from the script. </div><div><br></div><div>If covoar's standalone working is a necessity then it surely needs to be working<br></div><div>from covoar and shouldn't depend on the script. </div></div></div></div></blockquote></div></div><div dir="auto"><br></div></div></div><div dir="auto">It should be working from covoar and it will.</div><span class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276m_5518126552413908762m_1612166697559914221m_-8106430252577823787m_1047385809759691336m_7800928857064215187m_-8772422482505828281gmail-"><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">Probably the most pressing thing now is investigating those mismatch in symbol size.</div></div></blockquote><div><br></div><div>any advice on where/how to look for it ? </div></div></div></div></blockquote></div></div><div dir="auto"><br></div></span><div dir="auto">Before what I was doing was examining the objdump of 2 exes, looking there on the weekend i think the info messages mentioned which ones were having trouble for which symbol. It says something like "couldn't merge coverage map for some_symbol because sizes from exe != to size of other_exe. Look at the objdump of exe and other_exe, search for some_symbol and compare the dissasembly. There'll be more lines in one than the other, nop padding probably. Then you had to find a check that was strict enough to chop the end of the symbol in question at the right place but not so strict that it chopped other symbols in the wrong place. However the method of obtaining the symbols has changed, I'll have to have a look over the covoar changes tonight to see what would be the equivalent method of checking this now. Unless Chris or Joel come back with the answer before then.</div><div dir="auto"><br></div></div></blockquote><div>Please have a look into this as I'm confused .</div><div>From the messages it seems like there's something with </div><div>the base_sp.exe .</div><div>I tried to run objdum with -d , I'm getting an error</div><div>objdump: can't disassemble for architecture UNKNOWN!</div><div>what am I missing ? </div></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">It'll be a sparc-objdump that was built with the rsb in 5/bin/. I'm not sure if we're still grabbing the objdump using rtems-tools</div></div></blockquote></div></div></div></div></div></blockquote><div>can't run sparc-objdump. </div></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">That might not be the exact name. Is there something that looks like it in that directory.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto">Sorry *rtemstoolkit</div><span><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"> now, so not 100% sure that this still the way to investigate this.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"></div><div dir="auto">Also there will probably be multiple ini's with different collections of sets that the user could run so it would be good to give them some method of choosing which ini they want, like coverage=score will feed score.ini to covoar. You could try have a go at that.</div></div></blockquote><div> </div><div>yeah I was planning something similar with the script </div><div>to let users choose the sets, and run all by default .</div><div>I guess it needs to be done from covoar to avoid dependancy.</div><div>I can have look into this.</div></div></div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">This is different in that it's just allowing the user an easier way of choosing the right ini. So it wouldn't be a dependency like the other thing, if you run it manually you will still have to select the ini you want. So this will be part of the script.</div></div></blockquote></div></div></span></div></blockquote><div>Oh , I will look into this then. :) </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span class="m_2470574478394775560m_2772094073915690197gmail-m_2557134732714853775gmail-m_-7419438783420368697gmail-m_-1287339878713507067m_-6390005842684536276m_5518126552413908762m_1612166697559914221m_-8106430252577823787m_1047385809759691336m_7800928857064215187m_-8772422482505828281gmail-"><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><span><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>This way we can parse all the symbols from the same ini file.</div><div><br></div><div>what needs to be done :</div><div><ul><li>I have added #FIXME s in the code , those are the small fixes that <br>would be needed .</li><li>The covoar needs to be updated. My proposal is that we can feed the<br>parsed dict to the covoar instead of feeding the symbol file and letting <br>covoar parse it ( As I mentioned previously). </li></ul></div></div><br></div></div>
</blockquote></div></div></span></div>
</blockquote></div><br></div></div>
</blockquote></div></div></span></div>
</blockquote></div><br></div></div>
</blockquote></div></div></div></blockquote></div></div></span></div>
</blockquote></div><br></div></div>
</blockquote></div></div></div>
</blockquote></div>
</div></div></blockquote></div></div></div><br></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>
</blockquote></div></div></div></div>