<div dir="auto"><div>Chris needs to speak up since it is Python.</div><div dir="auto"><br></div><div dir="auto">I see changes to HTML output which I doubt are related to the core change.<br><br><div class="gmail_quote" dir="auto"><div dir="ltr">On Tue, Jun 12, 2018, 8:39 AM Vijay Kumar Banerjee <<a href="mailto:vijaykumar9597@gmail.com">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra">Please review this patch. :)<br><div class="gmail_quote">On 7 June 2018 at 16:38, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" target="_blank" rel="noreferrer">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Close #3440<br>
---<br>
tester/rt/coverage.py | 6 ++++--<br>
tester/rt/test.py | 15 ++++++++++-----<br>
2 files changed, 14 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/tester/rt/coverage.py b/tester/rt/coverage.py<br>
index 54933d5..af24124 100644<br>
--- a/tester/rt/coverage.py<br>
+++ b/tester/rt/coverage.py<br>
@@ -163,7 +163,8 @@ class report_gen_html:<br>
row += " <td>" + summary.branches_uncovered + "</td>"<br>
row += " <td>" + summary.branches_total + "</td>"<br>
row += " <td> {:.3%} </td>".format(summary.percentage_branches_covered)<br>
- row += ' <td><progress value="{:.3}" max="100"></progress></td>'.format(100*summary.percentage_branches_covered)<br>
+ row += ' <td><progress value="{:.3}" max="100"></progress></td>'\<br>
+ .format(100*summary.percentage_branches_covered)<br>
row += "</tr>\n"<br>
return row<br>
<br>
@@ -299,7 +300,8 @@ class covoar(object):<br>
if (not path.exists(covoar_result_dir)):<br>
path.mkdir(covoar_result_dir)<br>
if (not path.exists(symbol_file)):<br>
- raise error.general('symbol set file: coverage %s was not created for covoar, skipping %s'% (symbol_file, set_name))<br>
+ raise error.general('symbol set file: %s was not '<br>
+ 'created for covoar, skipping %s'% (symbol_file, set_name))<br>
command = ('covoar -S ' + symbol_file<br>
+ ' -O ' + covoar_result_dir<br>
+ ' -E ' + self.explanations_txt<br>
diff --git a/tester/rt/test.py b/tester/rt/test.py<br>
index 0e744cd..cdb5157 100644<br>
--- a/tester/rt/test.py<br>
+++ b/tester/rt/test.py<br>
@@ -232,7 +232,7 @@ def run(command_path = None):<br>
'--filter': 'Glob that executables must match to run (default: ' +<br>
default_exefilter + ')',<br>
'--stacktrace': 'Dump a stack trace on a user termination (^C)',<br>
- '--coverage': 'Perform coverage analysis of test executables.'}<br>
+ '--coverage-sets': 'Perform coverage for specific sets'}<br>
mailer.append_options(optargs)<br>
opts = options.load(sys.argv,<br>
optargs = optargs,<br>
@@ -279,15 +279,20 @@ def run(command_path = None):<br>
else:<br>
rtems_tools = '%{_prefix}'<br>
bsp = opts.find_arg('--rtems-bsp')<br>
+ if 'cov' in bsp[1].split('-'):<br>
+ coverage_enabled = True<br>
if bsp is None or len(bsp) != 2:<br>
raise error.general('RTEMS BSP not provided or an invalid option')<br>
bsp = config.load(bsp[1], opts)<br>
bsp_config = opts.defaults.expand(opts.defaults['tester'])<br>
- coverage_enabled = opts.find_arg('--coverage')<br>
+ coverage_sets = opts.find_arg('--coverage-sets')<br>
if coverage_enabled:<br>
- if len(coverage_enabled) == 2:<br>
- coverage_runner = coverage.coverage_run(opts.defaults,<br>
- coverage_enabled[1],<br>
+ if coverage_sets:<br>
+ if len(coverage_sets) != 2:<br>
+ raise error.general('No sets provided in --coverage-sets')<br>
+ else :<br>
+ coverage_runner = coverage.coverage_run(opts.defaults,<br>
+ coverage_sets[1],<br>
executables)<br>
else:<br>
coverage_runner = coverage.coverage_run(opts.defaults, 0,<br>
<span class="m_-8598312699126845365HOEnZb"><font color="#888888">-- <br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div></div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div></div></div>