<div dir="auto">Kryzstof is the original author, so his name should probably stick. You could add lines for<div dir="auto"><br></div><div dir="auto">Reviewed by: Vijay on date: ...</div><div dir="auto"><br></div><div dir="auto">I think that's standard enough</div><div dir="auto"><br></div><div dir="auto">All the best,</div><div dir="auto"><br></div><div dir="auto">Cillian</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 26 Jul 2018, 17:22 Vijay Kumar Banerjee, <<a href="mailto:vijaykumar9597@gmail.com">vijaykumar9597@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello,<div><br></div><div>I have a question which I forgot to ask before.</div><div>Should the coverage.py and symbol-sets.ini files have mine and/or Cillian's name </div><div>included in the copyright notice?</div><div><br></div><div>--vijayk</div><div>On 26 July 2018 at 13:09, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" target="_blank" rel="noreferrer">vijaykumar9597@gmail.com</a>></span> wrote:<br></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">I have added all the libs in cpukit and commented them out.</div><div class="gmail_quote">Please have a look at the attached file.</div><div><div class="m_4036040814909323829h5"><div class="gmail_quote"><br></div><div class="gmail_quote">On 26 July 2018 at 04:50, Joel Sherrill <span dir="ltr"><<a href="mailto:joel@rtems.org" target="_blank" rel="noreferrer">joel@rtems.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Jul 25, 2018 at 10:41 AM, Vijay Kumar Banerjee <span dir="ltr"><<a href="mailto:vijaykumar9597@gmail.com" target="_blank" rel="noreferrer">vijaykumar9597@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
tester/rtems/testing/coverage/symbol-sets.ini | 11 ++++++++---<br>
1 file changed, 8 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/tester/rtems/testing/coverage/symbol-sets.ini b/tester/rtems/testing/coverage/symbol-sets.ini<br>
index a2ec7bc..3900f14 100644<br>
--- a/tester/rtems/testing/coverage/symbol-sets.ini<br>
+++ b/tester/rtems/testing/coverage/symbol-sets.ini<br>
@@ -29,8 +29,13 @@<br>
#<br>
<br>
[symbol-sets]<br>
-sets = score,rtems<br>
+sets = score,rtems,libblock,libcrypt,libcsupport,libmd,libnetworking<br>
<br>
[libraries]<br>
-score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a<br>
-rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a<br>
+score = @BUILD-TARGET@/c/@BSP@/cpukit/score/libscore.a<br>
+rtems = @BUILD-TARGET@/c/@BSP@/cpukit/rtems/librtems.a<br>
+libblock = @BUILD-TARGET@/c/@BSP@/cpukit/libblock/libblock.a<br>
+libcrypt = @BUILD-TARGET@/c/@BSP@/cpukit/libcrypt/libcrypt.a<br>
+libcsupport = @BUILD-TARGET@/c/@BSP@/cpukit/libcsupport/libcsupport.a<br>
+libmd = @BUILD-TARGET@/c/@BSP@/cpukit/libmd/libmd.a<br>
+libnetworking = @BUILD-TARGET@/c/@BSP@/cpukit/libnetworking/libnetworking.a<br></blockquote><div><br></div></span><div>To be at parity with the old reports but reported on finer granularity, </div><div>follow the list at </div><div><br></div><div><a href="https://git.rtems.org/rtems-testing/tree/rtems-coverage/do_coverage#n507" target="_blank" rel="noreferrer">https://git.rtems.org/rtems-testing/tree/rtems-coverage/do_coverage#n507</a><br></div><div><br></div><div>and check what is not listed there that is in cpukit now. For example, jffs2</div><div>isn't listed in the above. But the things consciously skipped have a good</div><div>reason. Add a list of the ones not included. It may make sense to</div><div>have something like this for the ones deliberately skipped:</div><div><br></div><div># librpc = @....libXXX.a</div><div><br></div><div>It will make auditing what's in the cpukit versus the ini file easier.</div><div>That's why my old script has them in order and commented out the</div><div>ones we were not ready to do or never would. </div><div><br></div><div>But for sure, add posix, sapi, libdl, individual filesystem, and catch</div><div>the libmisc subdirectories listed in the old script for inclusion. for new</div><div>libmisc content, we can make a decision.</div><div><br></div><div>Don't include libnetworking. As a general rule, we don't do coverage testing</div><div>on networking or any (complex) third party software. </div><div><br></div><div>I don't think dtc will get coverage either.</div><div><br></div><div>That should get us closer. I expect you will find some libraries</div><div>to ask questions on. :)</div><span class="m_4036040814909323829m_-7984705968547304907HOEnZb"><font color="#888888"><div><br></div><div>--joel</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="m_4036040814909323829m_-7984705968547304907m_7363773634010669227gmail-HOEnZb"><font color="#888888">-- <br>
2.14.4<br>
<br>
</font></span></blockquote></font></span></div><br></div></div>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div></div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div>