<div dir="auto">I am traveling this week and reviewing as I can. I plan to review and merge again this evening when I am at my destination.<div dir="auto"><br></div><div dir="auto">Please make sure you have no warnings.</div><div dir="auto"><br></div><div dir="auto">If the method has an int return type, return that from the method. If not, ro something like return (result != VALUE). Often the return type is a pointer so value would be NULL.</div><div dir="auto"><br></div><div dir="auto">Make sure there is a blank line between the Doxygen block and copyright block.</div><div dir="auto"><br></div><div dir="auto">And all variables should be local to the test method.</div><div dir="auto"><br></div><div dir="auto">Those seem to be the issues I am seeing in these tasks.</div><div dir="auto"><br></div><div dir="auto">That's all I can do from my phone. About to head to the gate.</div><div dir="auto"><br></div><div dir="auto">--joel</div></div><br><div class="gmail_quote"><div dir="ltr">On Sun, Dec 2, 2018, 12:46 PM Shashvat Jain <<a href="mailto:shashvatjain2002@gmail.com">shashvatjain2002@gmail.com</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">here is the updated patch attached</div><br><div class="gmail_quote"><div dir="ltr">On Sun, Dec 2, 2018 at 8:28 PM Shashvat Jain <<a href="mailto:shashvatjain2002@gmail.com" target="_blank" rel="noreferrer">shashvatjain2002@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div><div><div><div><div>Hello ,<br></div>I just added the test for utime.h header files<br></div>the patch for the change has been attached here,<br></div><br><br>Thank you<br></div>Regards <br></div><div><br></div><div><br></div><div>============================================================</div><div><br></div><div>From 48d40d771c684af848a26efb1fff8a8d6e110c95 Mon Sep 17 00:00:00 2001</div><div>From: Shashvat Jain <<a href="mailto:shashvatjain2002@gmail.com" target="_blank" rel="noreferrer">shashvatjain2002@gmail.com</a>></div><div>Date: Sat, 1 Dec 2018 12:57:44 -0500</div><div>Subject: [PATCH] psxhdrs : Add POSIX API Signature Compliance Tests for</div><div> utime.h (GCI 2018)</div><div><br></div><div>---</div><div> testsuites/psxtests/Makefile.am | 1 +</div><div> 1 file changed, 1 insertion(+)</div><div><br></div><div>diff --git a/testsuites/psxtests/Makefile.am b/testsuites/psxtests/Makefile.am</div><div>index 553b259..8c527a8 100644</div><div>--- a/testsuites/psxtests/Makefile.am</div><div>+++ b/testsuites/psxtests/Makefile.am</div><div>@@ -1069,6 +1069,7 @@ lib_a_SOURCES = psxhdrs/devctl/posix_devctl.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/unistd/setsid.c psxhdrs/unistd/setuid.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/unistd/sleep.c psxhdrs/unistd/sync.c psxhdrs/unistd/ualarm.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/unistd/usleep.c psxhdrs/sys/mman/mlockall.c \</div><div>+ psxhdrs/utime/utime.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/sys/mman/mlock.c psxhdrs/sys/mman/mmap.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/sys/mman/mprotect.c psxhdrs/sys/mman/msync.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/sys/mman/munlockall.c psxhdrs/sys/mman/munlock.c \</div><div>-- </div><div>1.8.3.1</div></div></div>
</blockquote></div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div>