<div dir="ltr"><div>Three issues that I see:</div><div><br></div><div>+ Update the license.</div><div>+ I fixed an unitialized variable warning for a in catclose.c with "= {0}"</div><div>+ But the worst is that nl_types.h isn't supported by RTEMS so a new POSIX-Compliance ticket for this needs to be filed.</div><div><br></div><div>Please tidy up and resubmit.</div><div><br></div><div>Thanks.<br></div><div><br></div><div>--joel<br></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 12, 2018 at 2:25 AM Abhimanyu Raghuvanshi <<a href="mailto:abhimanyuraghuvanshi29@gmail.com">abhimanyuraghuvanshi29@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Attaching the patch file<br><br>===================<div><div>From 3fad278aa27a0ebbd584e4ae9eb6ab0a0d498c00 Mon Sep 17 00:00:00 2001</div><div>From: ABR290B <<a href="mailto:abhimanyuraghuvanshi29@gmail.com" target="_blank">abhimanyuraghuvanshi29@gmail.com</a>></div><div>Date: Wed, 12 Dec 2018 13:53:05 +0530</div><div>Subject: [PATCH] POSIX Signature Test for nl_types.h (GCI2018)</div><div><br></div><div>---</div><div> testsuites/psxtests/Makefile.am | 5 ++-</div><div> .../psxtests/psxhdrs/nl_types/catclose.c | 36 +++++++++++++++++++</div><div> .../psxtests/psxhdrs/nl_types/catgets.c | 36 +++++++++++++++++++</div><div> .../psxtests/psxhdrs/nl_types/catopen.c | 35 ++++++++++++++++++</div><div> 4 files changed, 111 insertions(+), 1 deletion(-)</div><div> create mode 100644 testsuites/psxtests/psxhdrs/nl_types/catclose.c</div><div> create mode 100644 testsuites/psxtests/psxhdrs/nl_types/catgets.c</div><div> create mode 100644 testsuites/psxtests/psxhdrs/nl_types/catopen.c</div><div><br></div><div>diff --git a/testsuites/psxtests/Makefile.am b/testsuites/psxtests/Makefile.am</div><div>index 3dd8fe0139..9cff5084bb 100644</div><div>--- a/testsuites/psxtests/Makefile.am</div><div>+++ b/testsuites/psxtests/Makefile.am</div><div>@@ -1815,7 +1815,10 @@ lib_a_SOURCES = psxhdrs/devctl/posix_devctl.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/setjmp/longjmp.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/setjmp/setjmp.c \</div><div> <span style="white-space:pre-wrap"> </span>psxhdrs/setjmp/siglongjmp.c \</div><div>-<span style="white-space:pre-wrap"> </span>psxhdrs/setjmp/sigsetjmp.c</div><div>+<span style="white-space:pre-wrap"> </span>psxhdrs/setjmp/sigsetjmp.c \</div><div>+<span style="white-space:pre-wrap"> </span>psxhdrs/nl_types/catclose.c \</div><div>+<span style="white-space:pre-wrap"> </span>psxhdrs/nl_types/catopen.c \</div><div>+<span style="white-space:pre-wrap"> </span>psxhdrs/nl_types/catgets.c </div><div> </div><div> ## Not supported by RTEMS, but POSIX API Compliance tests exist.</div><div> ## lib_a_SOURCES += psxhdrs/ulimit/ulimit.c</div><div>diff --git a/testsuites/psxtests/psxhdrs/nl_types/catclose.c b/testsuites/psxtests/psxhdrs/nl_types/catclose.c</div><div>new file mode 100644</div><div>index 0000000000..1e09fd46d0</div><div>--- /dev/null</div><div>+++ b/testsuites/psxtests/psxhdrs/nl_types/catclose.c</div><div>@@ -0,0 +1,36 @@</div><div>+/**</div><div>+ * @file</div><div>+ * @brief catclose() API Conformance Test</div><div>+ */</div><div>+</div><div>+/*</div><div>+ * COPYRIGHT (c) 2018.</div><div>+ * Abhimanyu Raghuvanshi</div><div>+ *</div><div>+ * Permission to use, copy, modify, and/or distribute this software</div><div>+ * for any purpose with or without fee is hereby granted.</div><div>+ * </div><div>+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL</div><div>+ * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED</div><div>+ * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR</div><div>+ * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES</div><div>+ * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,</div><div>+ * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,</div><div>+ * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.</div><div>+ */</div><div>+</div><div>+#ifdef HAVE_CONFIG_H</div><div>+#include "config.h"</div><div>+#endif</div><div>+</div><div>+#include <nl_types.h></div><div>+</div><div>+</div><div>+int test(void);</div><div>+</div><div>+int test(void)</div><div>+{</div><div>+ nl_catd a;</div><div>+ catclose(a);</div><div>+ return 0;</div><div>+}</div><div>\ No newline at end of file</div><div>diff --git a/testsuites/psxtests/psxhdrs/nl_types/catgets.c b/testsuites/psxtests/psxhdrs/nl_types/catgets.c</div><div>new file mode 100644</div><div>index 0000000000..e9ff8bef40</div><div>--- /dev/null</div><div>+++ b/testsuites/psxtests/psxhdrs/nl_types/catgets.c</div><div>@@ -0,0 +1,36 @@</div><div>+/**</div><div>+ * @file</div><div>+ * @brief catgets() API Conformance Test</div><div>+ */</div><div>+</div><div>+/*</div><div>+ * COPYRIGHT (c) 2018.</div><div>+ * Abhimanyu Raghuvanshi</div><div>+ *</div><div>+ * Permission to use, copy, modify, and/or distribute this software</div><div>+ * for any purpose with or without fee is hereby granted.</div><div>+ * </div><div>+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL</div><div>+ * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED</div><div>+ * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR</div><div>+ * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES</div><div>+ * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,</div><div>+ * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,</div><div>+ * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.</div><div>+ */</div><div>+ </div><div>+#ifdef HAVE_CONFIG_H</div><div>+#include "config.h"</div><div>+#endif</div><div>+</div><div>+#include <nl_types.h></div><div>+</div><div>+</div><div>+int test(void);</div><div>+</div><div>+int test(void)</div><div>+{</div><div>+ nl_catd a = 0;</div><div>+ char *b = catgets(a, NL_SETD, 1, "/path/to/file");</div><div>+ return b != 0;</div><div>+}</div><div>\ No newline at end of file</div><div>diff --git a/testsuites/psxtests/psxhdrs/nl_types/catopen.c b/testsuites/psxtests/psxhdrs/nl_types/catopen.c</div><div>new file mode 100644</div><div>index 0000000000..637f100267</div><div>--- /dev/null</div><div>+++ b/testsuites/psxtests/psxhdrs/nl_types/catopen.c</div><div>@@ -0,0 +1,35 @@</div><div>+/**</div><div>+ * @file</div><div>+ * @brief catopen() API Conformance Test</div><div>+ */</div><div>+</div><div>+/*</div><div>+ * COPYRIGHT (c) 2018.</div><div>+ * Abhimanyu Raghuvanshi</div><div>+ *</div><div>+ * Permission to use, copy, modify, and/or distribute this software</div><div>+ * for any purpose with or without fee is hereby granted.</div><div>+ * </div><div>+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL</div><div>+ * WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED</div><div>+ * WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR</div><div>+ * BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES</div><div>+ * OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,</div><div>+ * WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,</div><div>+ * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.</div><div>+ */</div><div>+ </div><div>+#ifdef HAVE_CONFIG_H</div><div>+#include "config.h"</div><div>+#endif</div><div>+</div><div>+#include <nl_types.h></div><div>+</div><div>+</div><div>+int test(void);</div><div>+</div><div>+int test(void)</div><div>+{</div><div>+ nl_catd msg_file = catopen("/path/to/file", 0);</div><div>+ return msg_file != (nl_catd) -1;</div><div>+}</div><div>\ No newline at end of file</div><div>-- </div><div>2.19.1.windows.1</div><div>=====================</div><div><br></div><div><br></div><div><div dir="ltr" class="gmail-m_6866039090326716698gmail_signature"><div dir="ltr"><div><br></div><div><font face="arial black, sans-serif">ABR</font></div></div></div></div></div></div></div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div>