<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><font size="+1"><tt>Hi there,</tt></font></p>
<p><font size="+1"><tt><br>
</tt></font></p>
<p><font size="+1"><tt>while reviewing the doxygen documentation in
this file I found some instances where I think the function
parameters should be made constant.</tt></font></p>
<p><font size="+1"><tt>Bellow my suggested changes:<br>
</tt></font></p>
<p><font size="+1"><tt><br>
</tt></font></p>
<p><font size="+1"><tt>commit
9fc61307be4f21039b7cd4553099e29e5fd5e456 (HEAD)</tt></font></p>
<font size="+1"><tt>Author: Andreas Dachsberger
<a class="moz-txt-link-rfc2396E" href="mailto:andreas.dachsberger@embedded-brains.de"><andreas.dachsberger@embedded-brains.de></a></tt></font><br>
<font size="+1"><tt>Date: Fri Apr 5 08:28:08 2019 +0200</tt></font><br>
<br>
<font size="+1"><tt> Added const to function parameters.</tt></font><br>
<font size="+1"><tt>---
</tt></font><br>
<font size="+1"><tt>cpukit/include/rtems/score/chainimpl.h | 28
++++++++++++++--------------</tt></font><br>
<br>
<font size="+1"><tt>1 file changed, 14 insertions(+), 14
deletions(-)</tt></font><br>
<br>
<tt><font size="+1">diff --git
a/cpukit/include/rtems/score/chainimpl.h
b/cpukit/include/rtems/score/chainimpl.h<br>
index 0b9c193044..264cbe094c 100644<br>
--- a/cpukit/include/rtems/score/chainimpl.h<br>
+++ b/cpukit/include/rtems/score/chainimpl.h<br>
@@ -222,7 +222,7 @@ RTEMS_INLINE_ROUTINE const Chain_Node
*_Chain_Immutable_head(<br>
* @return This method returns the permanent tail node of the
chain.<br>
*/<br>
RTEMS_INLINE_ROUTINE Chain_Node *_Chain_Tail(<br>
- Chain_Control *the_chain<br>
+ const Chain_Control *the_chain<br>
)<br>
{<br>
return &the_chain->Tail.Node;<br>
@@ -555,7 +555,7 @@ RTEMS_INLINE_ROUTINE void
_Chain_Initialize_one(<br>
* @param[in] the_node is the node to be extracted.<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Extract_unprotected(<br>
- Chain_Node *the_node<br>
+ const Chain_Node *the_node<br>
)<br>
{<br>
Chain_Node *next;<br>
@@ -858,10 +858,10 @@ typedef bool ( *Chain_Node_order )(<br>
* @param[in] order The order relation.<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Insert_ordered_unprotected(<br>
- Chain_Control *the_chain,<br>
- Chain_Node *to_insert,<br>
- const void *left,<br>
- Chain_Node_order order<br>
+ Chain_Control *the_chain,<br>
+ Chain_Node *to_insert,<br>
+ const void *left,<br>
+ const Chain_Node_order order<br>
)<br>
{<br>
const Chain_Node *tail = _Chain_Immutable_tail( the_chain );<br>
@@ -960,7 +960,7 @@ RTEMS_INLINE_ROUTINE void
_Chain_Iterator_registry_initialize(<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Iterator_registry_update(<br>
Chain_Iterator_registry *the_registry,<br>
- Chain_Node *the_node_to_extract<br>
+ const Chain_Node *the_node_to_extract<br>
)<br>
{<br>
Chain_Node *iter_node;<br>
@@ -1046,10 +1046,10 @@ RTEMS_INLINE_ROUTINE void
_Chain_Iterator_registry_update(<br>
* the linear time complexity in
_Chain_Iterator_registry_update().<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Iterator_initialize(<br>
- Chain_Control *the_chain,<br>
- Chain_Iterator_registry *the_registry,<br>
- Chain_Iterator *the_iterator,<br>
- Chain_Iterator_direction direction<br>
+ const Chain_Control *the_chain,<br>
+ Chain_Iterator_registry *the_registry,<br>
+ Chain_Iterator *the_iterator,<br>
+ const Chain_Iterator_direction direction<br>
)<br>
{<br>
_Chain_Initialize_node( &the_iterator->Registry_node
);<br>
@@ -1093,8 +1093,8 @@ RTEMS_INLINE_ROUTINE Chain_Node
*_Chain_Iterator_next(<br>
* @param the_node The new iterator position.<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Iterator_set_position(<br>
- Chain_Iterator *the_iterator,<br>
- Chain_Node *the_node<br>
+ Chain_Iterator *the_iterator,<br>
+ const Chain_Node *the_node<br>
)<br>
{<br>
the_iterator->position = the_node;<br>
@@ -1108,7 +1108,7 @@ RTEMS_INLINE_ROUTINE void
_Chain_Iterator_set_position(<br>
* @param the_iterator The chain iterator.<br>
*/<br>
RTEMS_INLINE_ROUTINE void _Chain_Iterator_destroy(<br>
- Chain_Iterator *the_iterator<br>
+ const Chain_Iterator *the_iterator<br>
)<br>
{<br>
_Chain_Extract_unprotected(
&the_iterator->Registry_node );<br>
</font></tt><br>
</body>
</html>