<div dir="ltr"><div><br></div><div><br></div><div>Are you sure it can't be NULL when POSIX is disabled? The historical case where it was NULL was when you disabled an API.</div><div><br></div><div>If it truly can't be NULL now, it would be good to see comments that explain why it can't be NULL. <br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 5, 2019 at 3:00 AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The _Objects_Information_table[ the_api ] is never NULL for a valid API<br>
index.<br>
---<br>
cpukit/posix/src/killinfo.c | 8 +-------<br>
cpukit/score/src/threaditerate.c | 5 +----<br>
2 files changed, 2 insertions(+), 11 deletions(-)<br>
<br>
diff --git a/cpukit/posix/src/killinfo.c b/cpukit/posix/src/killinfo.c<br>
index 0031b7bdd8..742f9fb2c1 100644<br>
--- a/cpukit/posix/src/killinfo.c<br>
+++ b/cpukit/posix/src/killinfo.c<br>
@@ -196,13 +196,7 @@ int _POSIX_signals_Send(<br>
interested_priority = UINT64_MAX;<br>
<br>
for (the_api = OBJECTS_CLASSIC_API; the_api <= OBJECTS_APIS_LAST; the_api++) {<br>
-<br>
- /*<br>
- * This can occur when no one is interested and an API is not configured.<br>
- */<br>
- if ( !_Objects_Information_table[ the_api ] )<br>
- continue;<br>
-<br>
+ _Assert( _Objects_Information_table[ the_api ] != NULL );<br>
the_info = _Objects_Information_table[ the_api ][ 1 ];<br>
if ( !the_info )<br>
continue;<br>
diff --git a/cpukit/score/src/threaditerate.c b/cpukit/score/src/threaditerate.c<br>
index 8d1614ab9b..78ccb6756c 100644<br>
--- a/cpukit/score/src/threaditerate.c<br>
+++ b/cpukit/score/src/threaditerate.c<br>
@@ -30,10 +30,7 @@ void _Thread_Iterate(<br>
Objects_Maximum maximum;<br>
Objects_Maximum index;<br>
<br>
- if ( _Objects_Information_table[ api_index ] == NULL ) {<br>
- continue;<br>
- }<br>
-<br>
+ _Assert( _Objects_Information_table[ api_index ] != NULL );<br>
information = _Objects_Information_table[ api_index ][ 1 ];<br>
<br>
if ( information == NULL ) {<br>
-- <br>
2.16.4<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>