<div dir="auto">Sorry for missing that it actually was referenced <div dir="auto"><br></div><div dir="auto">Rcmd can and should work. Rcmdsh will not ever and should be removed from libbsd.</div><div dir="auto"><br></div><div dir="auto">Does rcmd need testing? It clearly had no test since it wouldn't have linked.</div><div dir="auto"><br></div><div dir="auto">--joel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 4, 2019, 4:40 AM Peter Dufault <<a href="mailto:dufault@hda.com">dufault@hda.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"><div>On May 4, 2019, at 02:37 , Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a>> wrote:</div><br class="m_3247549097554731865Apple-interchange-newline"><div><div>On 4/5/19 2:30 pm, Joel Sherrill wrote:<br><blockquote type="cite">On Fri, May 3, 2019, 8:18 PM Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a> <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">mailto:chrisj@rtems.org</a>>> wrote:<br> On 4/5/19 9:16 am, Joel Sherrill wrote:<br> > On Fri, May 3, 2019, 6:04 PM Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">chrisj@rtems.org</a><br> <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">mailto:chrisj@rtems.org</a>><br> > <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">mailto:chrisj@rtems.org</a> <<a href="mailto:chrisj@rtems.org" target="_blank" rel="noreferrer">mailto:chrisj@rtems.org</a>>>> wrote:<br> ><br> > On 4/5/19 7:44 am, Lou Woods wrote:<br> > > From: Lou Woods <<a href="mailto:Lou.Woods@OARCorp.com" target="_blank" rel="noreferrer">Lou.Woods@OARCorp.com</a>><br> > ><br> > > rcmdsh() and innetgr() are referenced by rcmd, but aren’t<br> available<br> > > in libbsd and are unresolvable external symbols when<br> libbsd.a is<br> > > processed by the RTL.<br> ><br> > Why does this not show up when we statically link?<br> ><br> > I wonder if this is related to separate sections where a<br> function in a<br> > file is present but no used and it not linked but is with the<br> RTL?<br> ><br> > Statically linking an exe normally wouldn't have hit this unless you<br> > referenced rcmd. Ld wouldn't have pulled it out of the library.<br> Oh your app is referencing `rcmd`?<br>No. Lou tracked down the symbols that the RTL showed as undefined. That led us to look into rcmd and rcmdsh. I spotted the fork/exec and realized some chunk had to be removed. Rcmdsh in whole and parts of rcmd.<br></blockquote><br>What do the module dependencies look like? See ...<br><br><a href="https://docs.rtems.org/branches/master/shell/dl_commands.html#rtl-list" target="_blank" rel="noreferrer">https://docs.rtems.org/branches/master/shell/dl_commands.html#rtl-list</a><br><br>I am sorry I am not following why the rcmd.c file is being loaded. If nothing references any symbols in it it should not be loaded it.<br></div></div></blockquote>In the code Lou is looking at it is referenced.<br><blockquote type="cite"><div><div><br><blockquote type="cite"> > FWIW rcmdsh.* needs to be dropped out of the build. It requires<br> > fork/exec so will never work.<br> Should this change be a build system change or is this needed plus the<br> build system change?<br>Both. Rcmdsh.* should not be in libbsd.<br></blockquote><br>Does the `#if __rtems__` formatting conform to CONTRIBUTING.md ? It looks to me like some extra lines and `#else` with out `__rtems__`.<br><br>Chris<br>_______________________________________________<br>devel mailing list<br><a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br><a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank" rel="noreferrer">http://lists.rtems.org/mailman/listinfo/devel</a></div></div></blockquote></div><br><div>
<div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><div style="color:rgb(0,0,0);letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word"><span class="m_3247549097554731865Apple-style-span" style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><span class="m_3247549097554731865Apple-style-span" style="border-collapse:separate;color:rgb(0,0,0);font-family:Helvetica;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-variant-east-asian:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;border-spacing:0px"><div style="word-wrap:break-word"><font class="m_3247549097554731865Apple-style-span" size="3"><span class="m_3247549097554731865Apple-style-span" style="font-size:12px">Peter<br>-----------------<br>Peter Dufault<br>HD Associates, Inc. Software and System Engineering</span></font></div><div style="word-wrap:break-word"><font class="m_3247549097554731865Apple-style-span" size="3"><span class="m_3247549097554731865Apple-style-span" style="font-size:12px"><br></span></font></div>This email is delivered through the public internet using protocols subject to interception and tampering.</span></div></span></div></div></div></div></div></div></div></div></div>
</div>
<br></div></blockquote></div>