<div dir="ltr"><div>Okay<br></div><div>Just want to confirm, testsuite is fine now?</div><div><br></div><div>Vaibhav Gupta<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 14, 2019 at 12:28 AM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019, 12:57 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div>Hi Vaibhav,<div dir="auto"><br></div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jun 13, 2019, 11:51 AM Vaibhav Gupta <<a href="mailto:vaibhavgupta40@gmail.com" rel="noreferrer" target="_blank">vaibhavgupta40@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Remove comments on variable declaration.<br>
Remove licence from Doc<br>
Correct the assert condition for wcstoimax for negative errange condition.<br>
---<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Please squash (git-rebase) the commits to make one, new commit with only the necessary code. Send the new commit as -v2 patch. Thanks</div></div></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Sorry, not -v2, you can use -v3 again for the squashed commit. Use -i flag to git-rebase. Ask if you need further guidance</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
testsuites/psxtests/psxinttypes01/init.c | 26 +++++++++---------<br>
.../psxtests/psxinttypes01/psxinttypes01.doc | 27 -------------------<br>
2 files changed, 13 insertions(+), 40 deletions(-)<br>
<br>
diff --git a/testsuites/psxtests/psxinttypes01/init.c b/testsuites/psxtests/psxinttypes01/init.c<br>
index 8eafae11ac..94df8206c0 100644<br>
--- a/testsuites/psxtests/psxinttypes01/init.c<br>
+++ b/testsuites/psxtests/psxinttypes01/init.c<br>
@@ -52,16 +52,16 @@ rtems_task Init(rtems_task_argument ignored)<br>
int base = 10;<br>
int invalid_base = 40;<br>
<br>
- char *nptr1_p = "123abc"; //char* pointing to string with positive number<br>
- char *nptr1_p_errange = "9999999999999999999999"; //char* pointing to string with positive number that is out of range<br>
- char *nptr1_n = "-123abc"; //char* pointing to string with negative number<br>
- char *nptr1_n_errange = "-9999999999999999999999"; //char* pointing to string with negative number that is out of range<br>
+ char *nptr1_p = "123abc";<br>
+ char *nptr1_p_errange = "9999999999999999999999";<br>
+ char *nptr1_n = "-123abc";<br>
+ char *nptr1_n_errange = "-9999999999999999999999";<br>
char *endptr1 = NULL;<br>
<br>
- wchar_t *nptr2_p = L"123junk"; //wchar_t* pointing to string with positive number<br>
- wchar_t *nptr2_p_errange = L"9999999999999999999999"; //wchar_t* pointing to string with positive number that is out of range<br>
- wchar_t *nptr2_n = L"-123junk"; //wchar_t* pointing to string with negative number<br>
- wchar_t *nptr2_n_errange = L"-9999999999999999999999"; //wchar_t* pointing to string with negative number that is out of range<br>
+ wchar_t *nptr2_p = L"123junk";<br>
+ wchar_t *nptr2_p_errange = L"9999999999999999999999";<br>
+ wchar_t *nptr2_n = L"-123junk";<br>
+ wchar_t *nptr2_n_errange = L"-9999999999999999999999";<br>
wchar_t *endptr2 = NULL;<br>
<br>
intmax_t result_strtoimax;<br>
@@ -69,7 +69,7 @@ rtems_task Init(rtems_task_argument ignored)<br>
<br>
TEST_BEGIN();<br>
<br>
- /*Test for strtoimax */<br>
+ /* Test for strtoimax */<br>
puts( "\nstrtoimax Testcases...." );<br>
puts( "Valid Inputs - Positive Number" );<br>
result_strtoimax = strtoimax( nptr1_p, &endptr1, base );<br>
@@ -105,7 +105,7 @@ rtems_task Init(rtems_task_argument ignored)<br>
rtems_test_assert( result_strtoimax == 0 );<br>
rtems_test_assert( errno == EINVAL );<br>
<br>
- /*Test for strtoumax */<br>
+ /* Test for strtoumax */<br>
puts( "\nstrtoumax Testcases...." );<br>
puts( "Valid Inputs - Positive Number" );<br>
result_strtoumax = strtoumax( nptr1_p, &endptr1, base ); <br>
@@ -141,7 +141,7 @@ rtems_task Init(rtems_task_argument ignored)<br>
rtems_test_assert( result_strtoumax == 0 );<br>
rtems_test_assert( errno == EINVAL );<br>
<br>
- /*Test for wcstoimax */<br>
+ /* Test for wcstoimax */<br>
puts( "\nwcstoimax Testcases...." );<br>
puts( "Valid Inputs - Positive Number" );<br>
result_strtoimax = wcstoimax( nptr2_p, &endptr2, base );<br>
@@ -164,7 +164,7 @@ rtems_task Init(rtems_task_argument ignored)<br>
<br>
puts( "Valid Input - Negative Number - Number out of Range" );<br>
result_strtoimax = wcstoimax( nptr2_n_errange, &endptr2, base );<br>
- rtems_test_assert( result_strtoimax != 0 );<br>
+ rtems_test_assert( result_strtoimax == INTMAX_MIN );<br>
rtems_test_assert( errno == ERANGE );<br>
<br>
puts( "Invalid Input - Send NULL Pointer" );<br>
@@ -177,7 +177,7 @@ rtems_task Init(rtems_task_argument ignored)<br>
rtems_test_assert( result_strtoimax == 0 );<br>
rtems_test_assert( errno == EINVAL );<br>
<br>
- /*Test for wcstoumax */<br>
+ /* Test for wcstoumax */<br>
puts( "\nwcstoumax Testcases...." );<br>
puts( "Valid Inputs - Positive Number" );<br>
result_strtoumax = wcstoumax( nptr2_p, &endptr2, base );<br>
diff --git a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc<br>
index b5fd8e6d0e..607d67015e 100644<br>
--- a/testsuites/psxtests/psxinttypes01/psxinttypes01.doc<br>
+++ b/testsuites/psxtests/psxinttypes01/psxinttypes01.doc<br>
@@ -1,30 +1,3 @@<br>
-/*<br>
- * SPDX-License-Identifier: BSD-2-Clause<br>
- *<br>
- * Copyright (C) 2019, Vaibhav Gupta<br>
- *<br>
- * Redistribution and use in source and binary forms, with or without<br>
- * modification, are permitted provided that the following conditions<br>
- * are met:<br>
- * 1. Redistributions of source code must retain the above copyright<br>
- * notice, this list of conditions and the following disclaimer.<br>
- * 2. Redistributions in binary form must reproduce the above copyright<br>
- * notice, this list of conditions and the following disclaimer in the<br>
- * documentation and/or other materials provided with the distribution.<br>
- *<br>
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"<br>
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br>
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE<br>
- * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE<br>
- * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR<br>
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF<br>
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS<br>
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN<br>
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)<br>
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE<br>
- * POSSIBILITY OF SUCH DAMAGE.<br>
- */<br>
-<br>
This File describes the concepts tested by this test suite.<br>
<br>
inttypes.h - fixed size integer types<br>
-- <br>
2.21.0<br>
<br>
</blockquote></div></div></div>
</blockquote></div></div></div>
</blockquote></div>