<div dir="ltr">Hi<div><br></div><div>Now pushed. Thanks.</div><div><br></div><div>I finally got a local sparc tool chain built with the git master of newlib to build and run this test. It was a bit more complicated than I expected.</div><div><br></div><div>I did add a bit of logic to the psxtests <a href="http://configure.ac">configure.ac</a> and Makefile.am to ensure the test was not built unless the toolset included <ndbm.h>. This ensures that builds don't break when the toolset doesn't include it and that git bisect will continue to work.</div><div><br></div><div>The RSB will need to be bumped to the git master once the github mirror updates to include my push to libm.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 25, 2019 at 2:34 PM Joel Sherrill <<a href="mailto:joel@rtems.org">joel@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi<div><br></div><div>I just wanted to let everyone know that I have this pending on a branch and can build it using the current but there is a problem linking libm on the newlib git master. Once I have the RSB updated, I will look at pushing this.</div><div><br></div><div>To let Vaibhav continue pushing on fenv, if we decide the <a href="http://configure.ac" target="_blank">configure.ac</a> should check for the newly added dbm methods before building the test, I will merge that into the patch.</div><div><br></div><div>--joel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 23, 2019 at 8:42 AM Vaibhav Gupta <<a href="mailto:vaibhavgupta40@gmail.com" target="_blank">vaibhavgupta40@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
testsuites/psxtests/Makefile.am | 9 +<br>
testsuites/psxtests/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> | 1 +<br>
testsuites/psxtests/psxndbm01/init.c | 299 ++++++++++++++++++++<br>
testsuites/psxtests/psxndbm01/psxndbm01.doc | 36 +++<br>
testsuites/psxtests/psxndbm01/psxndbm01.scn | 29 ++<br>
5 files changed, 374 insertions(+)<br>
create mode 100644 testsuites/psxtests/psxndbm01/init.c<br>
create mode 100644 testsuites/psxtests/psxndbm01/psxndbm01.doc<br>
create mode 100644 testsuites/psxtests/psxndbm01/psxndbm01.scn<br>
<br>
diff --git a/testsuites/psxtests/Makefile.am b/testsuites/psxtests/Makefile.am<br>
index 59c9f2085b..36da591ccc 100755<br>
--- a/testsuites/psxtests/Makefile.am<br>
+++ b/testsuites/psxtests/Makefile.am<br>
@@ -694,6 +694,15 @@ psxmutexattr01_CPPFLAGS = $(AM_CPPFLAGS) $(TEST_FLAGS_psxmutexattr01) \<br>
$(support_includes) -I$(top_srcdir)/include<br>
endif<br>
<br>
+if TEST_psxndbm01<br>
+psx_tests += psxndbm01<br>
+psx_screens += psxndbm01/psxndbm01.scn<br>
+psx_docs += psxndbm01/psxndbm01.doc<br>
+psxndbm01_SOURCES = psxndbm01/init.c<br>
+psxndbm01_CPPFLAGS = $(AM_CPPFLAGS) $(TEST_FLAGS_psxndbm01) \<br>
+ $(support_includes)<br>
+endif<br>
+<br>
if TEST_psxobj01<br>
psx_tests += psxobj01<br>
psx_screens += psxobj01/psxobj01.scn<br>
diff --git a/testsuites/psxtests/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a> b/testsuites/psxtests/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
index 85559e4aa5..07d7ccaf55 100644<br>
--- a/testsuites/psxtests/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
+++ b/testsuites/psxtests/<a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
@@ -110,6 +110,7 @@ RTEMS_TEST_CHECK([psxmsgq02])<br>
RTEMS_TEST_CHECK([psxmsgq03])<br>
RTEMS_TEST_CHECK([psxmsgq04])<br>
RTEMS_TEST_CHECK([psxmutexattr01])<br>
+RTEMS_TEST_CHECK([psxndbm01])<br>
RTEMS_TEST_CHECK([psxobj01])<br>
RTEMS_TEST_CHECK([psxonce01])<br>
RTEMS_TEST_CHECK([psxpasswd01])<br>
diff --git a/testsuites/psxtests/psxndbm01/init.c b/testsuites/psxtests/psxndbm01/init.c<br>
new file mode 100644<br>
index 0000000000..a1eff4bd67<br>
--- /dev/null<br>
+++ b/testsuites/psxtests/psxndbm01/init.c<br>
@@ -0,0 +1,299 @@<br>
+/**<br>
+ * @file<br>
+ * @brief Test suite for ndbm.h methods<br>
+ */<br>
+<br>
+/*<br>
+ * SPDX-License-Identifier: BSD-2-Clause<br>
+ *<br>
+ * Copyright (C) 2019 Vaibhav Gupta<br>
+ *<br>
+ * Redistribution and use in source and binary forms, with or without<br>
+ * modification, are permitted provided that the following conditions<br>
+ * are met:<br>
+ * 1. Redistributions of source code must retain the above copyright<br>
+ * notice, this list of conditions and the following disclaimer.<br>
+ * 2. Redistributions in binary form must reproduce the above copyright<br>
+ * notice, this list of conditions and the following disclaimer in the<br>
+ * documentation and/or other materials provided with the distribution.<br>
+ *<br>
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"<br>
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE<br>
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE<br>
+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE<br>
+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR<br>
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF<br>
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS<br>
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN<br>
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)<br>
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE<br>
+ * POSSIBILITY OF SUCH DAMAGE.<br>
+ */<br>
+<br>
+#ifdef HAVE_CONFIG_H<br>
+#include "config.h"<br>
+#endif<br>
+<br>
+/* header files are listed in lexical/lexicographical/alphabetical order */<br>
+<br>
+#include <errno.h><br>
+#include <fcntl.h> /* contains definitions of 'open_flags' */<br>
+#include <limits.h><br>
+#include <ndbm.h> /* contains declarations of ndbm methods */<br>
+#include <stddef.h><br>
+#include <stdint.h><br>
+#include <stdio.h><br>
+#include <sys/stat.h> /* contains definitions of 'file_mode' */<br>
+#include <string.h><br>
+#include <rtems/test.h><br>
+#include <tmacros.h><br>
+<br>
+const char rtems_test_name[] = "PSXNDBM 01";<br>
+<br>
+#define NAME "VARoDeK"<br>
+#define PHONE_NO "123-321-777-888"<br>
+#define DB_NAME "phones_test"<br>
+#define NAME2 "VG"<br>
+#define PHONE_NO2 "321-123-888-777"<br>
+<br>
+/* forward declarations to avoid warnings */<br>
+rtems_task Init(rtems_task_argument ignored);<br>
+<br>
+/*<br>
+* This Function takes DBM* as a argument and count the number of records in the<br>
+* database pointed by it.<br>
+*/<br>
+static int count_no_of_records( DBM *db_local )<br>
+{<br>
+ int count = 0;<br>
+ datum temp;<br>
+<br>
+ for (<br>
+ temp = dbm_firstkey( db_local );<br>
+ temp.dptr != NULL;<br>
+ temp = dbm_nextkey( db_local ), count++<br>
+ );<br>
+ <br>
+ return count;<br>
+}<br>
+<br>
+/* Test Function Begins */<br>
+rtems_task Init(rtems_task_argument ignored)<br>
+{<br>
+ datum name = { NAME, sizeof( NAME ) };<br>
+ datum put_phone_no = { PHONE_NO, sizeof( PHONE_NO ) };<br>
+ datum name2 = { NAME2, sizeof( NAME2 ) };<br>
+ datum put_phone_no2 = { PHONE_NO2, sizeof( PHONE_NO2 ) };<br>
+<br>
+ datum get_phone_no, key;<br>
+ <br>
+ int i;<br>
+ char *test_strings;<br>
+<br>
+ DBM *db;<br>
+<br>
+ TEST_BEGIN();<br>
+<br>
+/* A Simple test to check if ndbm methods are call-able */<br>
+<br>
+/*<br>
+ * A Simple test to check if NDBM methods are call-able<br>
+ * <br>
+ * We will try to open a database and then close it.<br>
+ * If it successful, hence we can have further tests.<br>
+ * Also, while opening it for first time, will create that database,<br>
+ * hence we will be able to test for 'O_RDWR | O_EXCL' case later.<br>
+ * Meanwhile we will also store one record, this record will be helpful in<br>
+ * further tests.<br>
+ * And fetch it, to make sure if basic NDBM methods are working correctly.<br>
+ */<br>
+<br>
+ puts( "\nOpen Database." );<br>
+ db = dbm_open( DB_NAME, O_RDWR | O_CREAT | O_TRUNC, S_IRWXU );<br>
+ rtems_test_assert( db != NULL );<br>
+<br>
+ /* This data will be useful in further tests */<br>
+ puts( "Store Records in Database." );<br>
+ dbm_store( db, name, put_phone_no, DBM_INSERT );<br>
+<br>
+ puts( "Fetch Records from Database and check." );<br>
+ get_phone_no = dbm_fetch( db, name );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO ) == 0 );<br>
+<br>
+ puts( "Close Database." );<br>
+ dbm_close( db );<br>
+<br>
+/* dbm_open() */<br>
+<br>
+ puts( "\nTestcases for 'dbm_open()'." );<br>
+<br>
+/* The 'DB_NAME' is already created, hence 'O_RDWR | O_EXCL' should fail. */<br>
+ puts( "Use 'O_CREAT | O_EXCL' to open existing file and confirm error." );<br>
+ db = dbm_open( DB_NAME, O_RDWR | O_CREAT | O_EXCL, S_IRWXU );<br>
+ rtems_test_assert( db == NULL );<br>
+ rtems_test_assert( errno == EEXIST );<br>
+<br>
+/* Some implementations use 3 characters for the suffix and others use<br>
+ * 4 characters for the suffix, applications should ensure that the maximum<br>
+ * portable pathname length passed to dbm_open() is no greater than<br>
+ * {PATH_MAX}-4 bytes, with the last component of the pathname no greater<br>
+ * than {NAME_MAX}-4 bytes.<br>
+ */<br>
+<br>
+/* inside 'ndbm.h' ; '#define DBM_SUFFIX ".db"' ;<br>
+ * 2 alphabets and 1 period, hence 3 characters are used for suffix<br>
+ * in this implementation.<br>
+ */<br>
+<br>
+ puts( "Use path name larger than '{PATH_MAX}-3 bytes.' and confirm error." );<br>
+ test_strings = (char*)malloc( PATH_MAX - 2 );<br>
+ for ( i = 0; i < PATH_MAX - 3; i++ ) {<br>
+ test_strings[i] = 'r';<br>
+ }<br>
+ test_strings[i] = '\0';<br>
+ db = dbm_open( <br>
+ (const char*)test_strings,<br>
+ O_RDWR | O_CREAT | O_TRUNC,<br>
+ S_IRWXU<br>
+ );<br>
+ rtems_test_assert( db == NULL );<br>
+ rtems_test_assert( errno == ENAMETOOLONG );<br>
+ free( test_strings );<br>
+<br>
+/* database opened for write-only access opens the files for read and<br>
+ * write access or it will fail.<br>
+ */<br>
+<br>
+/* Implementation of __hash_open in newlib does not support `O_WRONLY` */<br>
+<br>
+ puts( "Open file with write access only and confirm error." );<br>
+ db = dbm_open( DB_NAME, O_WRONLY, S_IRWXU );<br>
+ rtems_test_assert( db == NULL );<br>
+ rtems_test_assert( errno == EINVAL );<br>
+<br>
+/* dbm_store() */<br>
+<br>
+ puts( "\nTestcases for 'dbm_store()'" );<br>
+ db = dbm_open( DB_NAME, O_RDWR, S_IRWXU );<br>
+ rtems_test_assert( db != NULL );<br>
+<br>
+ puts( "Insert new record with same key using 'DBM_INSERT' mode and "<br>
+ "confirm error." );<br>
+ rtems_test_assert( dbm_store( db, name, put_phone_no2, DBM_INSERT ) == 1 );<br>
+ <br>
+ get_phone_no = dbm_fetch( db, name );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO ) == 0 );<br>
+<br>
+ puts( "Insert new record with same key using 'DBM_REPLACE' mode and "<br>
+ "confirm changes." );<br>
+ rtems_test_assert( dbm_store( db, name, put_phone_no2, DBM_REPLACE ) == 0 );<br>
+ <br>
+ get_phone_no = dbm_fetch( db, name );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO2 ) == 0 );<br>
+<br>
+/* Revert for next tests */<br>
+ rtems_test_assert( dbm_store( db, name, put_phone_no, DBM_REPLACE ) == 0 );<br>
+<br>
+ puts( "Store a new record and "<br>
+ "confirm that total number of records is successful 2." );<br>
+ rtems_test_assert( dbm_store( db, name2, put_phone_no2, DBM_INSERT ) == 0 );<br>
+<br>
+/* Confirm number of records */<br>
+ rtems_test_assert( count_no_of_records( db ) == 2 );<br>
+<br>
+ dbm_close( db );<br>
+<br>
+/* dbm_fetch() */<br>
+<br>
+ puts( "\nTestcases for 'dbm_fetch()'" );<br>
+ db = dbm_open( DB_NAME, O_RDONLY, S_IRWXU );<br>
+ rtems_test_assert( db != NULL ); <br>
+<br>
+ puts( "Fetch existing records and confirm results." );<br>
+ get_phone_no = dbm_fetch( db, name );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO ) == 0 );<br>
+<br>
+ get_phone_no = dbm_fetch( db, name2 );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO2 ) == 0 );<br>
+<br>
+ puts( "Fetch non-existing record and confirm error." );<br>
+ test_strings = (char*)malloc(6);<br>
+ strncpy( test_strings, "Hello", 5 );<br>
+<br>
+ test_strings[5] = '\0';<br>
+ <br>
+/* The data pointed by test_string is now pointed by key.dptr */<br>
+ key.dptr = test_strings;<br>
+ key.dsize = sizeof( test_strings );<br>
+ get_phone_no = dbm_fetch( db, key );<br>
+ rtems_test_assert( get_phone_no.dptr == NULL );<br>
+ dbm_close( db );<br>
+<br>
+/* We need the 'key' object, hence we cannot free 'test_strings' */ <br>
+<br>
+/* dbm_delete() */<br>
+<br>
+ puts( "\nTestcases for 'dbm_delete()'" );<br>
+ db = dbm_open( DB_NAME, O_RDWR, S_IRWXU );<br>
+ rtems_test_assert( db != NULL ); <br>
+ <br>
+ puts( "Delete non-existing record and confirm error." );<br>
+ rtems_test_assert( dbm_delete( db, key ) != 0 );<br>
+ free( test_strings );<br>
+ rtems_test_assert( count_no_of_records( db ) == 2);<br>
+<br>
+ puts( "Delete existing record and "<br>
+ "confirm that total number of records is successful 1." );<br>
+ rtems_test_assert( dbm_delete( db, name ) == 0 );<br>
+ rtems_test_assert( count_no_of_records( db ) == 1);<br>
+<br>
+ puts( "Confirm if correct record is deleted." );<br>
+ get_phone_no = dbm_fetch( db, name );<br>
+ rtems_test_assert( get_phone_no.dptr == NULL );<br>
+<br>
+/* record returned by 'dbm_firstkey()' should be the only record<br>
+ * left, this should be checked to confirm correct working of<br>
+ * 'dbm_firstkey()'.<br>
+ * Check if the data is not corrupted after usage of 'dbm_delete()' <br>
+ */<br>
+ <br>
+ puts( "Check if the data is not corrupted after usage of 'dbm_delete()'." );<br>
+ get_phone_no = dbm_fetch( db, dbm_firstkey( db ) );<br>
+ rtems_test_assert( strcmp( (const char*)get_phone_no.dptr, PHONE_NO2 ) == 0 );<br>
+<br>
+/* Empty the database and then try to use 'dbm_firstkey()', the<br>
+ * dptr pointer should point to NULL.<br>
+ */<br>
+<br>
+ puts( "Empty records in database and check results of 'dbm_firstkey()'." );<br>
+ rtems_test_assert( dbm_delete( db, dbm_firstkey( db ) ) == 0 );<br>
+ key = dbm_firstkey( db );<br>
+ rtems_test_assert( key.dptr == NULL );<br>
+ dbm_close( db );<br>
+<br>
+/*<br>
+* All cases for 'dbm_firstkey()' and 'dbm_nextkey()' were tested while<br>
+* performing other tests.<br>
+* One such case be found in count_number_of_records() function.<br>
+*/<br>
+<br>
+ TEST_END();<br>
+ rtems_test_exit(0);<br>
+}<br>
+<br>
+/* NOTICE: the clock driver is explicitly disabled */<br>
+<br>
+#define CONFIGURE_APPLICATION_DOES_NOT_NEED_CLOCK_DRIVER<br>
+#define CONFIGURE_APPLICATION_NEEDS_CONSOLE_DRIVER<br>
+<br>
+#define CONFIGURE_MAXIMUM_TASKS 1<br>
+<br>
+#define CONFIGURE_LIBIO_MAXIMUM_FILE_DESCRIPTORS 6<br>
+<br>
+#define CONFIGURE_RTEMS_INIT_TASKS_TABLE<br>
+<br>
+#define CONFIGURE_INITIAL_EXTENSIONS RTEMS_TEST_INITIAL_EXTENSION<br>
+<br>
+#define CONFIGURE_INIT<br>
+#include <rtems/confdefs.h><br>
+/* end of file */<br>
diff --git a/testsuites/psxtests/psxndbm01/psxndbm01.doc b/testsuites/psxtests/psxndbm01/psxndbm01.doc<br>
new file mode 100644<br>
index 0000000000..cdaeb40911<br>
--- /dev/null<br>
+++ b/testsuites/psxtests/psxndbm01/psxndbm01.doc<br>
@@ -0,0 +1,36 @@<br>
+This File describes the concepts tested by this test suite.<br>
+<br>
+ndbm.h - routines to manage data files that contain key/data pairs.<br>
+<br>
+test suite name: PSXNDBM 01<br>
+<br>
+- A Simple test to check if NDBM methods are call-able.<br>
+ - Check if able to run the routine to Open Database.<br>
+ - Check if able to run the routine to store a record in database.<br>
+ - Check if able to run the routine to fetch a record from database.<br>
+ - Check if able to run the routine to close the database.<br>
+<br>
+- Test Cases for 'dbm_open()'.<br>
+ - Verify the error when trying to open existing file with 'O_RDWR | O_EXCL'<br>
+ flags.<br>
+ - Verify the error when trying to open file with pathname longer than<br>
+ {PATHMAX}-3 bytes.<br>
+ - Verify the error when trying to open file with only write access.<br>
+<br>
+- Test Cases for 'dbm_store()'.<br>
+ - Verify the error when trying to insert a record using same key with<br>
+ 'DBM_INSERT' mode.<br>
+ - Verify the updated record when trying to insert a record using same key<br>
+ with 'DBM_REPLACE' mode.<br>
+ - Verify if able to save more than one record in database.<br>
+<br>
+- Test Cases for 'dbm_fetch()'.<br>
+ - Verify the data fetched from database.<br>
+ - Verify the error when tring to fetch non-existing record.<br>
+<br>
+- Test Cases for 'dbm_delete()'.<br>
+ - Veriy the error when trying to delete non-existing record.<br>
+ - Delete one record and verify results.<br>
+ - Check if correct record is deleted.<br>
+ - Verify if other data is not corrupted during delete.<br>
+ - Empty the databse and verify the value returned by 'dbm_firstkey()'.<br>
\ No newline at end of file<br>
diff --git a/testsuites/psxtests/psxndbm01/psxndbm01.scn b/testsuites/psxtests/psxndbm01/psxndbm01.scn<br>
new file mode 100644<br>
index 0000000000..3fa386630a<br>
--- /dev/null<br>
+++ b/testsuites/psxtests/psxndbm01/psxndbm01.scn<br>
@@ -0,0 +1,29 @@<br>
+*** PSXNDBM 01 Test ***<br>
+<br>
+Open Database.<br>
+Store Records in Database.<br>
+Fetch Records from Database and check.<br>
+Close Database.<br>
+<br>
+Testcases for 'dbm_open()'.<br>
+Use 'O_CREAT | O_EXCL' to open existing file and confirm error.<br>
+Use path name larger than '{PATH_MAX}-3 bytes.' and confirm error.<br>
+Open file with write access only and confirm error.<br>
+<br>
+Testcases for 'dbm_store()'<br>
+Insert new record with same key using 'DBM_INSERT' mode and confirm error.<br>
+Insert new record with same key using 'DBM_REPLACE' mode and confirm changes.<br>
+Store a new record and confirm that total number of records is successful 2.<br>
+<br>
+Testcases for 'dbm_fetch()'<br>
+Fetch existing records and confirm results.<br>
+Fetch non-existing record and confirm error.<br>
+<br>
+Testcases for 'dbm_delete()'<br>
+Delete non-existing record and confirm error.<br>
+Delete existing record and confirm that total number of records is successful 1.<br>
+Confirm if correct record is deleted.<br>
+Check if the data is not corrupted after usage of 'dbm_delete()'.<br>
+Empty records in database and check results of 'dbm_firstkey()'.<br>
+<br>
+*** END OF TEST PSXNDBM 01 ***<br>
\ No newline at end of file<br>
-- <br>
2.21.0<br>
<br>
</blockquote></div>
</blockquote></div>