<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 16, 2019 at 8:16 PM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Vaibhav,<br>
<br>
The use of the -vX is to differentiate patches that are sent to review<br>
on the mailing list.</blockquote><div>Yeah, actually I assumed that working on different branch may</div><div>allow us to send patches like this.<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> If this is not clear in our contributing<br>
guidelines, we probably need to improve the description...<br>
<br>
On Fri, Aug 16, 2019 at 8:32 AM Vaibhav Gupta <<a href="mailto:vaibhavgupta40@gmail.com" target="_blank">vaibhavgupta40@gmail.com</a>> wrote:<br>
><br>
> Sure,<br>
> Actually made this patch on different branch so used -v1.<br>
> Sending a new one with -v2.<br>
><br>
> -Vaibhav<br>
><br>
> On Fri, Aug 16, 2019, 7:58 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br>
>><br>
>> Then this should be sent with -v2.<br>
>><br>
>> On Thu, Aug 15, 2019 at 1:33 PM Vaibhav Gupta <<a href="mailto:vaibhavgupta40@gmail.com" target="_blank">vaibhavgupta40@gmail.com</a>> wrote:<br>
>> ><br>
>> ><br>
>> ><br>
>> > On Thu, Aug 15, 2019 at 8:51 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br>
>> >><br>
>> >> Is this a duplicate of the other "patch v1 Add steps to test Newlib patch." or this one replaces it?<br>
>> ><br>
>> > This one replaces it. Actually I replaced all the previous ones with mine.<br>
>> > The commands, steps I have written are based on what worked for me for number of times.<br>
>> > I build the toolchain twice when RSB got updated, but my changes were not pushed so had to<br>
>> > use patches in RSB. And these steps worked perfectly both times.<br>
>> ><br>
>> > -Vaibhav<br>
>> >><br>
>> >><br>
>> >> On Wed, Aug 14, 2019 at 11:45 PM Vaibhav Gupta <<a href="mailto:vaibhavgupta40@gmail.com" target="_blank">vaibhavgupta40@gmail.com</a>> wrote:<br>
>> >>><br>
>> >>> Update the checksum to be used for the Newlib patches.<br>
>> >>> Earlier it was msd5, but it is depreciated for security<br>
>> >>> reasons. Now RSB accepts sha512.<br>
>> >>> ---<br>
>> >>> user/rsb/project-sets.rst | 41 +++++++++++++++++++++++++++++++++------<br>
>> >>> 1 file changed, 35 insertions(+), 6 deletions(-)<br>
>> >>><br>
>> >>> diff --git a/user/rsb/project-sets.rst b/user/rsb/project-sets.rst<br>
>> >>> index 5ffce26..b01857e 100644<br>
>> >>> --- a/user/rsb/project-sets.rst<br>
>> >>> +++ b/user/rsb/project-sets.rst<br>
>> >>> @@ -261,17 +261,46 @@ in the ``source-builder/config`` template configuration files.<br>
>> >>> To test a patch simply copy it to your local ``patches`` directory. The RSB<br>
>> >>> will see the patch is present and will not attempt to download it. Once you are<br>
>> >>> happy with the patch submit it to the project and a core developer will review<br>
>> >>> -it and add it to the RTEMS Tools git repository. For example, to test a local<br>
>> >>> -patch for newlib, add the following two lines to the .cfg file in<br>
>> >>> -``rtems/config/tools/`` that is included by the bset you use:<br>
>> >>> +it and add it to the RTEMS Tools git repository.<br>
>> >>> +<br>
>> >>> +Testing a Newlib Patch<br>
>> >>> +~~~~~~~~~~~~~~~~~~~~~~<br>
>> >>> +<br>
>> >>> +To test a local patch for newlib, you need to add the following<br>
>> >>> +two lines to the ``.cfg`` file in ``rsb/rtems/config/tools/`` that is included<br>
>> >>> +by the bset you use:<br>
>> >>> +<br>
>> >>> +.. topic:: Steps:<br>
>> >>> +<br>
>> >>> + 1. Create patches for the changes you want to test. (Note: For RSB, before<br>
>> >>> + creating Newlib patch, you must run ``autoreconf -fvi`` in the required<br>
>> >>> + directory after you make changes to the code. This is not required when<br>
>> >>> + you create patch to send to ``newlib-devel``. But if you want RSB to<br>
>> >>> + address your changes, your patch should also include regenerated files.)<br>
>> >>> +<br>
>> >>> + 2. Calculate ``sha512`` of your patch.<br>
>> >>> +<br>
>> >>> + 3. Place the patches in ``rsb/rtems/patches`` directory.<br>
>> >>> +<br>
>> >>> + 4. Open the ``.bset`` file used by your BSP in ``rsb/rtems/config``.<br>
>> >>> + For example, for ``rtems5``, ``SPARC``, the file will be<br>
>> >>> + ``rsb/rtems/config/5/rtems-sparc.bset``.<br>
>> >>> +<br>
>> >>> + 5. Inside it you will find the name of ``.cfg`` file for Newlib, used by<br>
>> >>> + your BSP.<br>
>> >>> + For example, I found ``tools/rtems-gcc-7.4.0-newlib-1d35a003f``.<br>
>> >>> +<br>
>> >>> + 6. Edit your ``.cfg`` file. In my case it will be,<br>
>> >>> + ``rsb/rtems/config/tools/rtems-gcc-7.4.0-newlib-1d35a003f.cfg``. And<br>
>> >>> + add the information about your patch as mentioned below.<br>
>> >>><br>
>> >>> .. code-block:: spec<br>
>> >>><br>
>> >>> - %patch add newlib file://0001-this-is-a-newlib-patch.patch <1><br>
>> >>> - %hash md5 0001-this-is-a-newlib-patch.diff 77d070878112783292461bd6e7db17fb <2><br>
>> >>> + %patch add newlib -p1 file://0001-Port-ndbm.patch <1><br>
>> >>> + %hash sha512 0001-Port-ndbm.patch 7d999ceeea4f3dc82e8e0aadc09d983a7a68b44470da8a3d61ab6fc558fdba6f2c2de3acc2f32c0b0b97fcc9ab799c27e87afe046544a69519881f947e7881d1 <2><br>
>> >>><br>
>> >>> .. topic:: Items:<br>
>> >>><br>
>> >>> 1. The diff file prepended with ``file://`` to tell RSB this is a local file.<br>
>> >>><br>
>> >>> - 2. The output from md5sum on the diff file.<br>
>> >>> + 2. The output from sha512sum on the patch file.<br>
>> >>><br>
>> >>> --<br>
>> >>> 2.21.0<br>
>> >>> _______________________________________________<br>
>> >>> devel mailing list<br>
>> >>> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>> >>> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>