<div dir="ltr"><div dir="ltr">On Fri, Jan 3, 2020 at 7:32 PM Vijay Kumar Banerjee <<a href="mailto:vijaykumar9597@gmail.com">vijaykumar9597@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>Hi Niteesh,</div><div>A few formatting suggestions:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
diff --git a/bsps/arm/raspberrypi/console/console-config.c b/bsps/arm/raspberrypi/console/console-config.c<br>
index d2186c918b..4000fd1c50 100644<br>
--- a/bsps/arm/raspberrypi/console/console-config.c<br>
+++ b/bsps/arm/raspberrypi/console/console-config.c<br>
@@ -19,50 +19,132 @@<br>
  */<br>
<br>
 #include <rtems/bspIo.h><br>
-<br>
-#include <libchip/serial.h><br></blockquote><div>You removed it here and added it below</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+#include <rtems/console.h><br>
+#include <rtems/sysinit.h><br>
<br>
 #include <bspopts.h><br>
-#include <bsp/irq.h><br>
-#include <bsp/usart.h><br></blockquote><div>same here </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+#include <bsp.h><br>
 #include <bsp/raspberrypi.h><br>
+#include <bsp/usart.h><br></blockquote><div>added here ^ </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+#include <bsp/arm-pl011.h><br>
 #include <bsp/fbcons.h><br>
+#include <bsp/console-termios.h><br>
+#include <bsp/fdt.h><br>
+#include <bsp/fatal.h><br>
+<br>
+#include <libfdt.h><br>
+#include <libchip/serial.h> </blockquote><div>here</div></div></div></blockquote><div>Is there any particular reason for doing it, or is it just a preference? </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>This is just a small change and I would suggest you wait for at least a day</div><div>before sending a v2 of the patch so that you can add changes suggested</div><div>by other people (if any). Congrats on getting it working ;-)</div></div></div></blockquote><div>Thank you. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div>Best,</div><div>Vijay </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br>
+#define UART0     "/dev/ttyS0"<br>
+#define FBCONS    "/dev/fbcons"<br>
+<br>
</blockquote></div></div>
</blockquote></div></div>