<div dir="ltr">I don't know. There are checks for other things in the function when it return other than successful.<div><br></div><div>Since it was never going to return "RTEMS_UNSATISFIED" as the "if" would always evaluate to true I removed the unnecessary comparison</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Feb 29, 2020 at 2:52 AM Peter Dufault <<a href="mailto:dufault@hda.com">dufault@hda.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">And regardless of the value of count it is successful?<br>
<br>
> On Feb 28, 2020, at 12:17 , suyash singh <<a href="mailto:suyashsingh234@gmail.com" target="_blank">suyashsingh234@gmail.com</a>> wrote:<br>
> <br>
> count is unsigned int and will always be >=0. <br>
> <br>
> On Fri, Feb 28, 2020 at 10:42 PM suyash singh <<a href="mailto:suyashsingh234@gmail.com" target="_blank">suyashsingh234@gmail.com</a>> wrote:<br>
> ---<br>
>  bsps/shared/grlib/1553/b1553brm.c | 6 ++----<br>
>  1 file changed, 2 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/bsps/shared/grlib/1553/b1553brm.c b/bsps/shared/grlib/1553/b1553brm.c<br>
> index 57ef70126b..4041423541 100644<br>
> --- a/bsps/shared/grlib/1553/b1553brm.c<br>
> +++ b/bsps/shared/grlib/1553/b1553brm.c<br>
> @@ -982,10 +982,8 @@ static rtems_device_driver brm_write(rtems_device_major_number major, rtems_devi<br>
> <br>
>         rw_args->bytes_moved = count; <br>
> <br>
> -       if (count >= 0) {<br>
> -               return RTEMS_SUCCESSFUL;<br>
> -       }<br>
> -       return RTEMS_UNSATISFIED;<br>
> +       return RTEMS_SUCCESSFUL;<br>
> +<br>
>  }<br>
> <br>
>  static rtems_device_driver brm_control(rtems_device_major_number major, rtems_device_minor_number minor, void *arg)<br>
> -- <br>
> 2.17.1<br>
> <br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
<br>
Peter<br>
-----------------<br>
Peter Dufault<br>
HD Associates, Inc.      Software and System Engineering<br>
<br>
This email is delivered through the public internet using protocols subject to interception and tampering.<br>
<br>
</blockquote></div>