<div dir="ltr">I still don't see why you need the includes. I just posted (
<a href="https://lists.rtems.org/pipermail/devel/2020-March/058176.html">https://lists.rtems.org/pipermail/devel/2020-March/058176.html</a> ) what I think is a complete implementation of this method. It assumes that the thread Id does not overlap the valid clockid's which I am pretty sure is true. Then clock_gettime just needs to (1) treat CLOCK_THREAD_CPUTIME_ID as a get execution time of executing thread. And (2) if it is a valid thread id, then return the executing time of that thread.<div><br></div><div>There is an example program in the Linux man page for pthread_getcpuclockid() which should work based on what I am describing plus the code I posted.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 12, 2020 at 2:58 PM Eshan Dhawan <<a href="mailto:eshandhawan51@gmail.com">eshandhawan51@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Link to the new patch : <a href="https://lists.rtems.org/pipermail/devel/2020-March/058174.html" target="_blank">https://lists.rtems.org/pipermail/devel/2020-March/058174.html</a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 13, 2020 at 1:19 AM Eshan Dhawan <<a href="mailto:eshandhawan51@gmail.com" target="_blank">eshandhawan51@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 13, 2020 at 12:57 AM Joel Sherrill <<a href="mailto:joel@rtems.org" target="_blank">joel@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Why did you need to add the include? Per
<a href="https://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_getcpuclockid.html" target="_blank">https://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_getcpuclockid.html</a>, you should only have to include pthread.h and time.h to have access to the types needed.</div></blockquote><div>I tried to access clockid_t but it wasn't included in the file so then I looked for the clockid_t definition it was in sys/types.h so I included that though the file also has no inclusion of time.h as well <br></div><div>I should include that and send a Patch <br></div><div><br></div><div>--eshan <br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>--joel</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 12, 2020 at 1:22 PM Eshan Dhawan <<a href="mailto:eshandhawan51@gmail.com" target="_blank">eshandhawan51@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div>Hello <br>I sent this patch a few days ago but no one reviewed it.<br></div>If someone could look into it and give feedback.<br><br></div>patch link: <a href="https://lists.rtems.org/pipermail/devel/2020-March/058044.html" target="_blank">https://lists.rtems.org/pipermail/devel/2020-March/058044.html</a></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Mar 6, 2020 at 7:50 PM Eshan dhawan <<a href="mailto:eshandhawan51@gmail.com" target="_blank">eshandhawan51@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">---<br>
cpukit/posix/src/pthreadgetcpuclockid.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/cpukit/posix/src/pthreadgetcpuclockid.c b/cpukit/posix/src/pthreadgetcpuclockid.c<br>
index cd7814b1a6..159a3f9791 100644<br>
--- a/cpukit/posix/src/pthreadgetcpuclockid.c<br>
+++ b/cpukit/posix/src/pthreadgetcpuclockid.c<br>
@@ -22,7 +22,7 @@<br>
<br>
#include <pthread.h><br>
#include <errno.h><br>
-<br>
+#include <sys/types.h><br>
#include <rtems/seterr.h><br>
<br>
int pthread_getcpuclockid(<br>
-- <br>
2.17.1<br>
<br>
</blockquote></div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote></div>
</blockquote></div></div>
</blockquote></div>
</blockquote></div>