<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 3, 2020 at 8:48 AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
  
    
  
  <div>
    <p>On 02/04/2020 22:28, Joel Sherrill wrote:<br>
    </p>
    <blockquote type="cite">
      
      <div dir="ltr">
        <div dir="ltr"><br>
        </div>
        <br>
        <div class="gmail_quote">
          <div dir="ltr" class="gmail_attr">On Thu, Apr 2, 2020 at 9:47
            AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>>
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 02/04/2020 16:45,
            Gedare Bloom wrote:<br>
            <br>
            > Can we hold this until 6?<br>
            Joel complained that the
            CONFIGURE_USE_DEVFS_AS_BASE_FILESYSTEM is <br>
            broken. For me it is not important.<br>
          </blockquote>
          <div><br>
          </div>
          <div>If this fixes that, please push it.</div>
        </div>
      </div>
    </blockquote>
    <p>The same technique needs to be applied to all drivers of this
      kind:</p>
    <p>bsps/arm/atsam/console/console.c:      link(&usart[0],
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/atsam/console/console.c:      link(&uart[0],
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/imx/console/console-config.c:      link(path,
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/xilinx-zynqmp/console/console-config.c:     
      link(&uart[0], CONSOLE_DEVICE_NAME);<br>
      bsps/arm/raspberrypi/console/console-config.c:        link(FBCONS,
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/raspberrypi/console/console-config.c:      link(MINIUART,
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/raspberrypi/console/console-config.c:      link(PL011,
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/raspberrypi/console/console-config.c:    link(PL011,
      CONSOLE_DEVICE_NAME);<br>
      bsps/arm/xilinx-zynq/console/console-init.c:      (void)
      link(CONSOLE_DEVICE_NAME, &uart[0]);<br>
      bsps/riscv/riscv/console/console-config.c:    link(htif_path,
      CONSOLE_DEVICE_NAME);<br>
      bsps/riscv/riscv/console/console-config.c:      link(path,
      CONSOLE_DEVICE_NAME);<br>
      bsps/riscv/riscv/console/console-config.c:    link(fe310_path,
      CONSOLE_DEVICE_NAME);<br>
      bsps/m68k/mrm332/console/console.c:  if ( link( "/dev/sci",
      "/dev/console") < 0 )<br>
      bsps/powerpc/tqm8xx/console/console.c:  rv = link(tty_name,
      CONSOLE_DEVICE_NAME);</p></div></blockquote><div><br></div><div>OK. But in your patch, you swapped the first and second arguments to link, why?</div><div><br></div><div><br>-        if ( link( ctx->device_file, CONSOLE_DEVICE_NAME ) != 0 ) {<br>-          bsp_fatal( BSP_FATAL_CONSOLE_INSTALL_1 );<br>-        }<br>+        (void) link( CONSOLE_DEVICE_NAME, ctx->device_file ); </div><div><br></div><div>The code you cited on mrm332 is disabled.<br></div><div><br></div><div>I also can't cipher the exact change. What is the change? </div><div><br></div><div>Worse, I don't have access to nearly any of those to test. </div><div><br></div><div>Ignoring time constraints, I don't understand the change enough to</div><div>make it, and don't have time. </div><div><br></div><div>You understand it and it should be mechanical. There are only 7 BSPs there</div><div>and I think you or Christian created or have worked on most of them. Please</div><div>just you two split the list and do it. You will have it done before I understand</div><div>the change.</div><div><br></div><div>--joel</div></div></div>