<div dir="auto">Is the dtc version in spike hardcoded? If so would you update it to use the dtc redirect instead?</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 8, 2020, 4:18 AM Hesham Almatary <<a href="mailto:hesham.almatary@cl.cam.ac.uk">hesham.almatary@cl.cam.ac.uk</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Joel and Christian,<br>
<br>
Thanks for your review.<br>
<br>
Spike bset was already using dtc-1.4.1. I submitted patches to bump<br>
dtc.bset itself. Are there any other patches I should apply?<br>
<br>
Cheers,<br>
Hesham<br>
<br>
On Wed, 8 Apr 2020 at 10:18, Christian Mauderer <<a href="mailto:oss@c-mauderer.de" target="_blank" rel="noreferrer">oss@c-mauderer.de</a>> wrote:<br>
><br>
> Hello Hesham and Joel,<br>
><br>
> On 07/04/2020 16:01, Joel Sherrill wrote:<br>
> > Please apply your Christian's and your patch.<br>
><br>
> I haven't created a patch for 1.4 yet. But it's quite straightforward.<br>
> So maybe just create one instead of applying mine.<br>
><br>
> Best regards<br>
><br>
> Christian<br>
><br>
> ><br>
> > Also bump the dtc base package version number.<br>
> ><br>
> > I thought we settled on 1.4.<br>
> ><br>
> > --joel<br>
> ><br>
> > On Tue, Apr 7, 2020 at 3:56 AM Hesham Almatary<br>
> > <<a href="mailto:Hesham.Almatary@cl.cam.ac.uk" target="_blank" rel="noreferrer">Hesham.Almatary@cl.cam.ac.uk</a> <mailto:<a href="mailto:Hesham.Almatary@cl.cam.ac.uk" target="_blank" rel="noreferrer">Hesham.Almatary@cl.cam.ac.uk</a>>> wrote:<br>
> ><br>
> >     * There is no all$ target in Spike<br>
> >     * There is no longer --with-fesvr flag since fesvr is source-inlined<br>
> >     by default<br>
> >     ---<br>
> >      source-builder/config/spike-1-1.cfg | 5 ++---<br>
> >      1 file changed, 2 insertions(+), 3 deletions(-)<br>
> ><br>
> >     diff --git a/source-builder/config/spike-1-1.cfg<br>
> >     b/source-builder/config/spike-1-1.cfg<br>
> >     index 760e1cc..e731348 100644<br>
> >     --- a/source-builder/config/spike-1-1.cfg<br>
> >     +++ b/source-builder/config/spike-1-1.cfg<br>
> >     @@ -37,10 +37,9 @@ URL:<br>
> >     <a href="https://github.com/riscv/riscv-isa-sim/" rel="noreferrer noreferrer" target="_blank">https://github.com/riscv/riscv-isa-sim/</a><br>
> >        cd ${source_dir_spike}<br>
> ><br>
> >        ./configure \<br>
> >     -    --prefix=%{_prefix} \<br>
> >     -    --with-fesvr=%{_prefix}<br>
> >     +    --prefix=%{_prefix}<br>
> ><br>
> >     -  %{__make} %{?_smp_mflags} all$<br>
> >     +  %{__make} %{?_smp_mflags}<br>
> ><br>
> >        cd ${build_top}<br>
> ><br>
> >     --<br>
> >     2.17.1<br>
> ><br>
> >     _______________________________________________<br>
> >     devel mailing list<br>
> >     <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a>><br>
> >     <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > devel mailing list<br>
> > <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> > <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> ><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>