<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 8, 2020 at 12:49 AM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Apr 7, 2020 at 12:03 PM Vijay Kumar Banerjee <<a href="mailto:vijay@rtems.org" target="_blank">vijay@rtems.org</a>> wrote:<br>
><br>
><br>
><br>
> On Tue, Apr 7, 2020 at 11:12 PM Joel Sherrill <<a href="mailto:joel@rtems.org" target="_blank">joel@rtems.org</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Tue, Apr 7, 2020 at 12:35 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br>
>>><br>
>>><br>
>>> I'm not sure what error this is fixing, is there a ticket open for the warning?<br>
>><br>
>><br>
>> No idea on this.<br>
>>><br>
>>><br>
>>> Is there a fix for the warning besides squelching it?<br>
>><br>
>><br>
>> I think these are the warnings that are build failures on some hosts. <I think><br>
><br>
><br>
> I get these errors on Fedora30:<br>
><br>
> ```<br>
> ../../glib-2.39.3/gio/gdbusauth.c: In function '_g_dbus_auth_run_server':<br>
> ../../glib-2.39.3/gio/gdbusauth.c:1297:11: error: '%s' directive argument is null [-Werror=format-overflow=]<br>
> 1297 | debug_print ("SERVER: WaitingForBegin, read '%s'", line);<br>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> ```<br>
> The added patches fix this.<br>
><br>
I see, this is a build error with newer gcc toolchains?</blockquote><div>Yes </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Is this only<br>
affecting qemu-couverture?</blockquote><div>yes, it's only affecting qemu-couverture </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> What version of gcc is your host using?</blockquote>$>gcc --version<br><div>gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Can<br>
you try to find if there is a ticket open in glib or if this is fixed<br>
in newer version, so we can track for the upstream fix?<br>
<br></blockquote><div>I found these patches from the bugzilla issue:</div><div><a href="https://bugzilla.gnome.org/show_bug.cgi?id=761550">https://bugzilla.gnome.org/show_bug.cgi?id=761550</a></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If newer versions of glib fix it, consider bumping the version?</blockquote><div>I'm getting these errors from glib-2.48.2 as well.</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Is<br>
qemu-couverture up-to-date?<br></blockquote><div>No, and it fails to build. There are issues in qemu-couverture as well. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
>>><br>
>>><br>
>>> How permanent is that gitlab? Should we just pluck these patches ourselves?<br>
>><br>
>><br>
>> That's <a href="http://gnome.gitlab.org" rel="noreferrer" target="_blank">gnome.gitlab.org</a> and per the link at <a href="https://www.gnome.org/gnome-3/source/" rel="noreferrer" target="_blank">https://www.gnome.org/gnome-3/source/</a>,<br>
>> it appears to be the official GNOME git repository. I think I would trust it.<br>
>><br>
>> --joel<br>
>><br>
>>><br>
>>><br>
>>> On Tue, Apr 7, 2020, 7:59 AM Vijay Kumar Banerjee <<a href="mailto:vijay@rtems.org" target="_blank">vijay@rtems.org</a>> wrote:<br>
>>>><br>
>>>> ---<br>
>>>> bare/config/devel/glib-2.39.3-1.cfg | 4 ++++<br>
>>>> 1 file changed, 4 insertions(+)<br>
>>>><br>
>>>> diff --git a/bare/config/devel/glib-2.39.3-1.cfg b/bare/config/devel/glib-2.39.3-1.cfg<br>
>>>> index 9ff7af5..bd5770a 100644<br>
>>>> --- a/bare/config/devel/glib-2.39.3-1.cfg<br>
>>>> +++ b/bare/config/devel/glib-2.39.3-1.cfg<br>
>>>> @@ -14,6 +14,10 @@<br>
>>>><br>
>>>> %hash sha256 glib-%{glib_version}.tar.xz d9fa6c9aa645a5e688a3bb29013bb83801b19ee767d99e33ff52e004e1cc5fc8<br>
>>>><br>
>>>> +#Patch to supress string literal warning<br>
>>>> +<br>
>>>> +%patch add glib <a href="https://gitlab.gnome.org/GNOME/glib/commit/0817af40e8c74c721c30f6ef482b1f53d12044c7.patch" rel="noreferrer" target="_blank">https://gitlab.gnome.org/GNOME/glib/commit/0817af40e8c74c721c30f6ef482b1f53d12044c7.patch</a><br>
>>>> +%patch add glib <a href="https://gitlab.gnome.org/GNOME/glib/commit/566e1d61a500267c7849ad0b2552feec9c9a29a6.patch" rel="noreferrer" target="_blank">https://gitlab.gnome.org/GNOME/glib/commit/566e1d61a500267c7849ad0b2552feec9c9a29a6.patch</a><br>
>>>> #<br>
>>>> # The GLib build instructions. We use 2.x.x Release 1.<br>
>>>> #<br>
>>>> --<br>
>>>> 2.21.1<br>
>>>><br>
>>>> _______________________________________________<br>
>>>> devel mailing list<br>
>>>> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>>>> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
>>><br>
>>> _______________________________________________<br>
>>> devel mailing list<br>
>>> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>>> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>