<div dir="ltr"><div class="gmail_default" style="font-size:small">This patch has been unnoticed for a while.</div><div class="gmail_default" style="font-size:small">If the lack of testing is what is stopping from pushing it I am happy</div><div class="gmail_default" style="font-size:small">to test it on real hardware.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">But I can't come up with a good methodology for testing it.</div><div class="gmail_default" style="font-size:small">My initial thoughts were to generate a GPIO interrupt with no ISR.</div><div class="gmail_default" style="font-size:small">This would cause the default ISR to be called. But I am not familiar</div><div class="gmail_default" style="font-size:small">with RTEMS interrupt mechanism so I don't know if this would work or not.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">If this is a wrong way to test it, then please let me know of the</div><div class="gmail_default" style="font-size:small">right way.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks,</div><div class="gmail_default" style="font-size:small">Niteesh.</div></div><div dir="ltr"><div class="gmail_default" style="font-size:small"></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 31, 2020 at 4:21 AM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This looks right but I'm not able to try it out.<br>
<br>
On Sat, Mar 28, 2020 at 12:24 PM G S Niteesh Babu <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>> wrote:<br>
><br>
> 1) _Memory_Initialize makes pointer from integer<br>
>         without a cast.<br>
> 2) printf format error, expects %u but %lu provided.<br>
> ---<br>
>  bsps/arm/raspberrypi/irq/irq.c             | 4 +++-<br>
>  bsps/arm/raspberrypi/start/bspstarthooks.c | 2 ++<br>
>  2 files changed, 5 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/bsps/arm/raspberrypi/irq/irq.c b/bsps/arm/raspberrypi/irq/irq.c<br>
> index 9e1bcfc1bc..835cdf97d9 100644<br>
> --- a/bsps/arm/raspberrypi/irq/irq.c<br>
> +++ b/bsps/arm/raspberrypi/irq/irq.c<br>
> @@ -32,6 +32,8 @@<br>
>  #include <rtems/bspIo.h><br>
>  #include <strings.h><br>
><br>
> +#include <rtems/inttypes.h><br>
> +<br>
>  #ifdef RTEMS_SMP<br>
>  #include <rtems/score/smp.h><br>
>  #include <rtems/score/smpimpl.h><br>
> @@ -157,7 +159,7 @@ void bsp_interrupt_vector_disable(rtems_vector_number vector)<br>
><br>
>  void bsp_interrupt_handler_default(rtems_vector_number vector)<br>
>  {<br>
> -    printk("spurious interrupt: %lu\n", vector);<br>
> +    printk("spurious interrupt: %" PRIdrtems_vector_number "\n", vector);<br>
>  }<br>
><br>
>  rtems_status_code bsp_interrupt_facility_initialize(void)<br>
> diff --git a/bsps/arm/raspberrypi/start/bspstarthooks.c b/bsps/arm/raspberrypi/start/bspstarthooks.c<br>
> index fd6aa53059..eb6546db1c 100644<br>
> --- a/bsps/arm/raspberrypi/start/bspstarthooks.c<br>
> +++ b/bsps/arm/raspberrypi/start/bspstarthooks.c<br>
> @@ -184,7 +184,9 @@ static void bsp_memory_initialize(void)<br>
>  {<br>
>    _Memory_Initialize(<br>
>      &_Memory_Areas[0],<br>
> +    (void *)<br>
>      raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].begin,<br>
> +    (void *)<br>
>      raspberrypi_mmu_config_table[ARMV7_CP15_START_WORKSPACE_ENTRY_INDEX].end<br>
>    );<br>
>  }<br>
> --<br>
> 2.17.1<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>