<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer <<a href="mailto:christian.mauderer@embedded-brains.de">christian.mauderer@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Vijay,<br>
<br>
On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:<br>
> Hi Christian,<br>
> <br>
> I'm not able to build libbsd with this patch. I'm getting the following<br>
> error:<br>
> ```<br>
> ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10: fatal error:<br>
> arm/freescale/imx/imx_ccmvar.h: No such file or directory<br>
> #include <arm/freescale/imx/imx_ccmvar.h><br>
> ```<br>
> From git blame I got to know that this file was introduced by the commit<br>
> from this patch.<br>
> Am I missing something or is it really a bug?<br>
<br>
Thanks for the report. On what BSP and which exact commit did you try to<br>
build? I had no trouble building the patch set from a clean checkout<br>
yesterday before committing it.<br>
<br></blockquote><div>I did a pull from the upstream master and tried the build on arm/beagleboneblack</div><div>I see that the header file is not present in the freebsd/ directory</div><div>```</div>rtems-libbsd $>find -iname imx_ccmvar.h<br>./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h<br><div>``` </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> <br>
> Sorry for commenting on the patch that has already been committed,<br>
> please let me know of<br>
> the preferred way to comment on a commit if this is not the right way.<br>
<br>
No problem. That's exactly the right way to do it. If there is a bug it<br>
has to be solved and everyone should know that someone is having a look<br>
at it.<br>
<br>
Best regards<br>
<br>
Christian<br>
<br>
> <br>
> <br>
> Best regards,<br>
> Vijay<br>
> On Tue, Apr 14, 2020 at 8:21 PM Christian Mauderer<br>
> <<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>>> wrote:<br>
> <br>
> ---<br>
> libbsd.py | 2 ++<br>
> rtemsbsd/include/bsp/nexus-devices.h | 5 +++++<br>
> 2 files changed, 7 insertions(+)<br>
> <br>
> diff --git a/libbsd.py b/libbsd.py<br>
> index 4f8fb4d2..ed6493b2 100644<br>
> --- a/libbsd.py<br>
> +++ b/libbsd.py<br>
> @@ -5028,6 +5028,8 @@ class imx(builder.Module):<br>
> self.addKernelSpaceSourceFiles(<br>
> [<br>
> 'sys/arm/freescale/imx/imx6_ccm.c',<br>
> + 'sys/arm/freescale/imx/imx6_usbphy.c',<br>
> + 'sys/dev/usb/controller/ehci_imx.c',<br>
> ],<br>
> mm.generator['source']()<br>
> )<br>
> diff --git a/rtemsbsd/include/bsp/nexus-devices.h<br>
> b/rtemsbsd/include/bsp/nexus-devices.h<br>
> index 0a210bd9..d2ceab8e 100644<br>
> --- a/rtemsbsd/include/bsp/nexus-devices.h<br>
> +++ b/rtemsbsd/include/bsp/nexus-devices.h<br>
> @@ -128,6 +128,11 @@ RTEMS_BSD_DEFINE_NEXUS_DEVICE(ofwbus, 0, 0, NULL);<br>
> SYSINIT_DRIVER_REFERENCE(simplebus, ofwbus);<br>
> <br>
> SYSINIT_DRIVER_REFERENCE(ccm, simplebus);<br>
> +SYSINIT_DRIVER_REFERENCE(ehci, simplebus);<br>
> +SYSINIT_DRIVER_REFERENCE(usbphy, simplebus);<br>
> +SYSINIT_DRIVER_REFERENCE(usbus, ehci);<br>
> +RTEMS_BSD_DRIVER_USB;<br>
> +RTEMS_BSD_DRIVER_USB_MASS;<br>
> <br>
> SYSINIT_DRIVER_REFERENCE(ffec, simplebus);<br>
> SYSINIT_DRIVER_REFERENCE(ukphy, miibus);<br>
> -- <br>
> 2.16.4<br>
> <br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> <br>
<br>
-- <br>
--------------------------------------------<br>
embedded brains GmbH<br>
Herr Christian Mauderer<br>
Dornierstr. 4<br>
D-82178 Puchheim<br>
Germany<br>
email: <a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
Phone: +49-89-18 94 741 - 18<br>
Fax: +49-89-18 94 741 - 08<br>
PGP: Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
</blockquote></div></div>