<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 16, 2020 at 2:08 PM Christian Mauderer <<a href="mailto:christian.mauderer@embedded-brains.de">christian.mauderer@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 16/04/2020 10:27, Vijay Kumar Banerjee wrote:<br>
> <br>
> <br>
> On Thu, Apr 16, 2020 at 1:51 PM Christian Mauderer<br>
> <<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>>> wrote:<br>
> <br>
> <br>
> <br>
> On 16/04/2020 09:41, Christian Mauderer wrote:<br>
> > On 16/04/2020 09:21, Vijay Kumar Banerjee wrote:<br>
> >><br>
> >><br>
> >> On Thu, Apr 16, 2020 at 12:41 PM Christian Mauderer<br>
> >> <<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>><br>
> >> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
> <mailto:<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a>>>> wrote:<br>
> >><br>
> >> Hello Vijay,<br>
> >><br>
> >> On 16/04/2020 09:04, Vijay Kumar Banerjee wrote:<br>
> >> > Hi Christian,<br>
> >> ><br>
> >> > I'm not able to build libbsd with this patch. I'm getting the<br>
> >> following<br>
> >> > error:<br>
> >> > ```<br>
> >> > ../../freebsd/sys/dev/usb/controller/ehci_imx.c:70:10:<br>
> fatal error:<br>
> >> > arm/freescale/imx/imx_ccmvar.h: No such file or directory<br>
> >> > #include <arm/freescale/imx/imx_ccmvar.h><br>
> >> > ```<br>
> >> > From git blame I got to know that this file was introduced<br>
> by the<br>
> >> commit<br>
> >> > from this patch.<br>
> >> > Am I missing something or is it really a bug?<br>
> >><br>
> >> Thanks for the report. On what BSP and which exact commit did<br>
> you try to<br>
> >> build? I had no trouble building the patch set from a clean<br>
> checkout<br>
> >> yesterday before committing it.<br>
> >><br>
> >> I did a pull from the upstream master and tried the build on<br>
> >> arm/beagleboneblack<br>
> >> I see that the header file is not present in the freebsd/ directory<br>
> >> ```<br>
> >> rtems-libbsd $>find -iname imx_ccmvar.h<br>
> >> ./freebsd-org/sys/arm/freescale/imx/imx_ccmvar.h<br>
> >> ```<br>
> ><br>
> > Hello Vijay,<br>
> ><br>
> > that's quite clearly a bug that I introduced. I'll create a patch.<br>
> ><br>
> > The imx_ccmvar.h is a file that is provided by the BSP I used for<br>
> testing.<br>
> ><br>
> > Best regards<br>
> ><br>
> > Christian<br>
> <br>
> I've sent a patch. Can you test it?<br>
> <br>
> Sure. I don't see the patch on the list yet, I'll test it as soon as it<br>
> comes :) <br>
<br>
Odd. It's already sent out and I CCd you directly. But the archive<br>
hasn't seen it either. To be sure, I attached the patch here.<br>
<br></blockquote><div>This patch fixed the issue and the build completes successfully. Thanks.</div><div>I'll also comment on the patch when it hits the list. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> <br>
> ><br>
> >><br>
> >> ><br>
> >> > Sorry for commenting on the patch that has already been<br>
> committed,<br>
> >> > please let me know of<br>
> >> > the preferred way to comment on a commit if this is not the<br>
> right way.<br>
> >><br>
> >> No problem. That's exactly the right way to do it. If there<br>
> is a bug it<br>
> >> has to be solved and everyone should know that someone is<br>
> having a look<br>
> >> at it.<br>
> >><br>
> >> Best regards<br>
> >><br>
> >> Christian<br>
> >><br>
[...]<br>
<br>
-- <br>
--------------------------------------------<br>
embedded brains GmbH<br>
Herr Christian Mauderer<br>
Dornierstr. 4<br>
D-82178 Puchheim<br>
Germany<br>
email: <a href="mailto:christian.mauderer@embedded-brains.de" target="_blank">christian.mauderer@embedded-brains.de</a><br>
Phone: +49-89-18 94 741 - 18<br>
Fax: +49-89-18 94 741 - 08<br>
PGP: Public key available on request.<br>
<br>
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.<br>
</blockquote></div></div>