<div dir="ltr"><div class="gmail_default" style="font-size:small">I have replied to the comment please have a look.</div><div class="gmail_default" style="font-size:small"><a href="https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754#r38841918">https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754#r38841918</a><br></div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks,</div><div class="gmail_default" style="font-size:small">Niteesh</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 30, 2020 at 5:58 AM Chris Johns <<a href="mailto:chrisj@rtems.org">chrisj@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">It looks like there is something wrong with the <a href="http://rtems.org" rel="noreferrer" target="_blank">rtems.org</a> mail lists. I <br>
have pinged Amar to have a look.<br>
<br>
On 30/4/20 4:45 am, Niteesh G. S. wrote:<br>
> Please have a look at this if you missed it previously. :)<br>
> <br>
> Thanks,<br>
> Niteesh.<br>
> <br>
> On Tue, Apr 28, 2020 at 11:30 PM Niteesh G. S. <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <br>
> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>>> wrote:<br>
> <br>
> This is my first time writing shell scripts. If something seems like<br>
> a hack or if there is a better of doing it. Please let me know.<br>
> <br>
> <a href="https://github.com/gs-niteesh/rtems-release/commit/70cbb5418ba68992a910844c3d6450ef4db17579" rel="noreferrer" target="_blank">https://github.com/gs-niteesh/rtems-release/commit/70cbb5418ba68992a910844c3d6450ef4db17579</a><br>
> <a href="https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754" rel="noreferrer" target="_blank">https://github.com/gs-niteesh/rtems-release/commit/58ed0cb3fc1f33f12de8e550979371a51e322754</a><br>
> <br>
> On Tue, Apr 28, 2020 at 3:51 PM Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a><br>
> <mailto:<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>>> wrote:<br>
> <br>
> On 28/4/20 6:26 pm, Niteesh G. S. wrote:<br>
> > On Tue, Apr 28, 2020 at 8:10 AM Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a><br>
> <mailto:<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>><br>
> > <mailto:<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a> <mailto:<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>>>> wrote:<br>
> ><br>
> > On 28/4/20 11:51 am, Niteesh G. S. wrote:<br>
> > ><br>
> ><br>
> <a href="https://github.com/gs-niteesh/rtems-release/commit/8666bcd66066512f91194660817cd42cbb8c76e9" rel="noreferrer" target="_blank">https://github.com/gs-niteesh/rtems-release/commit/8666bcd66066512f91194660817cd42cbb8c76e9</a><br>
> > > If it is okay for you, then I will send the patch to<br>
> the mailing<br>
> > list.<br>
> ><br>
> > The repos list is now just the package names and the<br>
> branch script<br>
> > as it<br>
> > is expects the repo name, i.e. .git at the end.<br>
> ><br>
> ><br>
> > How should I do this? Shall I iterate over all the repos in<br>
> rtems_repo<br>
> > variable<br>
> > and append '.git' to the end? This will happen right after the<br>
> > declaration of the<br>
> > variable.<br>
> <br>
> Yes this is fine.<br>
> <br>
> > Also the rtems-releases repo needs to be added to the<br>
> list of repos<br>
> > (and<br>
> > not packages).<br>
> ><br>
> > Done.<br>
> > We should avoid branching this repo, right?<br>
> <br>
> No lets branch it. We might as well be consistent in how we<br>
> manage repos<br>
> in the project. It makes procedures in the eng manual easier,<br>
> i.e. just<br>
> one procedure to cover them all.<br>
> <br>
> > I think it would be a good idea to be able to run this<br>
> script which<br>
> > means a way to switch the git clone from ssh to the git<br>
> protocol. I<br>
> > recently added command line support to rtems-release so I<br>
> suggest you<br>
> > borrow that code and add an option so you can switch the<br>
> git protocol<br>
> > and test. I would also add a switch to push, i.e. by<br>
> default a push is<br>
> > not done.<br>
> ><br>
> > Should we take the URL from the user similar to how it is<br>
> done in<br>
> > rtems-release<br>
> > or just ask if he wants to test? In this case, the user has<br>
> to just pass<br>
> > -t or something<br>
> > to cmd line and it would download the sources from<br>
> git://<a href="http://git.rtems.org/" rel="noreferrer" target="_blank">git.rtems.org/</a> <<a href="http://git.rtems.org/" rel="noreferrer" target="_blank">http://git.rtems.org/</a>><br>
> > <<a href="http://git.rtems.org/" rel="noreferrer" target="_blank">http://git.rtems.org/</a>><br>
> <br>
> Hmm lets start with an option to switch between the git and ssh<br>
> protocols. I cannot see a use case where there is a completely<br>
> different<br>
> location for the repos. If that does arise it can be sorted out<br>
> then.<br>
> <br>
> Chris<br>
> <br>
</blockquote></div>