<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jul 10, 2020, 12:11 AM Christian Mauderer <<a href="mailto:oss@c-mauderer.de">oss@c-mauderer.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello Vijay,<br>
<br>
thanks for the review and the test.<br>
<br>
On 09/07/2020 19:58, Vijay Kumar Banerjee wrote:<br>
> Hi,<br>
> <br>
> Thanks for the patch, I tested the patch and it's building fine. I<br>
> just had two questions which I have inlined below.<br>
> <br>
> On Thu, Jul 9, 2020 at 9:13 PM Christian Mauderer<br>
> <<a href="mailto:christian.mauderer@embedded-brains.de" target="_blank" rel="noreferrer">christian.mauderer@embedded-brains.de</a>> wrote:<br>
>><br>
>> ---<br>
>> lv_conf.h => default_lv_conf.h | 0<br>
>> lv_drv_conf.h => default_lv_drv_conf.h | 0<br>
>> lvgl.py | 19 ++++++++++++++++---<br>
>> wscript | 13 +++++++++++++<br>
>> 4 files changed, 29 insertions(+), 3 deletions(-)<br>
>> rename lv_conf.h => default_lv_conf.h (100%)<br>
>> rename lv_drv_conf.h => default_lv_drv_conf.h (100%)<br>
>><br>
>> diff --git a/lv_conf.h b/default_lv_conf.h<br>
>> similarity index 100%<br>
>> rename from lv_conf.h<br>
>> rename to default_lv_conf.h<br>
>> diff --git a/lv_drv_conf.h b/default_lv_drv_conf.h<br>
>> similarity index 100%<br>
>> rename from lv_drv_conf.h<br>
>> rename to default_lv_drv_conf.h<br>
>> diff --git a/lvgl.py b/lvgl.py<br>
>> index c154a5e..6d55db7 100644<br>
>> --- a/lvgl.py<br>
>> +++ b/lvgl.py<br>
>> @@ -73,6 +73,17 @@ def build(bld):<br>
>> includes.append('.')<br>
>> include_paths = []<br>
>><br>
>> + def write_stuff(stuff):<br>
>> + def stuff_writer(task):<br>
>> + task.outputs[0].write(stuff)<br>
>> + return stuff_writer<br>
>> +<br>
>> + lv_conf_h='lv_conf.h'<br>
>> + lv_drv_conf_h='lv_drv_conf.h'<br>
>> +<br>
>> + bld(rule=write_stuff(bld.env.LV_CONF), target=lv_conf_h)<br>
>> + bld(rule=write_stuff(bld.env.LV_DRV_CONF), target=lv_drv_conf_h)<br>
>> +<br>
>> for source in sources:<br>
>> source_dir = os.path.dirname(source)<br>
>> if source_dir not in include_paths:<br>
>> @@ -80,7 +91,7 @@ def build(bld):<br>
>><br>
>> bld.stlib(target = 'lvgl',<br>
>> features = 'c',<br>
>> - cflags = ['-O2', '-g'],<br>
>> + cflags = ['-O2', '-g', '-DLV_CONF_INCLUDE_SIMPLE'],<br>
>> includes = includes,<br>
>> source = sources)<br>
>><br>
>> @@ -96,6 +107,8 @@ def build(bld):<br>
>> for include_path in include_paths:<br>
>> files = os.listdir(include_path)<br>
>> include_headers = [os.path.join(include_path, x) for x in files if (x[-2:] == '.h')]<br>
>> - bld.install_files(os.path.join("${PREFIX}/" , arch_inc_path, include_path),<br>
>> + bld.install_files(os.path.join("${PREFIX}", arch_inc_path, include_path),<br>
>> include_headers)<br>
>> - bld.install_files('${PREFIX}/' + arch_lib_path, ["liblvgl.a"])<br>
>> + bld.install_files(os.path.join('${PREFIX}', arch_lib_path), ["liblvgl.a"])<br>
>> + bld.install_files(os.path.join('${PREFIX}', arch_inc_path, include_path),<br>
>> + [lv_conf_h])<br>
> <br>
> Should lv_drv_conf_h be installed as well?<br>
<br>
I haven't seen that it is used but I can install it too. I didn't test<br>
all drivers.<br></blockquote></div></div><div dir="auto">One use case would be to check if USE_BSD_FBDEV (Or some other driver) is defined. The example apps assumed that both evdev and fbdev is defined since the conf was fixed. I think they would need some check to ensure it is defined.</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
> <br>
>> diff --git a/wscript b/wscript<br>
>> index ae91daa..0e1a51d 100644<br>
>> --- a/wscript<br>
>> +++ b/wscript<br>
>> @@ -49,9 +49,22 @@ def options(opt):<br>
>> dest = "drivers",<br>
>> help = "Build without lv_drivers." +<br>
>> "Useful for building without libbsd.")<br>
>> + opt.add_option("--lv-conf",<br>
>> + default = "default_lv_conf.h",<br>
>> + dest = "lv_conf",<br>
>> + help = "Use a custom lv_conf.h instead of the default one.")<br>
>> + opt.add_option("--lv-drv-conf",<br>
>> + default = "default_lv_drv_conf.h",<br>
>> + dest = "lv_drv_conf",<br>
>> + help = "Use a custom lv_drv_conf.h instead of the default one.")<br>
>><br>
>> def configure(conf):<br>
>> conf.env.DRIVERS = conf.options.drivers<br>
>> + with open(conf.options.lv_conf, "rb") as lv_conf:<br>
>> + conf.env.LV_CONF = lv_conf.read()<br>
>> + with open(conf.options.lv_drv_conf, "rb") as lv_drv_conf:<br>
>> + conf.env.LV_DRV_CONF = lv_drv_conf.read()<br>
>> + conf.env.BUILDINCLUDE = 'build-include'<br>
> <br>
> It's not clear to me where is build-include being used. It builds fine<br>
> without this line, should it be removed from the patch?<br>
> <br>
<br>
That is a part of a dead end during writing the patch. I missed to<br>
remove it. Thanks for finding it.<br>
<br>
Best regards<br>
<br>
Christian<br>
<br>
> <br>
> Thanks for working on this feature, it was much needed.<br>
> <br>
> Best regards,<br>
> Vijay<br>
> <br>
>> rtems.configure(conf)<br>
>><br>
>> def build(bld):<br>
>> --<br>
>> 2.26.2<br>
>><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank" rel="noreferrer">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> <br>
</blockquote></div></div></div>