<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">Hello,</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Aug 30, 2020 at 4:12 PM Christian Mauderer <<a href="mailto:oss@c-mauderer.de">oss@c-mauderer.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Niteesh,<br>
<br>
On 30/08/2020 08:58, Niteesh G. S. wrote:<br>
> Hello,<br>
> <br>
> I have updated the blog to contain the links to the commits<br>
> instead of the branches. Please have a look again.<br>
> <a href="https://gs-niteesh.github.io/finalreport/" rel="noreferrer" target="_blank">https://gs-niteesh.github.io/finalreport/</a><br>
<br>
>From my point of view, it looks good now. You missed the commit with the<br>
refactored i2c driver:<br></blockquote><div><span class="gmail_default" style="font-size:small">Sorry about that. I fixed this.</span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<a href="https://github.com/gs-niteesh/rtems/commit/be9bd605c40cf7cbcf3f527054fdbab2af39f52a" rel="noreferrer" target="_blank">https://github.com/gs-niteesh/rtems/commit/be9bd605c40cf7cbcf3f527054fdbab2af39f52a</a><br>
<br>
But if you don't have time left it's not a problem if it isn't there.<br>
<br>
The Submission guidelines tell that "It must be easy to identify the<br>
work you have done." From my point of view that was already quite clear<br>
because the commits are all on top of the final branch. But Gedare is of<br>
course right: Linking every commit is a bit more clear.<br>
<br><br>
> And sorry to disturb on the weekend, but we have only about<br>
> a day left before the submission deadline, so I request<br>
> everyone to please take a look and let me know if you would<br>
> like to change anything.<br>
<br>
No problem for disturbing in this case. Don't miss your deadline. It's<br>
better to submit something that is not perfect than not submitting<br>
anything. We would have no possibility to fix a missed submission.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">I have to submit it before tomorrow 11:30 PM IST. I'll leave it tonight</div><div class="gmail_default" style="font-size:small">for others to comment and will fill it tomorrow morning.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Thanks,</div><div class="gmail_default" style="font-size:small">Niteesh.</div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Best regards<br>
<br>
Christian<br>
<br>
> <br>
> Thanks,<br>
> Niteesh.<br>
> <br>
> On Sun, Aug 30, 2020 at 2:24 AM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a><br>
> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>>> wrote:<br>
> <br>
> On Sat, Aug 29, 2020 at 8:31 AM Christian Mauderer<br>
> <<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>> wrote:<br>
> ><br>
> ><br>
> ><br>
> > On 29/08/2020 15:04, Niteesh G. S. wrote:<br>
> > > Hello,<br>
> > > On Sat, Aug 29, 2020 at 2:54 PM Christian Mauderer<br>
> <<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>><br>
> > > <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>>> wrote:<br>
> > ><br>
> > > Hello Niteesh<br>
> > ><br>
> > > On 29/08/2020 11:22, Niteesh G. S. wrote:<br>
> > > > On Sat, Aug 29, 2020 at 1:02 PM Christian Mauderer<br>
> > > <<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>><br>
> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>><br>
> > > > <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>><br>
> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a> <mailto:<a href="mailto:oss@c-mauderer.de" target="_blank">oss@c-mauderer.de</a>>>>> wrote:<br>
> > > ><br>
> > > > On 29/08/2020 05:57, Niteesh G. S. wrote:<br>
> > > > > On Sat, Aug 29, 2020 at 4:19 AM Gedare Bloom<br>
> > > <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>><br>
> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>>><br>
> > > > <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>><br>
> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>>>><br>
> > > > > <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>><br>
> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>>><br>
> > > <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>><br>
> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a> <mailto:<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>>>>>> wrote:<br>
> > > > ><br>
> > > > > Are "Links to commits" 1-4 all the code you (are<br>
> > > claiming you)<br>
> > > > wrote?<br>
> > > > > I just want to make sure. It looks fine to me.<br>
> > > > ><br>
> > > > > Yes, all the code in the commits is written by me.<br>
> > > ><br>
> > > > I think maybe "Links to branches" would be a better<br>
> title. It<br>
> > > is not a<br>
> > > > single commit each but a few commits. Alternative<br>
> would be to<br>
> > > add links<br>
> > > > to each commit.<br>
> > > ><br>
> > > ><br>
> > > > I have changed the title to "Links to branches". Should I<br>
> also add<br>
> > > links<br>
> > > > to the commits that were made in each phase at the end of the<br>
> > > summary of<br>
> > > > each phase?<br>
> > > ><br>
> > ><br>
> > > If you want, you can do that.<br>
> > ><br>
> > ><br>
> > > I did try that but it didn't work out well, especially with the<br>
> OFW commit.<br>
> > > Since I don't have the old commit I either had to leave that<br>
> commit out<br>
> > > in the first phase or I had to post the newer commit in the<br>
> first phase<br>
> > > itself which actually should in the last phase. So I decided to<br>
> avoid adding<br>
> > > the commits and just leave it out with the branches.<br>
> ><br>
> > That's OK too. Like I said: Main target was that it's clear that you<br>
> > don't have four commits but a bit more.<br>
> ><br>
> <br>
> Oh, I'm sorry I didn't notice this. We actually do want it to be<br>
> distinctly your commits. Since you have commits that are older than<br>
> this GSoC in rtems, you can't use the author filtering feature<br>
> (<a href="https://github.com/gs-niteesh/rtems/commits/beagle-rtems6-pinmux-18-aug?author=gs-niteesh" rel="noreferrer" target="_blank">https://github.com/gs-niteesh/rtems/commits/beagle-rtems6-pinmux-18-aug?author=gs-niteesh</a>)<br>
> so you'll probably need to generate the links to each commit.<br>
> <br>
> This is something required by Google.<br>
> <br>
> > ><br>
> > ><br>
> > > The main point of that change was to highlight that it's not<br>
> 4 commits<br>
> > > but a bit more.<br>
> > ><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > ><br>
> > > > It has been quite a bit of back and forth during this GSoC<br>
> > > project so I<br>
> > > > think the result is quite OK.<br>
> > > ><br>
> > > > Best regards<br>
> > > ><br>
> > > > Christian<br>
> > > ><br>
> > > > ><br>
> > > > > On Fri, Aug 28, 2020 at 12:07 PM Niteesh G. S.<br>
> > > > <<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>><br>
> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>>><br>
> > > <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>><br>
> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>>>><br>
> > > > > <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a><br>
> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>><br>
> > > <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>>><br>
> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>><br>
> > > <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a> <mailto:<a href="mailto:niteesh.gs@gmail.com" target="_blank">niteesh.gs@gmail.com</a>>>>>><br>
> > > > wrote:<br>
> > > > > ><br>
> > > > > > Hello,<br>
> > > > > ><br>
> > > > > > I have prepared my final report for my<br>
> project. You<br>
> > > can have a<br>
> > > > > look at it<br>
> > > > > > here<br>
> <a href="https://gs-niteesh.github.io/finalreport/" rel="noreferrer" target="_blank">https://gs-niteesh.github.io/finalreport/</a>. Please<br>
> > > kindly<br>
> > > > > review the report.<br>
> > > > > ><br>
> > > > > > Thanks,<br>
> > > > > > Niteesh.<br>
> > > > ><br>
> > > > ><br>
> > > > > _______________________________________________<br>
> > > > > devel mailing list<br>
> > > > > <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>><br>
> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>>><br>
> > > <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>><br>
> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a> <mailto:<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a>>>><br>
> > > > > <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
> > > > ><br>
> > > ><br>
> > ><br>
> <br>
</blockquote></div></div>