<div dir="ltr">This makes sense. Thanks for the explanation.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Sep 11, 2020 at 3:27 AM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Thu, Sep 10, 2020 at 12:56 PM Richi Dubey <<a href="mailto:richidubey@gmail.com" target="_blank">richidubey@gmail.com</a>> wrote:<br>
><br>
> Yes.<br>
><br>
>> You'll want to run a "clean" version also for comparison, to isolate<br>
>> problems you might introduce.<br>
><br>
> Shouldn't the clean version give no errors and timeouts? Cause mine does give failures.<br>
><br>
<br>
There are sometimes bugs or things we know that are broken. So you<br>
need to know the baseline state.<br>
<br>
> On Thu, Sep 10, 2020 at 9:02 PM Gedare Bloom <<a href="mailto:gedare@rtems.org" target="_blank">gedare@rtems.org</a>> wrote:<br>
>><br>
>> On Mon, Sep 7, 2020 at 8:55 AM Richi Dubey <<a href="mailto:richidubey@gmail.com" target="_blank">richidubey@gmail.com</a>> wrote:<br>
>> ><br>
>> > Invalid directory. Sorry for the doubt.<br>
>> ><br>
>><br>
>> Did you get it working?<br>
>><br>
>> You'll want to run a "clean" version also for comparison, to isolate<br>
>> problems you might introduce.<br>
>><br>
>> > On Mon, Sep 7, 2020 at 8:18 PM Richi Dubey <<a href="mailto:richidubey@gmail.com" target="_blank">richidubey@gmail.com</a>> wrote:<br>
>> >>><br>
>> >>> You should run all tests that doesn't explicitly configure a scheduler<br>
>> >>> with your new implementation.<br>
>> >><br>
>> >> I understand.<br>
>> >><br>
>> >>><br>
>> >>> Maybey add an<br>
>> >>> #ifndef CONFIGURE_MAXIMUM_PROCESSORS<br>
>> >>> #define CONFIGURE_MAXIMUM_PROCESSORS 1<br>
>> >>> #endif<br>
>> >>> before the default scheduler selection.<br>
>> >><br>
>> >> This works.<br>
>> >><br>
>> >> I am getting this error:<br>
>> >> ./rtems-test \ --log=log_leon3_sis \ --rtems-bsp=leon3-sis \ ~/quick-start/build/b-smp-leon3/sparc-rtems5/c/leon3/testsuites<br>
>> >> error: RTEMS Toolkit python wrapper not found, please report<br>
>> >><br>
>> >> As far as I remember, I had done --enable-tests while building my bsp.<br>
>> >><br>
>> >> On Mon, Sep 7, 2020 at 7:45 PM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>> wrote:<br>
>> >>><br>
>> >>> On 07/09/2020 16:09, Richi Dubey wrote:<br>
>> >>><br>
>> >>> > Did you<br>
>> >>> > use rtems-test before?<br>
>> >>> ><br>
>> >>> > No. I'll do it now.<br>
>> >>> ><br>
>> >>> > I am individually testing each smp test for now on this patch:<br>
>> >>> You should run all tests that doesn't explicitly configure a scheduler<br>
>> >>> with your new implementation.<br>
>> >>> > ---<br>
>> >>> > cpukit/include/rtems/confdefs/scheduler.h | 2 +-<br>
>> >>> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>> >>> ><br>
>> >>> > diff --git a/cpukit/include/rtems/confdefs/scheduler.h<br>
>> >>> > b/cpukit/include/rtems/confdefs/scheduler.h<br>
>> >>> > index 9305fc2d90..a93e765e53 100644<br>
>> >>> > --- a/cpukit/include/rtems/confdefs/scheduler.h<br>
>> >>> > +++ b/cpukit/include/rtems/confdefs/scheduler.h<br>
>> >>> > @@ -55,7 +55,7 @@<br>
>> >>> > && !defined(CONFIGURE_SCHEDULER_STRONG_APA) \<br>
>> >>> > && !defined(CONFIGURE_SCHEDULER_USER)<br>
>> >>> > #if defined(RTEMS_SMP) && _CONFIGURE_MAXIMUM_PROCESSORS > 1<br>
>> >>> > - #define CONFIGURE_SCHEDULER_EDF_SMP<br>
>> >>> > + #define CONFIGURE_SCHEDULER_STRONG_APA<br>
>> >>> > #else<br>
>> >>> > #define CONFIGURE_SCHEDULER_PRIORITY<br>
>> >>> > #endif<br>
>> >>> > --<br>
>> >>> ><br>
>> >>> > -----------------------------------------------------------------------------------<br>
>> >>> > because your suggested patch gives this error:<br>
>> >>> ><br>
>> >>> ><br>
>> >>> > -----------------------------------------------------------------------------------<br>
>> >>> > In file included from<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs/scheduler.h:64:0,<br>
>> >>> > from<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs/threads.h:48,<br>
>> >>> > from<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs/objectsposix.h:47,<br>
>> >>> > from<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs.h:77,<br>
>> >>> > from<br>
>> >>> > /home/richi/quick-start/src/rtems/c/src/../../testsuites/samples/base_sp/system.h:39,<br>
>> >>> > from<br>
>> >>> > /home/richi/quick-start/src/rtems/c/src/../../testsuites/samples/base_sp/init.c:15:<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/scheduler.h:260:37:<br>
>> >>> > error: 'CONFIGURE_MAXIMUM_PROCESSORS' undeclared here (not in a<br>
>> >>> > function); did you mean '_CONFIGURE_MAXIMUM_PROCESSORS'?<br>
>> >>> > Scheduler_strong_APA_CPU CPU[ CONFIGURE_MAXIMUM_PROCESSORS ]; \<br>
>> >>> > ^<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs/scheduler.h:149:7:<br>
>> >>> > note: in expansion of macro 'RTEMS_SCHEDULER_STRONG_APA'<br>
>> >>> > RTEMS_SCHEDULER_STRONG_APA( \<br>
>> >>> > ^~~~~~~~~~~~~~~~~~~~~~~~~~<br>
>> >>> > /home/richi/quick-start/src/rtems/cpukit/include/rtems/confdefs/scheduler.h:236:3:<br>
>> >>> > note: in expansion of macro 'CONFIGURE_SCHEDULER'<br>
>> >>> > CONFIGURE_SCHEDULER;<br>
>> >>> > ^~~~~~~~~~~~~~~~~~~<br>
>> >>> > Makefile:939: recipe for target 'base_sp/base_sp-init.o'<br>
>> >>> > failedp-init.o' failed<br>
>> >>> ><br>
>> >>> > -----------------------------------------------------------------------------------<br>
>> >>> ><br>
>> >>> > This is because single processor scheduler doesn't<br>
>> >>> > have CONFIGURE_MAXIMUM_PROCESSORS defined, So, would you like for me<br>
>> >>> > to make separate definition of CONFIGURE_SCHEDULER_STRONG_APA in<br>
>> >>> > cpukit/include/rtems/scheduler.h for a single processor system or does<br>
>> >>> > the current version that'd work only for SMP processor serve the purpose?<br>
>> >>><br>
>> >>> Maybey add an<br>
>> >>><br>
>> >>> #ifndef CONFIGURE_MAXIMUM_PROCESSORS<br>
>> >>><br>
>> >>> #define CONFIGURE_MAXIMUM_PROCESSORS 1<br>
>> >>><br>
>> >>> #endif<br>
>> >>><br>
>> >>> before the default scheduler selection.<br>
>> >>><br>
>> > _______________________________________________<br>
>> > devel mailing list<br>
>> > <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>> > <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div>