<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Oct 7, 2020 at 9:01 AM Sebastian Huber <<a href="mailto:sebastian.huber@embedded-brains.de">sebastian.huber@embedded-brains.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
On 07/10/2020 15:54, Joel Sherrill wrote:<br>
> x86_64 failures that Sebastian says should be fixed,<br>
Someone has to say yes or no to the patch.<br>
> and raspberry pi failures which are because Pi doesn't support SMP.<br>
This should be fixed.<br>
> That still leaves 43 failures to account for.<br>
><br>
> About half of those appear to be a build failure in griscv BSPs (#4128).<br>
I don't have time to fix this today.<br></blockquote><div><br></div><div>Any idea what should be done for this fatal error then? It looks like a simple change but a matter of knowing what to do.</div><div><br></div><div>Is the compiler suggestion correct? I'm happy to make the change and restart a build before the end of the day. </div><div><br></div><div>./../../../../../../../rtems/c/src/lib/libbsp/riscv/griscv/../../../../../../bsps/riscv/griscv/clock/clockdrv.c: In function 'grlib_clock_initialize':<br>../../../../../../../../rtems/c/src/lib/libbsp/riscv/griscv/../../../../../../bsps/riscv/griscv/clock/clockdrv.c:174:10: warning: implicit declaration of function 'grlib_irqmp_has_timestamp' [-Wimplicit-function-declaration]<br>  174 |     if (!grlib_irqmp_has_timestamp(irqmp_ts)) {<br>      |          ^~~~~~~~~~~~~~~~~~~~~~~~~<br>../../../../../../../../rtems/c/src/lib/libbsp/riscv/griscv/../../../../../../bsps/riscv/griscv/clock/clockdrv.c:174:10: warning: nested extern declaration of 'grlib_irqmp_has_timestamp' [-Wnested-externs]<br>../../../../../../../../rtems/c/src/lib/libbsp/riscv/griscv/../../../../../../bsps/riscv/griscv/clock/clockdrv.c:175:17: error: 'GRLIB_FATAL_CLOCK_NO_IRQMP_TIMESTAMP_SUPPORT' undeclared (first use in this function); did you mean 'LEON3_FATAL_CLOCK_NO_IRQMP_TIMESTAMP_SUPPORT'?<br>  175 |       bsp_fatal(GRLIB_FATAL_CLOCK_NO_IRQMP_TIMESTAMP_SUPPORT);<br>      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>      |                 LEON3_FATAL_CLOCK_NO_IRQMP_TIMESTAMP_SUPPORT<br>../../../../../../../../rtems/c/src/lib/libbsp/riscv/griscv/../../../../../../bsps/riscv/griscv/clock/clockdrv.c:175:17: note: each undeclared identifier is reported only once for each function it appears in<br>gmake[6]: *** [clockdrv.o] Error 1<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Others are scattered across arm.<br>
This should be already fixed.<br>
</blockquote></div></div>