<div dir="ltr"><div dir="ltr">Hi Kinsey,<div><br></div><div>Thanks for reviewing the patch...</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Nov 15, 2020 at 9:51 AM Kinsey Moore <<a href="mailto:kinsey.moore@oarcorp.com" target="_blank">kinsey.moore@oarcorp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Odd, "gic_version" works just fine in the version of qemu-system-aarch64 in the Debian package repos which is what I've been testing against. As you've provided in the patch, the official option name is "gic-version" and that also works. Just out of curiosity, does this cause Qemu to fail for you?</blockquote><div>Qemu 5.0 crashes with:</div><div>```</div><div>qemu-system-aarch64: Property '.gic_version' not found</div><div>```</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Either way, this change looks good to me.<br></blockquote><div><br></div><div>Thanks, I'll push. </div><div><br></div><div>Best regards,</div><div>Vijay</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Kinsey<br>
<br>
-----Original Message-----<br>
From: devel <<a href="mailto:devel-bounces@rtems.org" target="_blank">devel-bounces@rtems.org</a>> On Behalf Of Vijay Kumar Banerjee<br>
Sent: Saturday, November 14, 2020 14:51<br>
To: <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
Subject: [PATCH rtems-tools] bsps/a53_*: Fix typo in qemu options<br>
<br>
---<br>
 tester/rtems/testing/bsps/a53_ilp32_qemu.ini | 2 +-  tester/rtems/testing/bsps/a53_lp64_qemu.ini  | 2 +-<br>
 2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini<br>
index 6dfc883..3beba06 100644<br>
--- a/tester/rtems/testing/bsps/a53_ilp32_qemu.ini<br>
+++ b/tester/rtems/testing/bsps/a53_ilp32_qemu.ini<br>
@@ -35,4 +35,4 @@<br>
 bsp           = a53_ilp32_qemu<br>
 arch          = aarch64<br>
 tester        = %{_rtscripts}/qemu.cfg<br>
-bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine virt,gic_version=3 -cpu cortex-a53 -m 4096<br>
+bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine <br>
+virt,gic-version=3 -cpu cortex-a53 -m 4096<br>
diff --git a/tester/rtems/testing/bsps/a53_lp64_qemu.ini b/tester/rtems/testing/bsps/a53_lp64_qemu.ini<br>
index f29ab13..1b89284 100644<br>
--- a/tester/rtems/testing/bsps/a53_lp64_qemu.ini<br>
+++ b/tester/rtems/testing/bsps/a53_lp64_qemu.ini<br>
@@ -35,4 +35,4 @@<br>
 bsp           = a53_lp64_qemu<br>
 arch          = aarch64<br>
 tester        = %{_rtscripts}/qemu.cfg<br>
-bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine virt,gic_version=3 -cpu cortex-a53 -m 4096<br>
+bsp_qemu_opts = %{qemu_opts_base} -serial mon:stdio -machine <br>
+virt,gic-version=3 -cpu cortex-a53 -m 4096<br>
--<br>
2.21.1<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>