<div dir="ltr"><div dir="ltr">Hi Robin,</div><div dir="ltr"><br></div><div>Thank you for providing the documentation for the variant. I guess it may evolve slightly due to the patch review on the code, but I have a couple of notes for you below.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 6, 2021 at 9:08 AM Robin.Mueller <<a href="mailto:robin.mueller.m@gmail.com">robin.mueller.m@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">More informaion on where to find adaption points to different<br>
board variations and also instructions on how to configure<br>
the BSP build for a certain board variation<br>
---<br>
user/bsps/arm/stm32h7.rst | 11 ++++++++++-<br>
1 file changed, 10 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/user/bsps/arm/stm32h7.rst b/user/bsps/arm/stm32h7.rst<br>
index 3eee511..a373e70 100644<br>
--- a/user/bsps/arm/stm32h7.rst<br>
+++ b/user/bsps/arm/stm32h7.rst<br>
@@ -11,16 +11,25 @@ This BSP supports the<br>
The BSP is known to run on these boards:<br>
<br>
* `STM32H743I-EVAL 2 <<a href="https://www.st.com/en/evaluation-tools/stm32h743i-eval.html" rel="noreferrer" target="_blank">https://www.st.com/en/evaluation-tools/stm32h743i-eval.html</a>>`_<br>
+* `STM32H743ZI-Nucleo <<a href="https://www.st.com/en/evaluation-tools/nucleo-h743zi.html" rel="noreferrer" target="_blank">https://www.st.com/en/evaluation-tools/nucleo-h743zi.html</a>>`_<br>
<br>
Clock Driver<br>
------------<br>
<br>
-The clock driver uses the `ARMv7-M Systick` module.<br>
+The clock driver uses the `ARMv7-M Systick` module. The HSE (external oscillator) value can also be different for different evaluation or custom boards, so it is recommended to check the default values of the BSP.<br>
<br></blockquote><div><br></div><div>Please break your lines in the docs also at 80 characters, here and below.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Console Driver<br>
--------------<br>
<br>
The console driver supports the on-chip UART and USART modules.<br>
+Different board variations use different GPIO pins and blocks for the default communication UART and it is recommended to check whetheer the default configuration provided is valid in the BSP.<br>
+<br></blockquote><div>s/whetheer/whether</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+To specify that the BSP should be built for the STM32H743ZI-Nucleo board,<br>
+users can supply ``STM32H743ZI_NUCLEO == True`` to ``config.ini`` when building the<br>
+BSP.<br>
+<br>
+Alternatively, users can supply the configuration structs defined in ``hal.h``<br>
+in the applicaton for other boards. For the console driver, the ``stm32h7_usartX_config`` structs are used to configure the GPIO pins and other parameters. The default implementations can be found in ``bsps/arm/stm32ht/console`` in the RTEMS sources.<br>
<br>
Network Interface Driver<br>
------------------------<br>
-- <br>
2.25.1<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>