<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.E-MailFormatvorlage18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">Ok, I asked if it is ok to use the English name for our organization as well.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">The answer might take some time, though.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"> Jan<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b>From:</b> Joel Sherrill <joel@rtems.org> <br>
<b>Sent:</b> Monday, February 15, 2021 9:41 PM<br>
<b>To:</b> Peter Dufault <dufault@hda.com><br>
<b>Cc:</b> Sommer, Jan <Jan.Sommer@dlr.de>; rtems-devel@rtems.org <devel@rtems.org><br>
<b>Subject:</b> Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Christian submitted a series of patches to eliminate unicode. I'd prefer if we avoided it <o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Feb 15, 2021, 8:20 AM Peter Dufault <<a href="mailto:dufault@hda.com">dufault@hda.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">An international project should allow UTF in source code. You might need to hunt what setting you need (for gnome-terminal "export LANG=en_US.UTF-8" works for me in the US). I'm surprised if anyone is working on a system that can't at
least display UTF-8.<br>
<br>
> On Feb 15, 2021, at 03:21 , <a href="mailto:Jan.Sommer@dlr.de" target="_blank">
Jan.Sommer@dlr.de</a> wrote:<br>
> <br>
> Hi Chris,<br>
> <br>
>> -----Original Message-----<br>
>> From: Chris Johns <<a href="mailto:chrisj@rtems.org" target="_blank">chrisj@rtems.org</a>><br>
>> Sent: Sunday, February 14, 2021 10:20 PM<br>
>> To: Sommer, Jan <<a href="mailto:Jan.Sommer@dlr.de" target="_blank">Jan.Sommer@dlr.de</a>>;
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
>> Subject: Re: [PATCH v3 1/3] bsps/xilinx_zynq: Add SPI driver for cadence-spi<br>
>> <br>
>> Hi Jan,<br>
>> <br>
>> Thank you for the changes. I have one question inlined below ...<br>
>> <br>
>> On 14/2/21 10:30 pm, Jan Sommer wrote:<br>
>>> ---<br>
>>> bsps/include/dev/spi/cadence-spi-regs.h | 84 +++++<br>
>>> bsps/include/dev/spi/cadence-spi.h | 48 +++<br>
>>> bsps/shared/dev/spi/cadence-spi.c | 437<br>
>> ++++++++++++++++++++++++<br>
>>> 3 files changed, 569 insertions(+)<br>
>>> create mode 100644 bsps/include/dev/spi/cadence-spi-regs.h<br>
>>> create mode 100644 bsps/include/dev/spi/cadence-spi.h<br>
>>> create mode 100644 bsps/shared/dev/spi/cadence-spi.c<br>
>>> <br>
>>> diff --git a/bsps/include/dev/spi/cadence-spi-regs.h<br>
>>> b/bsps/include/dev/spi/cadence-spi-regs.h<br>
>>> new file mode 100644<br>
>>> index 0000000000..2851c88df1<br>
>>> --- /dev/null<br>
>>> +++ b/bsps/include/dev/spi/cadence-spi-regs.h<br>
>>> @@ -0,0 +1,84 @@<br>
>>> +/* SPDX-License-Identifier: BSD-2-Clause */<br>
>>> +<br>
>>> +/*<br>
>>> + * Copyright (C) 2020 Jan Sommer, Deutsches Zentrum für Luft- und<br>
>> Raumfahrt e. V.<br>
>> <br>
>> Is there a unicode character in this line? I cannot see anything in our coding<br>
>> standard about unicode characters in source and I am not sure what the<br>
>> actual policy is. I seem to remember some have been removed in the past. I<br>
>> thought I would ask on the list now before we push these changes.<br>
>> <br>
> <br>
> There is an u-Umlaut in it. That is probably it. As it is part of the name, it's hard to get rid of.<br>
> I could probably use the English name (German Aerospace Center) which has no special characters.<br>
> Would that be preferred?<br>
> <br>
> Best regards,<br>
> <br>
> Jan<br>
> <br>
>> Chris<br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
<br>
Peter<br>
-----------------<br>
Peter Dufault<br>
HD Associates, Inc. Software and System Engineering<br>
<br>
This email is delivered through the public internet using protocols subject to interception and tampering.<br>
<br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>