<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 18, 2021 at 11:21 AM Gedare Bloom <<a href="mailto:gedare@rtems.org">gedare@rtems.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Feb 17, 2021 at 12:31 PM Sebastian Huber<br>
<<a href="mailto:sebastian.huber@embedded-brains.de" target="_blank">sebastian.huber@embedded-brains.de</a>> wrote:<br>
><br>
> The api pointer is never NULL.<br>
><br>
> Update #4244.<br>
> ---<br>
>  cpukit/posix/src/psignalunblockthread.c | 6 ------<br>
>  1 file changed, 6 deletions(-)<br>
><br>
> diff --git a/cpukit/posix/src/psignalunblockthread.c b/cpukit/posix/src/psignalunblockthread.c<br>
> index 63ed823ab3..a1af20a5af 100644<br>
> --- a/cpukit/posix/src/psignalunblockthread.c<br>
> +++ b/cpukit/posix/src/psignalunblockthread.c<br>
> @@ -111,12 +111,6 @@ static void _POSIX_signals_Action_handler(<br>
>     */<br>
>    hold_errno = executing->Wait.return_code;<br>
><br>
> -  /*<br>
> -   * api may be NULL in case of a thread close in progress<br>
> -   */<br>
> -  if ( !api )<br>
> -    return;<br>
> -<br>
I believe you, but should we replace this with an assert for now?<br></blockquote><div><br></div><div>And a comment explaining why it can't be NULL.  <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
>    /*<br>
>     *  In case the executing thread is blocked or about to block on something<br>
>     *  that uses the thread wait information, then this is a kernel bug.<br>
> --<br>
> 2.26.2<br>
><br>
> _______________________________________________<br>
> devel mailing list<br>
> <a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
> <a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel" rel="noreferrer" target="_blank">http://lists.rtems.org/mailman/listinfo/devel</a><br>
</blockquote></div></div>