<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi,</p>
<p>The patch looks good. The fall through is by design intended.</p>
<p>Thanks,<br>
</p>
<div class="moz-signature">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<title></title>
<pre>Daniel Hellstrom
Software Section Head
T : +46 (0) 31 775 8657
F : +46 (0) 31 421407
<a href="mailto:daniel@gaisler.com">daniel@gaisler.com</a>
To receive update notifications, please subscribe to <a href="https://gaisler.com/newsletter">https://gaisler.com/newsletter</a>
Cobham Gaisler AB, Kungsgatan 12, SE-411 19, GÖTEBORG, Sweden.
+46 (0) 31 775 8650, <a class="moz-txt-link-abbreviated" href="http://www.cobhamaes.com/gaisler">www.cobhamaes.com/gaisler</a>
<font color="#339900">Please consider the environment before printing this email</font>
</pre>
</div>
<div class="moz-cite-prefix">On 2021-03-04 21:02, Ryan Long wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1614888164-5451-2-git-send-email-ryan.long@oarcorp.com">
<pre class="moz-quote-pre" wrap="">CID 1399761: Missing break in switch in process_dma().
CID 1399765: Missing break in switch in process_dma().
CID 1399766: Missing break in switch in process_dma().
CID 1399777: Missing break in switch in process_dma().
Closes #4277
---
bsps/shared/grlib/tmtc/grtc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/bsps/shared/grlib/tmtc/grtc.c b/bsps/shared/grlib/tmtc/grtc.c
index e9acea4..f734f2e 100644
--- a/bsps/shared/grlib/tmtc/grtc.c
+++ b/bsps/shared/grlib/tmtc/grtc.c
@@ -1365,6 +1365,7 @@ static int process_dma(struct grtc_priv *pDev)
/* Start of frame found, Try to copy header */
pDev->frm = NULL;
pDev->frame_state = FRM_STATE_HDR;
+ /* Fall through */
case FRM_STATE_HDR:
DBG2("FRAME_STATE_HDR\n");
@@ -1396,6 +1397,7 @@ static int process_dma(struct grtc_priv *pDev)
return -1;
}
pDev->frame_state = FRM_STATE_ALLOC;
+ /* Fall through */
case FRM_STATE_ALLOC:
DBG2("FRAME_STATE_ALLOC\n");
@@ -1449,6 +1451,7 @@ static int process_dma(struct grtc_priv *pDev)
pDev->frame_state = FRM_STATE_PAYLOAD;
pDev->frm = frm;
+ /* Fall through */
case FRM_STATE_PAYLOAD:
DBG2("FRAME_STATE_PAYLOAD\n");
@@ -1476,6 +1479,7 @@ static int process_dma(struct grtc_priv *pDev)
}
frm->len += ret;
pDev->frame_state = FRM_STATE_FILLER;
+ /* Fall through */
case FRM_STATE_FILLER:
DBG2("FRAME_STATE_FILLER\n");
</pre>
</blockquote>
</body>
</html>