<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<pre>
</pre>
<div class="moz-cite-prefix">On 2021-03-08 16:43, Joel Sherrill
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sun, Mar 7, 2021 at 9:51
AM Daniel Hellstrom <<a href="mailto:daniel@gaisler.com"
target="_blank" moz-do-not-send="true">daniel@gaisler.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<div>On 2020-09-23 17:05, Gedare Bloom wrote:<br>
</div>
<blockquote type="cite">
<pre>On Wed, Sep 23, 2020 at 4:34 AM Daniel Hellstrom <a href="mailto:daniel@gaisler.com" target="_blank" moz-do-not-send="true"><daniel@gaisler.com></a> wrote:
</pre>
<blockquote type="cite">
<pre>Hi Sebastian,
Thanks for asking and sorry for dropping the ball on these.
The status is that two needs updating (BSD license for new CAN files and
the last tn0018 patch needs some redesign based on feedback) and the
others are accepted for master. I've sent an response on the tn0018
errata patch just now. I would like to push them on the 5 and master
branches. To get them onto 5, should I create a ticket for the whole
patch set? I will try getting this done next next couple of days, and
have a look at you patches too, thanks!
</pre>
</blockquote>
<pre>It would be good to separate them logically to the TN-0018 errata
fixes vs the CAN/grlib improvements. The concern for pushing them to 5
is that they touch core sparc files, but since you guys are releasing
them this way in RCC I'm also comfortable with it. I didn't see any
changes outside the sparc (since currently grlib is sparc-specific
too). We'll need those tickets to help us with the dot-release notes.</pre>
</blockquote>
<p>Sorry for my very late response. There were some more
updates on a few of the patches based on the review
comments which has been addressed. I have now created
tickets for all of them which are referenced from the
patches, so I will go ahead and push them for the
5-branch (the posted patches targeted 5).</p>
</div>
</blockquote>
<div><br>
</div>
<div>I agree with Gedare on trusting the patches. My only
concern is making sure proper tickets are filed. A couple of
guidelines may help decide how many tickets and for what. </div>
<div><br>
</div>
<div>The first thing to remember is that tickets are
automatically processed into release notes. If it is
important enough to show up in a release note, file a
ticket. I have been prodding Ryan to file tickets for the
Coverity issues because I think they should be in release
notes.</div>
<div><br>
</div>
<div>For 5, any changes should have tickets. This is a long
standing rule for release branches.</div>
</div>
</div>
</blockquote>
<p>Thanks for the comments, I will keep that in mind going forward.
I made a couple of tickets for the RTEMS/master and tickets for
all patches for 5.2 milestone.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p> However, I will wait with the TN-0018 before I get an
acknowledge for that one. I updated the its ticket with
links to the GCC patch that has now been accepted into
upstreams GCC (GCC-10 stable and master). The TN0018
patch is not enabled if the GCC-patch is not included in
the toolchain, so I believe it should be ok to push,
even before RSB is updated?<br>
</p>
</div>
</blockquote>
<div><br>
</div>
<div>It sounds like it will be ok.</div>
</div>
</div>
</blockquote>
Ok, thanks!<br>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>What happens with TN0018 on the 5 branch where we are
using older tools? </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p> </p>
<p> <a href="https://devel.rtems.org/ticket/4155"
target="_blank" moz-do-not-send="true">https://devel.rtems.org/ticket/4155</a><br>
</p>
</div>
</blockquote>
</div>
</div>
</blockquote>
<p>I have submitted a RSB patch which as been acked by Chris and
Sebastian, so I will proceed to push the tn0018 patch to 5 now.<br>
</p>
<p><br>
</p>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p> </p>
<p>Next step for me is to add some configurations for the
new build system before I can push them to RTEMS/master.</p>
</div>
</blockquote>
</div>
</div>
</blockquote>
This has been done and pushed now. waf is really a speed
improvement! Thanks!<br>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Thanks for submitting all these. Is this going to clean
your queue?</div>
</div>
</div>
</blockquote>
<p>The queue is much smaller now! These were the most important when
I started but got choked, I will follow up with a few important
fixes done lately.</p>
<p>/Daniel<br>
</p>
<blockquote type="cite"
cite="mid:CAF9ehCUedxxUmrXNH0XZLJkDyNWuyBOWUR2298PqLE8EYpaqvQ@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>--joel </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p>Thanks,<br>
/Daniel<br>
</p>
<p><br>
</p>
<blockquote type="cite">
<blockquote type="cite">
<pre>Kind Regards,
Daniel
On 2020-09-18 10:03, Sebastian Huber wrote:
</pre>
<blockquote type="cite">
<pre>Hallo Daniel,
what are your plans with respect to this patch set?
Please also have a look at:
<a href="https://lists.rtems.org/pipermail/devel/2020-September/062176.html" target="_blank" moz-do-not-send="true">https://lists.rtems.org/pipermail/devel/2020-September/062176.html</a>
</pre>
</blockquote>
<pre>_______________________________________________
devel mailing list
<a href="mailto:devel@rtems.org" target="_blank" moz-do-not-send="true">devel@rtems.org</a>
<a href="http://lists.rtems.org/mailman/listinfo/devel" target="_blank" moz-do-not-send="true">http://lists.rtems.org/mailman/listinfo/devel</a>
</pre>
</blockquote>
</blockquote>
</div>
_______________________________________________<br>
devel mailing list<br>
<a href="mailto:devel@rtems.org" target="_blank"
moz-do-not-send="true">devel@rtems.org</a><br>
<a href="http://lists.rtems.org/mailman/listinfo/devel"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.rtems.org/mailman/listinfo/devel</a></blockquote>
</div>
</div>
</blockquote>
</body>
</html>